You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metron.apache.org by 2xyo <gi...@git.apache.org> on 2016/08/22 07:56:19 UTC
[GitHub] incubator-metron pull request #221: METRON-384 Allow elasticsearch to bind t...
GitHub user 2xyo opened a pull request:
https://github.com/apache/incubator-metron/pull/221
METRON-384 Allow elasticsearch to bind to loopback addresses
This PR addresses https://issues.apache.org/jira/browse/METRON-384
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/2xyo/incubator-metron patch-4
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-metron/pull/221.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #221
----
commit 91c204b8eb088d4aa52c7f06ad481eba171f1d8e
Author: 2*yo <yo...@lepage.info>
Date: 2016-08-22T07:55:51Z
METRON-384 Allow elasticsearch to bind to loopback addresses
This PR addresses https://issues.apache.org/jira/browse/METRON-384
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron issue #221: METRON-384 Allow elasticsearch to bind to loopb...
Posted by dlyle65535 <gi...@git.apache.org>.
Github user dlyle65535 commented on the issue:
https://github.com/apache/incubator-metron/pull/221
Could you post an email address to use for the commit? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron issue #221: METRON-384 Allow elasticsearch to bind to loopb...
Posted by dlyle65535 <gi...@git.apache.org>.
Github user dlyle65535 commented on the issue:
https://github.com/apache/incubator-metron/pull/221
I'm +1 on this, thanks for the contribution.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron issue #221: METRON-384 Allow elasticsearch to bind to loopb...
Posted by dlyle65535 <gi...@git.apache.org>.
Github user dlyle65535 commented on the issue:
https://github.com/apache/incubator-metron/pull/221
Sorry, I meant eth0 only. I'd try adding network_host: _{{
elasticsearch_network_interface }}:ipv4_' } to the role's defaults and then you can override it in the group vars to whatever you'd like rather than mess with looping.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron issue #221: METRON-384 Allow elasticsearch to bind to loopb...
Posted by dlyle65535 <gi...@git.apache.org>.
Github user dlyle65535 commented on the issue:
https://github.com/apache/incubator-metron/pull/221
I like what you did here, but could you expose it as a parameter and default it to ipv4 instead?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron issue #221: METRON-384 Allow elasticsearch to bind to loopb...
Posted by 2xyo <gi...@git.apache.org>.
Github user 2xyo commented on the issue:
https://github.com/apache/incubator-metron/pull/221
So, you would recommend something like this:
New `elasticsearch.yml`:
```
- { regexp: '^# *network\.host:', line: 'network.host: {{elasticsearch_network_interface }}' }
```
New `full-dev-platform/group_vars/all`, `multinode-vagrant/group_vars/all`:
```
elasticsearch_network_interface: _eth1:ipv4_
```
And new `metron_example/group_vars/all `, `amazon-ec2/conf/defaults.yml`:
```
elasticsearch_network_interface: _eth0:ipv4_
```
But, in this case, elasticsearch will not listening to localhost by default (and that's why I opened this issue). IMHO, the default value should be instead:
```
elasticsearch_network_interface: ["_eth1:ipv4_","_local:ipv4_"]
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron issue #221: METRON-384 Allow elasticsearch to bind to loopb...
Posted by 2xyo <gi...@git.apache.org>.
Github user 2xyo commented on the issue:
https://github.com/apache/incubator-metron/pull/221
Thanks! Here is my email: yohann@lepage.info
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request #221: METRON-384 Allow elasticsearch to bind t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-metron/pull/221
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron issue #221: METRON-384 Allow elasticsearch to bind to loopb...
Posted by 2xyo <gi...@git.apache.org>.
Github user 2xyo commented on the issue:
https://github.com/apache/incubator-metron/pull/221
Thanks @dlyle65535 for the feedback.
Would you prefer a configuration like this?
Old `full-dev-platform/group_vars/all`:
```
elasticsearch_network_interface: eth0
```
New `full-dev-platform/group_vars/all`:
```
elasticsearch_network_interface:
- eth0
- local
```
If yes, I dont' know how to implement a loop with the `lineinfile` module :/
Could you also elaborate the "ipv4 instead"? (As the result is already ipv4 only "`network.host: ["_eth0:ipv4_","_local:ipv4_"]`" )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---