You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by "Bartlomiej (Jira)" <ji...@apache.org> on 2022/10/22 19:01:00 UTC

[jira] [Commented] (MSHARED-1149) DependencyClassFileVisitor should use Logger

    [ https://issues.apache.org/jira/browse/MSHARED-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622684#comment-17622684 ] 

Bartlomiej commented on MSHARED-1149:
-------------------------------------

Hi, 

I created [PR|https://github.com/apache/maven-dependency-analyzer/pull/71] with solution of this issue. 

I added Slfj4 to dependencies, because this project doesn't have any logger system configured. 

In addition, I found few places in a test classes where  {{System.out}} is used, but I did not change it. That need additional ticket.


> DependencyClassFileVisitor should use Logger
> --------------------------------------------
>
>                 Key: MSHARED-1149
>                 URL: https://issues.apache.org/jira/browse/MSHARED-1149
>             Project: Maven Shared Components
>          Issue Type: Bug
>          Components: maven-dependency-analyzer
>            Reporter: Elliotte Rusty Harold
>            Priority: Minor
>
> org.apache.maven.shared.dependency.analyzer.asm.DependencyClassFileVisitor  should use a logger instead of just printing to System.out. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)