What is "Solr core"?

[Ilan Ginzburg <il...@gmail.com>]

In code review/design discussions I've seen a few time comments made
about a feature or piece of code: "it doesn't belong in [Solr] core".

What's the definition of Solr "core" other than it being an IntelliJ
module? Does core have access to things that can't be accessed from
elsewhere? (like an OS kernel that can do processor tricks that use
code is not allowed to). Or is it a dependency graph where "core"
depends on nothing outside of core, but anything outside of core can
depend on core?

In other words, what's the cost of moving "outside of core" something
that's in core, and what's the value of doing so?

Thanks,
Ilan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org

Re: What is "Solr core"?

[Ishan Chattopadhyaya <ic...@gmail.com>]

Yes, solr-core usually means /solr/core module in the repository. It also
refers to the generated artifact solr-core-<VERSION>.jar.

> Or is it a dependency graph where "core"
> depends on nothing outside of core, but anything outside of core can
> depend on core?

solr-core depends on solrj module, but nothing else outside. Other modules
can/should depend on solr-core or solrj.

> In other words, what's the cost of moving "outside of core" something
> that's in core, and what's the value of doing so?

Outside the core means solr-core will have no traces of something in it.
Value is to reduce the clutter in solr-core. That way, only essential and
important functionality stays in solr-core, and hence reviews are simpler:
any PR that touches solr-core should get urgent attention, because it can
potentially disrupt the stability of Solr for its essential and default
functionality. Today, even almost all PRs touch solr-core, and hence the
potential of someone inadvertently making changes that mess up important
parts without others knowing how urgent that PR is.

On Thu, Oct 1, 2020 at 2:14 PM Ilan Ginzburg <il...@gmail.com> wrote:

> In code review/design discussions I've seen a few time comments made
> about a feature or piece of code: "it doesn't belong in [Solr] core".
>
> What's the definition of Solr "core" other than it being an IntelliJ
> module? Does core have access to things that can't be accessed from
> elsewhere? (like an OS kernel that can do processor tricks that use
> code is not allowed to). Or is it a dependency graph where "core"
> depends on nothing outside of core, but anything outside of core can
> depend on core?
>
> In other words, what's the cost of moving "outside of core" something
> that's in core, and what's the value of doing so?
>
> Thanks,
> Ilan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>