You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Dan Smith <ds...@pivotal.io> on 2015/09/11 02:57:49 UTC
Review Request 38283: GEODE-320: Close the cache in
DistributedTestCase tear down
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38283/
-----------------------------------------------------------
Review request for geode and Kirk Lund.
Repository: geode
Description
-------
Close the cache in distributed test case teardown to deal with bad
behaving tests that aren't cleaning up their cache.
Also, adding a log that shows us what tests ran previously to help debug
in situations where the progress file is not available.
Diffs
-----
gemfire-core/src/test/java/com/gemstone/gemfire/cache30/CacheTestCase.java e318370a3643de4bb64578911e0f410326ed7857
gemfire-core/src/test/java/com/gemstone/gemfire/cache30/RegionTestCase.java 4b20b424b9891dace83d831ded28177ce39bbc6b
gemfire-core/src/test/java/dunit/DistributedTestCase.java 2e7ac0362c5605f7c5954baca16bcf4912f90acd
Diff: https://reviews.apache.org/r/38283/diff/
Testing
-------
Thanks,
Dan Smith
Re: Review Request 38283: GEODE-320: Close the cache in
DistributedTestCase tear down
Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38283/#review98889
-----------------------------------------------------------
Ship it!
Ship It!
- Kirk Lund
On Sept. 11, 2015, 12:57 a.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38283/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2015, 12:57 a.m.)
>
>
> Review request for geode and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Close the cache in distributed test case teardown to deal with bad
> behaving tests that aren't cleaning up their cache.
>
> Also, adding a log that shows us what tests ran previously to help debug
> in situations where the progress file is not available.
>
>
> Diffs
> -----
>
> gemfire-core/src/test/java/com/gemstone/gemfire/cache30/CacheTestCase.java e318370a3643de4bb64578911e0f410326ed7857
> gemfire-core/src/test/java/com/gemstone/gemfire/cache30/RegionTestCase.java 4b20b424b9891dace83d831ded28177ce39bbc6b
> gemfire-core/src/test/java/dunit/DistributedTestCase.java 2e7ac0362c5605f7c5954baca16bcf4912f90acd
>
> Diff: https://reviews.apache.org/r/38283/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>