You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/08 01:17:44 UTC
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11956: feat: add modal to import charts
codecov-io edited a comment on pull request #11956:
URL: https://github.com/apache/incubator-superset/pull/11956#issuecomment-740292381
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=h1) Report
> Merging [#11956](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=desc) (990ca8a) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2b9695c52024b624631ac27c0f2194e280effdb8?el=desc) (2b9695c) will **decrease** coverage by `4.33%`.
> The diff coverage is `71.25%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11956 +/- ##
==========================================
- Coverage 67.70% 63.36% -4.34%
==========================================
Files 938 940 +2
Lines 45437 45560 +123
Branches 4358 4378 +20
==========================================
- Hits 30761 28868 -1893
- Misses 14573 16515 +1942
- Partials 103 177 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.91% <62.90%> (-0.01%)` | :arrow_down: |
| python | `63.63% <95.34%> (-0.60%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/views/CRUD/data/dataset/AddDatasetModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0FkZERhdGFzZXRNb2RhbC50c3g=) | `57.57% <ø> (ø)` | |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `68.85% <46.15%> (-14.79%)` | :arrow_down: |
| [...ontend/src/views/CRUD/data/dataset/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0RhdGFzZXRMaXN0LnRzeA==) | `68.58% <61.53%> (-0.65%)` | :arrow_down: |
| [...rontend/src/chart/components/ImportModal/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NvbXBvbmVudHMvSW1wb3J0TW9kYWwvaW5kZXgudHN4) | `65.30% <65.30%> (ø)` | |
| [...nd/src/datasource/components/ImportModal/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvY29tcG9uZW50cy9JbXBvcnRNb2RhbC9pbmRleC50c3g=) | `65.30% <65.30%> (ø)` | |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `93.25% <85.71%> (-0.65%)` | :arrow_down: |
| [...uperset/datasets/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `92.20% <85.71%> (-0.65%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.53% <100.00%> (+0.06%)` | :arrow_up: |
| [superset/charts/commands/importers/dispatcher.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy9kaXNwYXRjaGVyLnB5) | `80.64% <100.00%> (+1.33%)` | :arrow_up: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| ... and [203 more](https://codecov.io/gh/apache/incubator-superset/pull/11956/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=footer). Last update [fbb458f...990ca8a](https://codecov.io/gh/apache/incubator-superset/pull/11956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org