You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/01/12 08:57:30 UTC
[GitHub] [incubator-kyuubi] ulysses-you opened a new pull request #1738: Unify kubernetes integration test
ulysses-you opened a new pull request #1738:
URL: https://github.com/apache/incubator-kyuubi/pull/1738
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
- Move kubernetes integration test into the new module `integration-test`
- remove the kubernetes profile since it is only used in test
### _How was this patch tested?_
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #1738: Unify kubernetes integration test
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #1738:
URL: https://github.com/apache/incubator-kyuubi/pull/1738#issuecomment-1011731265
also cc @yanghua @pan3793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1738: Unify kubernetes integration test
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1738:
URL: https://github.com/apache/incubator-kyuubi/pull/1738#issuecomment-1011648083
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1738](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a1d4805) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/a550ac705bc92c60322524acf1b36c4f981e3a6e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a550ac7) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
> :exclamation: Current head a1d4805 differs from pull request most recent head 1c490ac. Consider uploading reports for the commit 1c490ac to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1738 +/- ##
============================================
- Coverage 59.55% 59.53% -0.02%
+ Complexity 234 233 -1
============================================
Files 268 268
Lines 13314 13314
Branches 1692 1692
============================================
- Hits 7929 7927 -2
Misses 4708 4708
- Partials 677 679 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `92.50% <0.00%> (-2.50%)` | :arrow_down: |
| [...rg/apache/kyuubi/engine/trino/TrinoStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL1RyaW5vU3RhdGVtZW50LnNjYWxh) | `64.28% <0.00%> (-1.20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a550ac7...1c490ac](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1738: Unify kubernetes integration test
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1738:
URL: https://github.com/apache/incubator-kyuubi/pull/1738#discussion_r783646119
##########
File path: integration-tests/pom.xml
##########
@@ -35,4 +35,12 @@
<module>kyuubi-flink-it</module>
</modules>
+ <profiles>
+ <profile>
+ <id>kubernetes</id>
Review comment:
How about rename it to `it-kubernetes` or `it-k8s`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1738: Unify kubernetes integration test
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1738:
URL: https://github.com/apache/incubator-kyuubi/pull/1738#issuecomment-1011648083
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1738](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (387bf25) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/a550ac705bc92c60322524acf1b36c4f981e3a6e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a550ac7) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 387bf25 differs from pull request most recent head a1d4805. Consider uploading reports for the commit a1d4805 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1738 +/- ##
=========================================
Coverage 59.55% 59.55%
+ Complexity 234 233 -1
=========================================
Files 268 268
Lines 13314 13314
Branches 1692 1692
=========================================
Hits 7929 7929
Misses 4708 4708
Partials 677 677
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a550ac7...a1d4805](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1738: Unify kubernetes integration test
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1738:
URL: https://github.com/apache/incubator-kyuubi/pull/1738#issuecomment-1011648083
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1738](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c3f37ea) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/a550ac705bc92c60322524acf1b36c4f981e3a6e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a550ac7) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
> :exclamation: Current head c3f37ea differs from pull request most recent head 387bf25. Consider uploading reports for the commit 387bf25 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1738 +/- ##
=========================================
Coverage 59.55% 59.56%
- Complexity 234 235 +1
=========================================
Files 268 268
Lines 13314 13314
Branches 1692 1692
=========================================
+ Hits 7929 7930 +1
+ Misses 4708 4706 -2
- Partials 677 678 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...he/kyuubi/engine/spark/repl/KyuubiSparkILoop.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9yZXBsL0t5dXViaVNwYXJrSUxvb3Auc2NhbGE=) | `90.16% <0.00%> (-3.28%)` | :arrow_down: |
| [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `92.50% <0.00%> (-2.50%)` | :arrow_down: |
| [...rg/apache/kyuubi/engine/trino/TrinoStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL1RyaW5vU3RhdGVtZW50LnNjYWxh) | `70.23% <0.00%> (+4.76%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a550ac7...387bf25](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1738: Unify kubernetes integration test
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #1738:
URL: https://github.com/apache/incubator-kyuubi/pull/1738#discussion_r783653646
##########
File path: integration-tests/pom.xml
##########
@@ -35,4 +35,12 @@
<module>kyuubi-flink-it</module>
</modules>
+ <profiles>
+ <profile>
+ <id>kubernetes</id>
Review comment:
```suggestion
<id>kubernetes-deployment-it</id>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1738: Unify kubernetes integration test
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1738:
URL: https://github.com/apache/incubator-kyuubi/pull/1738#issuecomment-1011648083
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1738](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (090278e) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/a550ac705bc92c60322524acf1b36c4f981e3a6e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a550ac7) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 090278e differs from pull request most recent head 2582823. Consider uploading reports for the commit 2582823 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1738 +/- ##
=========================================
Coverage 59.55% 59.55%
+ Complexity 234 233 -1
=========================================
Files 268 268
Lines 13314 13315 +1
Branches 1692 1692
=========================================
+ Hits 7929 7930 +1
Misses 4708 4708
Partials 677 677
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rg/apache/kyuubi/engine/trino/TrinoStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL1RyaW5vU3RhdGVtZW50LnNjYWxh) | `65.88% <0.00%> (+0.40%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a550ac7...2582823](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1738: Unify kubernetes integration test
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #1738:
URL: https://github.com/apache/incubator-kyuubi/pull/1738#discussion_r782906902
##########
File path: integration-tests/kyuubi-kubernetes-it/pom.xml
##########
@@ -21,9 +21,9 @@
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<parent>
<groupId>org.apache.kyuubi</groupId>
- <artifactId>kyuubi-parent</artifactId>
+ <artifactId>integration-tests</artifactId>
<version>1.5.0-SNAPSHOT</version>
- <relativePath>../../pom.xml</relativePath>
+ <relativePath>../pom.xml</relativePath>
</parent>
Review comment:
how about we change all the test-only module's names to "KYUUBI TEST ....."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1738: Unify kubernetes integration test
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1738:
URL: https://github.com/apache/incubator-kyuubi/pull/1738#discussion_r783606941
##########
File path: integration-tests/pom.xml
##########
@@ -35,4 +35,12 @@
<module>kyuubi-flink-it</module>
</modules>
+ <profiles>
+ <profile>
+ <id>kubernetes</id>
Review comment:
I'm wondering if we can use a profile it to activate all integration tests moudles? The `kubernetes` is quite confusing to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1738: Unify kubernetes integration test
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #1738:
URL: https://github.com/apache/incubator-kyuubi/pull/1738#discussion_r783652270
##########
File path: integration-tests/kyuubi-flink-it/pom.xml
##########
@@ -28,7 +28,7 @@
<modelVersion>4.0.0</modelVersion>
<artifactId>kyuubi-flink-it_2.12</artifactId>
- <name>Kyuubi Project IT Flink SQL</name>
+ <name>Kyuubi Test Project Flink SQL</name>
Review comment:
```suggestion
<name>Kyuubi Test Flink SQL IT</name>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] cfmcgrady commented on a change in pull request #1738: Unify kubernetes integration test
Posted by GitBox <gi...@apache.org>.
cfmcgrady commented on a change in pull request #1738:
URL: https://github.com/apache/incubator-kyuubi/pull/1738#discussion_r782871934
##########
File path: .github/workflows/master.yml
##########
@@ -179,7 +179,6 @@ jobs:
run: >-
./build/mvn clean install -Dmaven.javadoc.skip=true -Drat.skip=true -Dscalastyle.skip=true -Dspotless.check.skip -V
-pl kubernetes/integration-tests -am
Review comment:
`-pl kubernetes/integration-tests -am` -> `-pl integration-tests/kyuubi-kubernetes-it -am`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #1738: Unify kubernetes integration test
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1738:
URL: https://github.com/apache/incubator-kyuubi/pull/1738#issuecomment-1011648083
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1738](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0683902) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/a550ac705bc92c60322524acf1b36c4f981e3a6e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a550ac7) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 0683902 differs from pull request most recent head 387bf25. Consider uploading reports for the commit 387bf25 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1738 +/- ##
============================================
- Coverage 59.55% 59.53% -0.02%
Complexity 234 234
============================================
Files 268 268
Lines 13314 13314
Branches 1692 1692
============================================
- Hits 7929 7927 -2
- Misses 4708 4709 +1
- Partials 677 678 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...he/kyuubi/engine/spark/repl/KyuubiSparkILoop.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9yZXBsL0t5dXViaVNwYXJrSUxvb3Auc2NhbGE=) | `90.16% <0.00%> (-3.28%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a550ac7...387bf25](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #1738: Unify kubernetes integration test
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #1738:
URL: https://github.com/apache/incubator-kyuubi/pull/1738#discussion_r783698956
##########
File path: integration-tests/pom.xml
##########
@@ -35,4 +35,12 @@
<module>kyuubi-flink-it</module>
</modules>
+ <profiles>
+ <profile>
+ <id>kubernetes</id>
Review comment:
how about `kubernetes-it` ? since the module names are `kyuubi-kubernetes-it` and `kyuubi-flink-it` , and personally I don't like the short name ..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #1738: Unify kubernetes integration test
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #1738:
URL: https://github.com/apache/incubator-kyuubi/pull/1738#issuecomment-1011953269
thanks, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1738: Unify kubernetes integration test
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1738:
URL: https://github.com/apache/incubator-kyuubi/pull/1738#issuecomment-1011648083
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1738](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c3f37ea) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/a550ac705bc92c60322524acf1b36c4f981e3a6e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a550ac7) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
> :exclamation: Current head c3f37ea differs from pull request most recent head a1d4805. Consider uploading reports for the commit a1d4805 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1738 +/- ##
=========================================
Coverage 59.55% 59.56%
- Complexity 234 235 +1
=========================================
Files 268 268
Lines 13314 13314
Branches 1692 1692
=========================================
+ Hits 7929 7930 +1
+ Misses 4708 4706 -2
- Partials 677 678 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...he/kyuubi/engine/spark/repl/KyuubiSparkILoop.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9yZXBsL0t5dXViaVNwYXJrSUxvb3Auc2NhbGE=) | `90.16% <0.00%> (-3.28%)` | :arrow_down: |
| [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `92.50% <0.00%> (-2.50%)` | :arrow_down: |
| [...rg/apache/kyuubi/engine/trino/TrinoStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL1RyaW5vU3RhdGVtZW50LnNjYWxh) | `70.23% <0.00%> (+4.76%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a550ac7...a1d4805](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1738: Unify kubernetes integration test
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #1738:
URL: https://github.com/apache/incubator-kyuubi/pull/1738#discussion_r783652813
##########
File path: integration-tests/kyuubi-kubernetes-it/pom.xml
##########
@@ -21,13 +21,13 @@
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<parent>
<groupId>org.apache.kyuubi</groupId>
- <artifactId>kyuubi-parent</artifactId>
+ <artifactId>integration-tests</artifactId>
<version>1.5.0-SNAPSHOT</version>
- <relativePath>../../pom.xml</relativePath>
+ <relativePath>../pom.xml</relativePath>
</parent>
<artifactId>kubernetes-integration-tests_2.12</artifactId>
- <name>Kyuubi Kubernetes Integration Tests</name>
+ <name>Kyuubi Test Kubernetes</name>
Review comment:
```suggestion
<name>Kyuubi Test Kubernetes Deployment IT</name>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yanghua commented on a change in pull request #1738: Unify kubernetes integration test
Posted by GitBox <gi...@apache.org>.
yanghua commented on a change in pull request #1738:
URL: https://github.com/apache/incubator-kyuubi/pull/1738#discussion_r783650547
##########
File path: integration-tests/pom.xml
##########
@@ -35,4 +35,12 @@
<module>kyuubi-flink-it</module>
</modules>
+ <profiles>
+ <profile>
+ <id>kubernetes</id>
Review comment:
> I'm wondering if we can use a profile it to activate all integration tests moudles? The `kubernetes` is quite confusing to me.
+1 about the concern of naming
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1738: Unify kubernetes integration test
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #1738:
URL: https://github.com/apache/incubator-kyuubi/pull/1738#discussion_r783653774
##########
File path: integration-tests/pom.xml
##########
@@ -35,4 +35,12 @@
<module>kyuubi-flink-it</module>
</modules>
+ <profiles>
+ <profile>
+ <id>kubernetes</id>
+ <modules>
+ <module>kyuubi-kubernetes-it</module>
Review comment:
```suggestion
<module>kyuubi-kubernetes-deployment-it</module>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1738: Unify kubernetes integration test
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1738:
URL: https://github.com/apache/incubator-kyuubi/pull/1738#issuecomment-1011648083
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1738](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a1d4805) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/a550ac705bc92c60322524acf1b36c4f981e3a6e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a550ac7) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
> :exclamation: Current head a1d4805 differs from pull request most recent head 090278e. Consider uploading reports for the commit 090278e to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1738 +/- ##
============================================
- Coverage 59.55% 59.53% -0.02%
+ Complexity 234 233 -1
============================================
Files 268 268
Lines 13314 13314
Branches 1692 1692
============================================
- Hits 7929 7927 -2
Misses 4708 4708
- Partials 677 679 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `92.50% <0.00%> (-2.50%)` | :arrow_down: |
| [...rg/apache/kyuubi/engine/trino/TrinoStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL1RyaW5vU3RhdGVtZW50LnNjYWxh) | `64.28% <0.00%> (-1.20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a550ac7...090278e](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #1738: Unify kubernetes integration test
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #1738:
URL: https://github.com/apache/incubator-kyuubi/pull/1738#discussion_r783620358
##########
File path: integration-tests/pom.xml
##########
@@ -35,4 +35,12 @@
<module>kyuubi-flink-it</module>
</modules>
+ <profiles>
+ <profile>
+ <id>kubernetes</id>
Review comment:
We need this, since the k8s test env is different from others that use minikube action to run the k8s-it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1738: Unify kubernetes integration test
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1738:
URL: https://github.com/apache/incubator-kyuubi/pull/1738#issuecomment-1011648083
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1738](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a1d4805) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/a550ac705bc92c60322524acf1b36c4f981e3a6e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a550ac7) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1738 +/- ##
============================================
- Coverage 59.55% 59.53% -0.02%
+ Complexity 234 233 -1
============================================
Files 268 268
Lines 13314 13314
Branches 1692 1692
============================================
- Hits 7929 7927 -2
Misses 4708 4708
- Partials 677 679 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `92.50% <0.00%> (-2.50%)` | :arrow_down: |
| [...rg/apache/kyuubi/engine/trino/TrinoStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL1RyaW5vU3RhdGVtZW50LnNjYWxh) | `64.28% <0.00%> (-1.20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a550ac7...a1d4805](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1738: Unify kubernetes integration test
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1738:
URL: https://github.com/apache/incubator-kyuubi/pull/1738#issuecomment-1011648083
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1738](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a1d4805) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/a550ac705bc92c60322524acf1b36c4f981e3a6e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a550ac7) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
> :exclamation: Current head a1d4805 differs from pull request most recent head 2582823. Consider uploading reports for the commit 2582823 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1738 +/- ##
============================================
- Coverage 59.55% 59.53% -0.02%
+ Complexity 234 233 -1
============================================
Files 268 268
Lines 13314 13314
Branches 1692 1692
============================================
- Hits 7929 7927 -2
Misses 4708 4708
- Partials 677 679 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `92.50% <0.00%> (-2.50%)` | :arrow_down: |
| [...rg/apache/kyuubi/engine/trino/TrinoStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL1RyaW5vU3RhdGVtZW50LnNjYWxh) | `64.28% <0.00%> (-1.20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a550ac7...2582823](https://codecov.io/gh/apache/incubator-kyuubi/pull/1738?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #1738: Unify kubernetes integration test
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #1738:
URL: https://github.com/apache/incubator-kyuubi/pull/1738#discussion_r783702328
##########
File path: integration-tests/pom.xml
##########
@@ -35,4 +35,12 @@
<module>kyuubi-flink-it</module>
</modules>
+ <profiles>
+ <profile>
+ <id>kubernetes</id>
Review comment:
ah I see the `kubernetes-deployment-it` of @yaooqinn , looks fine. It looks clear if we add spark/flink kubernetes it in future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you closed pull request #1738: Unify kubernetes integration test
Posted by GitBox <gi...@apache.org>.
ulysses-you closed pull request #1738:
URL: https://github.com/apache/incubator-kyuubi/pull/1738
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org