[jira] [Comment Edited] (IGNITE-3426) Compute Engine: job ID is generated in a non unique way

["Denis Magda (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-3426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15362391#comment-15362391 ] 

Denis Magda edited comment on IGNITE-3426 at 7/5/16 11:56 AM:
--------------------------------------------------------------

One liner fix. Job ID will be generated using this code 
{code}
IgniteUuid jobId = IgniteUuid.fromUuid(ctx.localNodeId());
{code}

Checking with TC.


was (Author: dmagda):
One liner fix. Job ID will be generated using this code {{            IgniteUuid jobId = IgniteUuid.fromUuid(ctx.localNodeId());
}}

Checking with TC.

> Compute Engine: job ID is generated in a non unique way
> -------------------------------------------------------
>
>                 Key: IGNITE-3426
>                 URL: https://issues.apache.org/jira/browse/IGNITE-3426
>             Project: Ignite
>          Issue Type: Improvement
>            Reporter: Denis Magda
>            Assignee: Denis Magda
>
> Presently seems like new job IDs are generated in a way that is not guaranteed to be unique.
> Specifically, job IDs are generated in: 
> {code}
> IgniteUuid jobId = IgniteUuid.fromUuid(node.id());
> org/apache/ignite/internal/processors/task/GridTaskWorker.java:564)
> {code}
> fromUuid generates the new job ID using UUID passed to it + an AtomicInteger (who is always incremented). Since the UUID passed to it is the *destination node* and not the local node, in environments where the job submission is relatively even, the generated job ID might not be unique.
> Think that the UUID used there is supposed to be the local node UUID.
> Otherwise this can be a reason of the following exception
> {noformat}
>  "Jobs map already contains mapping for key" 
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)