[jira] Updated: (TIKA-495) Metadata constructor is slow

["Jukka Zitting (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TIKA-495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting updated TIKA-495:
-------------------------------

    Attachment: TIKA-495.patch

In fact the format instances can also be static, we just need to protect them against concurrent access.

Since the date formats are typically only accessed a few times per each parsed document, using normal synchronization shouldn't cause any lock contention.

See the attached patch for a proposed solution.

> Metadata constructor is slow
> ----------------------------
>
>                 Key: TIKA-495
>                 URL: https://issues.apache.org/jira/browse/TIKA-495
>             Project: Tika
>          Issue Type: Bug
>          Components: metadata
>    Affects Versions: 0.8
>            Reporter: Radek
>         Attachments: TIKA-495.patch
>
>
> Metadata constructor initialises a bunch of SimpleTimeFormat objects. This is slow - they need to parse their configuration strings, system must be queried for timezone, and so on. In my simple test in which I create new Metadata object for each new document this accounts for approximately 25-30% of all time spent in Tika.
> As pointed out by Nick Burch, SimpleTimeFormat is not threadsafe, so they can't be static.
> Possible solutions include using org.apache.commons.lang.time.FastDateFormat instead (if its features are sufficient), or using thread local objects.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.