You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/08/09 17:01:58 UTC

[GitHub] [iceberg] RussellSpitzer commented on a diff in pull request #5478: Core: Remove confusing log from RemoveSnapshots

RussellSpitzer commented on code in PR #5478:
URL: https://github.com/apache/iceberg/pull/5478#discussion_r941587170


##########
core/src/main/java/org/apache/iceberg/RemoveSnapshots.java:
##########
@@ -321,8 +321,6 @@ public void commit() {
 
     if (cleanExpiredFiles) {
       cleanExpiredSnapshots();

Review Comment:
   I agree with @rdblue that we should just add the message right above here, "Local delete of expired files enabled. Cleaning up expired manifests and data files" or something like that



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org