You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2016/01/18 22:23:26 UTC
Review Request 42472: Multiple Disk: Checkpoint persistent volume
based on 'DiskInfo.Source'.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42472/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Michael Park.
Bugs: MESOS-4400
https://issues.apache.org/jira/browse/MESOS-4400
Repository: mesos
Description
-------
We now create persistent volume directories based on 'DiskInfo.Source'
if it is present.
Diffs
-----
src/slave/paths.hpp 6b9a65d2e8ed771041adce6f8c6fb0601422c6e8
src/slave/paths.cpp 9315b4cf0664a381d02f5cc72083eb22055daf4c
src/slave/slave.cpp bb501810d7bb1261ebbbdd147c49948e5a2f8665
src/tests/paths_tests.cpp 5e8495f2a19a4641e258f78911772b991d34d85a
Diff: https://reviews.apache.org/r/42472/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 42472: Multiple Disk: Checkpoint persistent volume
based on 'DiskInfo.Source'.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42472/#review115468
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Jan. 20, 2016, 7:12 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42472/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2016, 7:12 p.m.)
>
>
> Review request for mesos, Jie Yu and Michael Park.
>
>
> Bugs: MESOS-4400
> https://issues.apache.org/jira/browse/MESOS-4400
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We now create persistent volume directories based on 'DiskInfo.Source'
> if it is present.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp bd7fe03f8a8b07c6201db2f876f4f9cd7dc337cf
>
> Diff: https://reviews.apache.org/r/42472/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 42472: Multiple Disk: Checkpoint persistent volume
based on 'DiskInfo.Source'.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42472/
-----------------------------------------------------------
(Updated Jan. 23, 2016, 10:49 a.m.)
Review request for mesos, Jie Yu and Michael Park.
Bugs: MESOS-4400
https://issues.apache.org/jira/browse/MESOS-4400
Repository: mesos
Description
-------
We now create persistent volume directories based on 'DiskInfo.Source'
if it is present.
Diffs (updated)
-----
src/slave/paths.hpp 6b9a65d2e8ed771041adce6f8c6fb0601422c6e8
src/slave/paths.cpp 9315b4cf0664a381d02f5cc72083eb22055daf4c
src/slave/slave.cpp 1bd973a9cf4d8b922db9bd2f3df93bad7cc743bb
src/tests/paths_tests.cpp 5e8495f2a19a4641e258f78911772b991d34d85a
Diff: https://reviews.apache.org/r/42472/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 42472: Multiple Disk: Checkpoint persistent volume
based on 'DiskInfo.Source'.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42472/#review115867
-----------------------------------------------------------
Ship it!
src/slave/slave.cpp (lines 2256 - 2258)
<https://reviews.apache.org/r/42472/#comment176926>
This fits in one line?
- Jie Yu
On Jan. 22, 2016, 9:29 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42472/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2016, 9:29 a.m.)
>
>
> Review request for mesos, Jie Yu and Michael Park.
>
>
> Bugs: MESOS-4400
> https://issues.apache.org/jira/browse/MESOS-4400
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We now create persistent volume directories based on 'DiskInfo.Source'
> if it is present.
>
>
> Diffs
> -----
>
> src/slave/paths.hpp 6b9a65d2e8ed771041adce6f8c6fb0601422c6e8
> src/slave/paths.cpp 9315b4cf0664a381d02f5cc72083eb22055daf4c
> src/slave/slave.cpp e23c3295c8ebed580751a5aabaf26e1773c54859
> src/tests/paths_tests.cpp 5e8495f2a19a4641e258f78911772b991d34d85a
>
> Diff: https://reviews.apache.org/r/42472/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 42472: Multiple Disk: Checkpoint persistent volume
based on 'DiskInfo.Source'.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42472/
-----------------------------------------------------------
(Updated Jan. 22, 2016, 9:29 a.m.)
Review request for mesos, Jie Yu and Michael Park.
Changes
-------
Added `getPersistentVolumePath` overload to factor out common logic.
Bugs: MESOS-4400
https://issues.apache.org/jira/browse/MESOS-4400
Repository: mesos
Description
-------
We now create persistent volume directories based on 'DiskInfo.Source'
if it is present.
Diffs (updated)
-----
src/slave/paths.hpp 6b9a65d2e8ed771041adce6f8c6fb0601422c6e8
src/slave/paths.cpp 9315b4cf0664a381d02f5cc72083eb22055daf4c
src/slave/slave.cpp e23c3295c8ebed580751a5aabaf26e1773c54859
src/tests/paths_tests.cpp 5e8495f2a19a4641e258f78911772b991d34d85a
Diff: https://reviews.apache.org/r/42472/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 42472: Multiple Disk: Checkpoint persistent volume
based on 'DiskInfo.Source'.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42472/#review115681
-----------------------------------------------------------
src/slave/slave.cpp (lines 2260 - 2272)
<https://reviews.apache.org/r/42472/#comment176697>
I'm still not sure if we should create sub-directories in MOUNT disk or not. The reason is because we won't be able to create sub-directories in BLOCK/RAW disk, do we want to introduce a different behavior here?
I'd prefer to be consistent between BLOCK and MOUNT type.
- Jie Yu
On Jan. 21, 2016, 7:37 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42472/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2016, 7:37 a.m.)
>
>
> Review request for mesos, Jie Yu and Michael Park.
>
>
> Bugs: MESOS-4400
> https://issues.apache.org/jira/browse/MESOS-4400
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We now create persistent volume directories based on 'DiskInfo.Source'
> if it is present.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp bd7fe03f8a8b07c6201db2f876f4f9cd7dc337cf
>
> Diff: https://reviews.apache.org/r/42472/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 42472: Multiple Disk: Checkpoint persistent volume
based on 'DiskInfo.Source'.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42472/
-----------------------------------------------------------
(Updated Jan. 21, 2016, 7:37 a.m.)
Review request for mesos, Jie Yu and Michael Park.
Changes
-------
Support for `Mount` type.
Bugs: MESOS-4400
https://issues.apache.org/jira/browse/MESOS-4400
Repository: mesos
Description
-------
We now create persistent volume directories based on 'DiskInfo.Source'
if it is present.
Diffs (updated)
-----
src/slave/slave.cpp bd7fe03f8a8b07c6201db2f876f4f9cd7dc337cf
Diff: https://reviews.apache.org/r/42472/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 42472: Multiple Disk: Checkpoint persistent volume
based on 'DiskInfo.Source'.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42472/
-----------------------------------------------------------
(Updated Jan. 20, 2016, 7:12 p.m.)
Review request for mesos, Jie Yu and Michael Park.
Bugs: MESOS-4400
https://issues.apache.org/jira/browse/MESOS-4400
Repository: mesos
Description
-------
We now create persistent volume directories based on 'DiskInfo.Source'
if it is present.
Diffs (updated)
-----
src/slave/slave.cpp bd7fe03f8a8b07c6201db2f876f4f9cd7dc337cf
Diff: https://reviews.apache.org/r/42472/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 42472: Multiple Disk: Checkpoint persistent volume
based on 'DiskInfo.Source'.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42472/#review115267
-----------------------------------------------------------
src/slave/paths.hpp (lines 269 - 273)
<https://reviews.apache.org/r/42472/#comment176214>
I would prefer keep paths functions as simple as possible and rely on the caller to properly pass in the correct 'rootDir'.
- Jie Yu
On Jan. 18, 2016, 9:23 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42472/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2016, 9:23 p.m.)
>
>
> Review request for mesos, Jie Yu and Michael Park.
>
>
> Bugs: MESOS-4400
> https://issues.apache.org/jira/browse/MESOS-4400
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We now create persistent volume directories based on 'DiskInfo.Source'
> if it is present.
>
>
> Diffs
> -----
>
> src/slave/paths.hpp 6b9a65d2e8ed771041adce6f8c6fb0601422c6e8
> src/slave/paths.cpp 9315b4cf0664a381d02f5cc72083eb22055daf4c
> src/slave/slave.cpp bb501810d7bb1261ebbbdd147c49948e5a2f8665
> src/tests/paths_tests.cpp 5e8495f2a19a4641e258f78911772b991d34d85a
>
> Diff: https://reviews.apache.org/r/42472/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>