You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "github-actions[bot] (via GitHub)" <gi...@apache.org> on 2026/09/01 13:13:08 UTC

Re: [PR] chore: convert `PartialHashAggregateStream` and `FinalHashAggregateStream` to async generators and cleanup [datafusion]

github-actions[bot] commented on PR #24017:
URL: https://github.com/apache/datafusion/pull/24017#issuecomment-5494486747

   <!-- semver-check-comment -->
   Thank you for opening this pull request!
   
   Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch).
   
   <details>
   <summary>Details</summary>
   
   ```
        Cloning apache/main
       Building datafusion-physical-plan v55.0.0 (current)
          Built [  47.461s] (current)
        Parsing datafusion-physical-plan v55.0.0 (current)
         Parsed [   0.152s] (current)
       Building datafusion-physical-plan v55.0.0 (baseline)
          Built [  40.893s] (baseline)
        Parsing datafusion-physical-plan v55.0.0 (baseline)
         Parsed [   0.162s] (baseline)
       Checking datafusion-physical-plan v55.0.0 -> v55.0.0 (no change; assume patch)
        Checked [   0.718s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip
   
   --- failure trait_method_missing: pub trait method removed or renamed ---
   
   Description:
   A trait method is no longer callable, and may have been renamed or removed entirely.
           ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-item-signature
          impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/trait_method_missing.ron
   
   Failed in:
     method values_preserving of trait GroupValues, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/db4e7abda50a83c18e0611c57f3e9fad08532d46/datafusion/physical-plan/src/aggregates/group_values/mod.rs:127
     method supports_values_preserving of trait GroupValues, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/db4e7abda50a83c18e0611c57f3e9fad08532d46/datafusion/physical-plan/src/aggregates/group_values/mod.rs:135
     method values_preserving of trait GroupColumn, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/db4e7abda50a83c18e0611c57f3e9fad08532d46/datafusion/physical-plan/src/aggregates/group_values/multi_group_by/mod.rs:114
   
        Summary semver requires new major version: 1 major and 0 minor checks failed
       Finished [  90.844s] datafusion-physical-plan
   ```
   
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org