You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/02/11 17:30:47 UTC
[GitHub] [lucene-solr] donnerpeter opened a new pull request #2354: LUCENE-9765: Hunspell: rename SpellChecker to Hunspell, fix test name…
donnerpeter opened a new pull request #2354:
URL: https://github.com/apache/lucene-solr/pull/2354
…, update javadoc and CHANGES.txt
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Lucene or Solr:
* https://issues.apache.org/jira/projects/LUCENE
* https://issues.apache.org/jira/projects/SOLR
You will need to create an account in Jira in order to create an issue.
The title of the PR should reference the Jira issue number in the form:
* LUCENE-####: <short description of problem or changes>
* SOLR-####: <short description of problem or changes>
LUCENE and SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
The class names are imperfect and the docs are outdated
# Solution
Fix that
# Tests
No behavior change.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `master` branch.
- [x] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2354: LUCENE-9765: Hunspell: rename SpellChecker to Hunspell, fix test name…
Posted by GitBox <gi...@apache.org>.
donnerpeter commented on a change in pull request #2354:
URL: https://github.com/apache/lucene-solr/pull/2354#discussion_r575345376
##########
File path: lucene/CHANGES.txt
##########
@@ -89,8 +89,8 @@ API Changes
Improvements
-* LUCENE-9687: Hunspell support improvements: add SpellChecker API, support default encoding and
- BREAK/FORBIDDENWORD/COMPOUNDRULE affix rules, improve stemming of all-caps words (Peter Gromov)
+* LUCENE-9687: Hunspell support improvements: add API for spell-checking and suggestions, support compound words,
+ fix various behavior differences between Java and C++ implementations, improve performance (Peter Gromov, Dawid Weiss)
Review comment:
I thought "via" is for pure review activity, but you've made meaningful changes yourself which I didn't even plan. Feel free to change to "via" if you like :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dweiss commented on a change in pull request #2354: LUCENE-9765: Hunspell: rename SpellChecker to Hunspell, fix test name…
Posted by GitBox <gi...@apache.org>.
dweiss commented on a change in pull request #2354:
URL: https://github.com/apache/lucene-solr/pull/2354#discussion_r575313858
##########
File path: lucene/CHANGES.txt
##########
@@ -89,8 +89,8 @@ API Changes
Improvements
-* LUCENE-9687: Hunspell support improvements: add SpellChecker API, support default encoding and
- BREAK/FORBIDDENWORD/COMPOUNDRULE affix rules, improve stemming of all-caps words (Peter Gromov)
+* LUCENE-9687: Hunspell support improvements: add API for spell-checking and suggestions, support compound words,
+ fix various behavior differences between Java and C++ implementations, improve performance (Peter Gromov, Dawid Weiss)
Review comment:
Doesn't matter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2354: LUCENE-9765: Hunspell: rename SpellChecker to Hunspell, fix test name…
Posted by GitBox <gi...@apache.org>.
donnerpeter commented on a change in pull request #2354:
URL: https://github.com/apache/lucene-solr/pull/2354#discussion_r575288848
##########
File path: lucene/CHANGES.txt
##########
@@ -89,8 +89,8 @@ API Changes
Improvements
-* LUCENE-9687: Hunspell support improvements: add SpellChecker API, support default encoding and
- BREAK/FORBIDDENWORD/COMPOUNDRULE affix rules, improve stemming of all-caps words (Peter Gromov)
+* LUCENE-9687: Hunspell support improvements: add API for spell-checking and suggestions, support compound words,
+ fix various behavior differences between Java and C++ implementations, improve performance (Peter Gromov, Dawid Weiss)
Review comment:
I think you do, as you've dedicated quite a lot of your time to my and our own PRs. We could also change that to "mostly Peter Gromov, but also Dawid Weiss" if you like :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dweiss merged pull request #2354: LUCENE-9765: Hunspell: rename SpellChecker to Hunspell, fix test name…
Posted by GitBox <gi...@apache.org>.
dweiss merged pull request #2354:
URL: https://github.com/apache/lucene-solr/pull/2354
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dweiss commented on a change in pull request #2354: LUCENE-9765: Hunspell: rename SpellChecker to Hunspell, fix test name…
Posted by GitBox <gi...@apache.org>.
dweiss commented on a change in pull request #2354:
URL: https://github.com/apache/lucene-solr/pull/2354#discussion_r575274004
##########
File path: lucene/CHANGES.txt
##########
@@ -89,8 +89,8 @@ API Changes
Improvements
-* LUCENE-9687: Hunspell support improvements: add SpellChecker API, support default encoding and
- BREAK/FORBIDDENWORD/COMPOUNDRULE affix rules, improve stemming of all-caps words (Peter Gromov)
+* LUCENE-9687: Hunspell support improvements: add API for spell-checking and suggestions, support compound words,
+ fix various behavior differences between Java and C++ implementations, improve performance (Peter Gromov, Dawid Weiss)
Review comment:
I don't think I deserve to be in the changes entry. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dweiss commented on a change in pull request #2354: LUCENE-9765: Hunspell: rename SpellChecker to Hunspell, fix test name…
Posted by GitBox <gi...@apache.org>.
dweiss commented on a change in pull request #2354:
URL: https://github.com/apache/lucene-solr/pull/2354#discussion_r575313672
##########
File path: lucene/CHANGES.txt
##########
@@ -89,8 +89,8 @@ API Changes
Improvements
-* LUCENE-9687: Hunspell support improvements: add SpellChecker API, support default encoding and
- BREAK/FORBIDDENWORD/COMPOUNDRULE affix rules, improve stemming of all-caps words (Peter Gromov)
+* LUCENE-9687: Hunspell support improvements: add API for spell-checking and suggestions, support compound words,
+ fix various behavior differences between Java and C++ implementations, improve performance (Peter Gromov, Dawid Weiss)
Review comment:
There's actually a convention for this: "Peter Gromov via Dawid Weiss".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org