[GitHub] [airflow] melugoyal commented on a diff in pull request #28511: allow a configurable prefix for pod names created by kubernetes executor

[GitBox <gi...@apache.org>]

melugoyal commented on code in PR #28511:
URL: https://github.com/apache/airflow/pull/28511#discussion_r1053848453


##########
airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py:
##########
@@ -91,6 +91,7 @@ def _add_pod_suffix(*, pod_name, rand_len=8, max_len=253):
 def _create_pod_id(
     dag_id: str | None = None,
     task_id: str | None = None,
+    prefix: str | None = None,

Review Comment:
   had to copy the changes to this file since we run the same set of unit tests against both modules: https://github.com/apache/airflow/blob/b213f4fd2627bb2a2a4c96fe2845471db430aa5d/tests/kubernetes/test_kubernetes_helper_functions.py#L35



##########
airflow/config_templates/config.yml:
##########
@@ -2544,6 +2544,13 @@
       type: boolean
       example: ~
       default: "True"
+    - name: worker_pods_name_prefix
+      description: |
+        Prefix to be added to the beginning of worker pods' names
+      version_added: 2.6.0

Review Comment:
   i'm unsure if this is correct. cc @jedcunningham @dstandish 



##########
airflow/kubernetes/kube_config.py:
##########
@@ -26,7 +26,6 @@ class KubeConfig:
 
     core_section = "core"
     kubernetes_section = "kubernetes_executor"
-    logging_section = "logging"

Review Comment:
   this was unused



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org