[GitHub] kasjer commented on a change in pull request #1548: sys/log: Add pretty printing for CBOR log entries

[GitBox <gi...@apache.org>]

kasjer commented on a change in pull request #1548: sys/log: Add pretty printing for CBOR log entries
URL: https://github.com/apache/mynewt-core/pull/1548#discussion_r238962819
 
 

 ##########
 File path: sys/log/full/src/log_shell.c
 ##########
 @@ -99,6 +242,15 @@ shell_log_dump_all_cmd(int argc, char **argv)
             continue;
         }
 
+        if (list_only) {
+            console_printf("%s\n", log->l_name);
+            continue;
+        }
+
+        if ((argc > 1) &&  strcmp(log->l_name, argv[1])) {
 
 Review comment:
   extra space after &&

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services