You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/01/20 00:21:25 UTC
[GitHub] [geode] karensmolermiller opened a new pull request #5924: GEODE-8850: Revise security-client-auth-init property defn
karensmolermiller opened a new pull request #5924:
URL: https://github.com/apache/geode/pull/5924
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] karensmolermiller commented on pull request #5924: GEODE-8850: Revise security-client-auth-init property defn
Posted by GitBox <gi...@apache.org>.
karensmolermiller commented on pull request #5924:
URL: https://github.com/apache/geode/pull/5924#issuecomment-767001590
Reviewers, please re-review. This JIRA has been expanded to correct the docs surrounding authentication. I also found another section that had partial, but incomplete duplicate information. I have revised that other section to remove the repeated (but incomplete/incorrect) info, and instead have links to where the info is. My goal is that the docs have a single place where the info resides; a single location is far easier to maintain.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] karensmolermiller merged pull request #5924: GEODE-8850: Revise security-client-auth-init property defn
Posted by GitBox <gi...@apache.org>.
karensmolermiller merged pull request #5924:
URL: https://github.com/apache/geode/pull/5924
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] karensmolermiller commented on pull request #5924: GEODE-8850: Revise security-client-auth-init property defn
Posted by GitBox <gi...@apache.org>.
karensmolermiller commented on pull request #5924:
URL: https://github.com/apache/geode/pull/5924#issuecomment-767001590
Reviewers, please re-review. This JIRA has been expanded to correct the docs surrounding authentication. I also found another section that had partial, but incomplete duplicate information. I have revised that other section to remove the repeated (but incomplete/incorrect) info, and instead have links to where the info is. My goal is that the docs have a single place where the info resides; a single location is far easier to maintain.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #5924: GEODE-8850: Revise security-client-auth-init property defn
Posted by GitBox <gi...@apache.org>.
jdeppe-pivotal commented on a change in pull request #5924:
URL: https://github.com/apache/geode/pull/5924#discussion_r561011462
##########
File path: geode-docs/reference/topics/gemfire_properties.html.md.erb
##########
@@ -568,7 +568,7 @@ Any security-related (properties that begin with <code class="ph codeph">securit
</tr>
<tr>
<td>security-client-auth-init</td>
-<td>Used for authentication. Static creation method returning an <code class="ph codeph">AuthInitialize</code> object, which obtains credentials for peers in a cluster. The obtained credentials should be acceptable to the <code class="ph codeph">Authenticator</code> specified through the security-peer-authenticator property on the peers.</td>
+<td>Used for authentication. Location of the implementation with the static creation method that returns an <code class="ph codeph">AuthInitialize</code> object. The method obtains credentials for clients to a cluster. The obtained credentials should be acceptable to the <code class="ph codeph">SecurityManager</code> specified through the security-manager property on the peers.</td>
Review comment:
How about: `A reference to a static creation method that...` and then... `The method returns credentials for clients to authenticate and connect to a cluster.`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org