[GitHub] [spark] LuciferYang commented on a diff in pull request #43138: [SPARK-44223][CORE] Remove LevelDB support

["LuciferYang (via GitHub)" <gi...@apache.org>]

LuciferYang commented on code in PR #43138:
URL: https://github.com/apache/spark/pull/43138#discussion_r1338002812


##########
core/src/main/scala/org/apache/spark/internal/config/package.scala:
##########
@@ -726,12 +726,12 @@ package object config {
   private[spark] val SHUFFLE_SERVICE_DB_BACKEND =
     ConfigBuilder(Constants.SHUFFLE_SERVICE_DB_BACKEND)
       .doc("Specifies a disk-based store used in shuffle service local db. " +
-        "LEVELDB or ROCKSDB.")
+        "Only supported ROCKSDB at now.")
       .version("3.4.0")
       .stringConf
       .transform(_.toUpperCase(Locale.ROOT))
       .checkValues(DBBackend.values.map(_.toString).toSet)
-      .createWithDefault(DBBackend.LEVELDB.name)
+      .createWithDefault(DBBackend.ROCKSDB.name)

Review Comment:
   I'm not against this change, but I'm quite conflicted about it.
   
   For shuffle db, we didn't make `ROCKSDB` the default in Spark 3.5.0, so I'm not sure if it's appropriate to just remove it in Spark 4.0. This is why I haven't submitted a pr to address this issue.
   
   Let's wait for other people's opinions.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org