You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "hujun260 (via GitHub)" <gi...@apache.org> on 2024/10/23 06:50:57 UTC
[PR] arm64: fix fvp smp faild to boot [nuttx]
hujun260 opened a new pull request, #14476:
URL: https://github.com/apache/nuttx/pull/14476
## Summary
fix fvp smp faild to boot
we should give a busy wait addr
This commit fixes the regression from https://github.com/apache/nuttx/pull/13640
## Impact
arm64 fvp smp
## Testing
fvp-armv8r:nsh_smp ostest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arm64: fix fvp smp faild to boot [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #14476:
URL: https://github.com/apache/nuttx/pull/14476
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arm64: fix fvp smp faild to boot [nuttx]
Posted by "nuttxpr (via GitHub)" <gi...@apache.org>.
nuttxpr commented on PR #14476:
URL: https://github.com/apache/nuttx/pull/14476#issuecomment-2432082019
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
This pull request appears to meet the basic NuttX requirements. However, it could be improved with some clarifications:
**Summary:**
* **More Detail:** Briefly explain why the busy wait address is needed. What was the specific issue causing the FVP SMP boot failure?
* **Functional Change:** Be specific about which part of the code is modified. For example, "Added a busy wait loop in the ARM64 FVP platform initialization code".
* **How it Works:** Explain at a high level how providing the busy wait address resolves the boot issue.
**Impact:**
* **Hardware:** While you mention "arm64 fvp smp", be explicit about the specific architectures and boards affected.
* **Documentation:** If this fix impacts user understanding (e.g., if the busy wait address is configurable), mention if a documentation update is needed or provided.
**Testing:**
* **Build Host:** Specify the operating system, CPU architecture, and compiler used for testing.
* **Target(s):** Provide the full architecture and board configuration used (e.g., "arm64, FVP:nsh_smp").
* **Logs:** While "ostest" is mentioned, consider including relevant snippets of the logs that demonstrate the issue before the fix and the successful outcome after the fix.
By adding these details, you'll make it easier for reviewers to understand and evaluate your pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arm64: fix fvp smp faild to boot [nuttx]
Posted by "XuNeo (via GitHub)" <gi...@apache.org>.
XuNeo commented on code in PR #14476:
URL: https://github.com/apache/nuttx/pull/14476#discussion_r1812813878
##########
boards/arm64/fvp-v8r/fvp-armv8r/configs/nsh_smp/defconfig:
##########
@@ -14,6 +14,8 @@ CONFIG_ARCH_CHIP_FVP_ARMV8R=y
CONFIG_ARCH_CHIP_FVP_R82=y
CONFIG_ARCH_EARLY_PRINT=y
CONFIG_ARCH_INTERRUPTSTACK=4096
+CONFIG_ARM64_SMP_BUSY_WAIT=y
Review Comment:
Any idea why FVP needs busy wait?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arm64: fix fvp smp faild to boot [nuttx]
Posted by "hujun260 (via GitHub)" <gi...@apache.org>.
hujun260 commented on code in PR #14476:
URL: https://github.com/apache/nuttx/pull/14476#discussion_r1814072929
##########
boards/arm64/fvp-v8r/fvp-armv8r/configs/nsh_smp/defconfig:
##########
@@ -14,6 +14,8 @@ CONFIG_ARCH_CHIP_FVP_ARMV8R=y
CONFIG_ARCH_CHIP_FVP_R82=y
CONFIG_ARCH_EARLY_PRINT=y
CONFIG_ARCH_INTERRUPTSTACK=4096
+CONFIG_ARM64_SMP_BUSY_WAIT=y
Review Comment:
The FVP SMP startup has always been using the busywait strategy. Before my modification, it serially waited for a fixed global variable (cpu_ready_flag). After I changed it to parallel startup for CPUs (1 to n), I added a wait address for more generality. However, at that time, the FVP SMP was not configured accordingly, leading to this error.
Additionally, let me mention that the arm64 QEMU SMP startup uses the PSCI method, rather than busywait.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arm64: fix fvp smp faild to boot [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #14476:
URL: https://github.com/apache/nuttx/pull/14476#discussion_r1812040914
##########
boards/arm64/fvp-v8r/fvp-armv8r/configs/nsh_smp/defconfig:
##########
@@ -14,6 +14,8 @@ CONFIG_ARCH_CHIP_FVP_ARMV8R=y
CONFIG_ARCH_CHIP_FVP_R82=y
CONFIG_ARCH_EARLY_PRINT=y
CONFIG_ARCH_INTERRUPTSTACK=4096
+CONFIG_ARM64_SMP_BUSY_WAIT=y
+CONFIG_ARM64_SMP_BUSY_WAIT_FLAG_ADDR=393216
Review Comment:
let's use hex number by changing CONFIG_ARM64_SMP_BUSY_WAIT_FLAG_ADDR type to hex
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arm64: fix fvp smp faild to boot [nuttx]
Posted by "anchao (via GitHub)" <gi...@apache.org>.
anchao commented on code in PR #14476:
URL: https://github.com/apache/nuttx/pull/14476#discussion_r1812676236
##########
boards/arm64/fvp-v8r/fvp-armv8r/scripts/dramboot.ld:
##########
@@ -93,6 +93,7 @@ SECTIONS
} :text
_edata = .; /* End+1 of .data */
+ . = 0x60004; /* CONFIG_ARM64_SMP_BUSY_WAIT_FLAG_ADDR + 4 */
Review Comment:
```suggestion
#ifdef CONFIG_SMP
. = CONFIG_ARM64_SMP_BUSY_WAIT_FLAG_ADDR + 4;
#endif
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org