You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by "guangxian.liao (JIRA)" <ji...@apache.org> on 2017/12/27 07:59:00 UTC

[jira] [Updated] (KAFKA-6405) Fix incorrect comment in MetadataUpdater

     [ https://issues.apache.org/jira/browse/KAFKA-6405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

guangxian.liao updated KAFKA-6405:
----------------------------------
    Description: 
The comment for 'handleDisconnection' says it can return true or false, but the return type is void.

{code:java}
/**
     * If `request` is a metadata request, handles it and return `true`. Otherwise, returns `false`.
     *
     * This provides a mechanism for the `MetadataUpdater` implementation to use the NetworkClient instance for its own
     * requests with special handling for disconnections of such requests.
     * @param destination
     */
    void handleDisconnection(String destination);
{code}



  was:
The comment for 'handleDisconnection' says it can return true or false, but the return type is void.
{quote}
/**
     * If `request` is a metadata request, handles it and return `true`. Otherwise, returns `false`.
     *
     * This provides a mechanism for the `MetadataUpdater` implementation to use the NetworkClient instance for its own
     * requests with special handling for disconnections of such requests.
     * @param destination
     */
    void handleDisconnection(String destination);
{quote}


> Fix incorrect comment in MetadataUpdater
> ----------------------------------------
>
>                 Key: KAFKA-6405
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6405
>             Project: Kafka
>          Issue Type: Improvement
>          Components: clients
>    Affects Versions: 1.0.0
>            Reporter: guangxian.liao
>            Priority: Trivial
>
> The comment for 'handleDisconnection' says it can return true or false, but the return type is void.
> {code:java}
> /**
>      * If `request` is a metadata request, handles it and return `true`. Otherwise, returns `false`.
>      *
>      * This provides a mechanism for the `MetadataUpdater` implementation to use the NetworkClient instance for its own
>      * requests with special handling for disconnections of such requests.
>      * @param destination
>      */
>     void handleDisconnection(String destination);
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)