You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/01/03 04:24:54 UTC

[GitHub] zhaijack opened a new pull request #1023: Refine broker starter command

zhaijack opened a new pull request #1023: Refine broker starter command
URL: https://github.com/apache/incubator-pulsar/pull/1023
 
 
   ### Motivation
   
   in PR #961, @merlimat suggest that:
   ```
   I actually don't like a lot a the PulsarBrokerStarter $DEFAULT_BROKER_CONF already. but I'd prefer to also have an option for passing/changing the $DEFAULT_BROKER_CONF, like --broker-conf $DEFAULT_BROKER_CONF or defaulting to ./conf/broker.conf if not specified. Same could be done for bookkeeper.conf argument.
   ```
   
   ### Modifications
   - change `PulsarBrokerStarter` by adding option "--broker-conf" for this command;
   - add option `enableRunBookieTogether` into `broker.conf`
   
   ### Result
   Most of the case, if use  `bin/pulsar`, nothing will change; 
   while using org.apache.pulsar.PulsarBrokerStarter directly, need to specify config file for broker, or put config file under `pwd/conf/broker.conf`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services