You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by GitBox <gi...@apache.org> on 2020/10/08 14:00:26 UTC
[GitHub] [jmeter] FackelAB opened a new pull request #629: Fix to Bug64776 - Add the possibility to add SecurityProviders
FackelAB opened a new pull request #629:
URL: https://github.com/apache/jmeter/pull/629
## Description
<!--- Provide a general summary of your changes in the Title above -->
<!--- Describe your changes in detail here -->
## Motivation and Context
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
## How Has This Been Tested?
<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, tests ran to see how -->
<!--- your change affects other areas of the code, etc. -->
## Screenshots (if appropriate):
## Types of changes
<!--- What types of changes does your code introduce? Delete as appropriate -->
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
## Checklist:
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
- [ ] My code follows the [code style][style-guide] of this project.
- [ ] I have updated the documentation accordingly.
[style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] pmouawad merged pull request #629: Fix to Bug64776 - Add the possibility to add SecurityProviders
Posted by GitBox <gi...@apache.org>.
pmouawad merged pull request #629:
URL: https://github.com/apache/jmeter/pull/629
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] codecov-io commented on pull request #629: Fix to Bug64776 - Add the possibility to add SecurityProviders
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #629:
URL: https://github.com/apache/jmeter/pull/629#issuecomment-705644912
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/629?src=pr&el=h1) Report
> Merging [#629](https://codecov.io/gh/apache/jmeter/pull/629?src=pr&el=desc) into [master](https://codecov.io/gh/apache/jmeter/commit/fc334b0426b48a1ee86015a1fba52d274c479f54?el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `93.75%`.
[](https://codecov.io/gh/apache/jmeter/pull/629?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #629 +/- ##
============================================
+ Coverage 55.26% 55.28% +0.02%
- Complexity 10078 10084 +6
============================================
Files 1038 1038
Lines 63853 63883 +30
Branches 7232 7235 +3
============================================
+ Hits 35289 35319 +30
+ Misses 26064 26063 -1
- Partials 2500 2501 +1
```
| [Impacted Files](https://codecov.io/gh/apache/jmeter/pull/629?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...org/apache/jmeter/util/SecurityProviderLoader.java](https://codecov.io/gh/apache/jmeter/pull/629/diff?src=pr&el=tree#diff-c3JjL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2ptZXRlci91dGlsL1NlY3VyaXR5UHJvdmlkZXJMb2FkZXIuamF2YQ==) | `93.54% <93.54%> (ø)` | `7.00 <7.00> (?)` | |
| [...c/core/src/main/java/org/apache/jmeter/JMeter.java](https://codecov.io/gh/apache/jmeter/pull/629/diff?src=pr&el=tree#diff-c3JjL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2ptZXRlci9KTWV0ZXIuamF2YQ==) | `39.97% <100.00%> (+0.07%)` | `45.00 <0.00> (ø)` | |
| [...n/java/org/apache/jmeter/reporters/Summariser.java](https://codecov.io/gh/apache/jmeter/pull/629/diff?src=pr&el=tree#diff-c3JjL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2ptZXRlci9yZXBvcnRlcnMvU3VtbWFyaXNlci5qYXZh) | `84.73% <0.00%> (-0.77%)` | `17.00% <0.00%> (-1.00%)` | |
| [.../version/org/apache/jmeter/util/JMeterVersion.java](https://codecov.io/gh/apache/jmeter/pull/629/diff?src=pr&el=tree#diff-c3JjL2NvcmUvc3JjL21haW4vdmVyc2lvbi9vcmcvYXBhY2hlL2ptZXRlci91dGlsL0pNZXRlclZlcnNpb24uamF2YQ==) | | | |
| [...a/org/apache/jmeter/timers/PoissonRandomTimer.java](https://codecov.io/gh/apache/jmeter/pull/629/diff?src=pr&el=tree#diff-c3JjL2NvbXBvbmVudHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2ptZXRlci90aW1lcnMvUG9pc3NvblJhbmRvbVRpbWVyLmphdmE=) | `78.37% <0.00%> (+5.40%)` | `10.00% <0.00%> (+1.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/jmeter/pull/629?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/jmeter/pull/629?src=pr&el=footer). Last update [fc334b0...0cfa2bc](https://codecov.io/gh/apache/jmeter/pull/629?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] codecov-io commented on pull request #629: Fix to Bug64776 - Add the possibility to add SecurityProviders
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #629:
URL: https://github.com/apache/jmeter/pull/629#issuecomment-705644912
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/629?src=pr&el=h1) Report
> Merging [#629](https://codecov.io/gh/apache/jmeter/pull/629?src=pr&el=desc) into [master](https://codecov.io/gh/apache/jmeter/commit/fc334b0426b48a1ee86015a1fba52d274c479f54?el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `93.75%`.
[](https://codecov.io/gh/apache/jmeter/pull/629?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #629 +/- ##
============================================
+ Coverage 55.26% 55.28% +0.02%
- Complexity 10078 10084 +6
============================================
Files 1038 1038
Lines 63853 63883 +30
Branches 7232 7235 +3
============================================
+ Hits 35289 35319 +30
+ Misses 26064 26063 -1
- Partials 2500 2501 +1
```
| [Impacted Files](https://codecov.io/gh/apache/jmeter/pull/629?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...org/apache/jmeter/util/SecurityProviderLoader.java](https://codecov.io/gh/apache/jmeter/pull/629/diff?src=pr&el=tree#diff-c3JjL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2ptZXRlci91dGlsL1NlY3VyaXR5UHJvdmlkZXJMb2FkZXIuamF2YQ==) | `93.54% <93.54%> (ø)` | `7.00 <7.00> (?)` | |
| [...c/core/src/main/java/org/apache/jmeter/JMeter.java](https://codecov.io/gh/apache/jmeter/pull/629/diff?src=pr&el=tree#diff-c3JjL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2ptZXRlci9KTWV0ZXIuamF2YQ==) | `39.97% <100.00%> (+0.07%)` | `45.00 <0.00> (ø)` | |
| [...n/java/org/apache/jmeter/reporters/Summariser.java](https://codecov.io/gh/apache/jmeter/pull/629/diff?src=pr&el=tree#diff-c3JjL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2ptZXRlci9yZXBvcnRlcnMvU3VtbWFyaXNlci5qYXZh) | `84.73% <0.00%> (-0.77%)` | `17.00% <0.00%> (-1.00%)` | |
| [.../version/org/apache/jmeter/util/JMeterVersion.java](https://codecov.io/gh/apache/jmeter/pull/629/diff?src=pr&el=tree#diff-c3JjL2NvcmUvc3JjL21haW4vdmVyc2lvbi9vcmcvYXBhY2hlL2ptZXRlci91dGlsL0pNZXRlclZlcnNpb24uamF2YQ==) | | | |
| [...a/org/apache/jmeter/timers/PoissonRandomTimer.java](https://codecov.io/gh/apache/jmeter/pull/629/diff?src=pr&el=tree#diff-c3JjL2NvbXBvbmVudHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2ptZXRlci90aW1lcnMvUG9pc3NvblJhbmRvbVRpbWVyLmphdmE=) | `78.37% <0.00%> (+5.40%)` | `10.00% <0.00%> (+1.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/jmeter/pull/629?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/jmeter/pull/629?src=pr&el=footer). Last update [fc334b0...0cfa2bc](https://codecov.io/gh/apache/jmeter/pull/629?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org