You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/10/24 06:03:28 UTC

[GitHub] [skywalking-python] westarest opened a new pull request, #245: Greenlet

westarest opened a new pull request, #245:
URL: https://github.com/apache/skywalking-python/pull/245

   <!-- Uncomment the following checklist WHEN AND ONLY WHEN you're adding a new plugin -->
   <!--
   - [ ] Add a test case for the new plugin
   - [ ] Add a CHANGELOG entry for the new plugin
   - [ ] Add a component id in [the main repo](https://github.com/apache/skywalking/blob/master/oap-server/server-starter/src/main/resources/component-libraries.yml)
   - [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-booster-ui/tree/main/src/assets/img/technologies)
   - [ ] Rebuild the `requirements.txt` by running `tools/env/build_requirements_(linux|windows).sh`
   - [ ] Rebuild the `Plugins.md` documentation by running `make doc-gen`
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-python] westarest commented on pull request #245: Greenlet

Posted by GitBox <gi...@apache.org>.

westarest commented on PR #245:
URL: https://github.com/apache/skywalking-python/pull/245#issuecomment-1288722241

   sorry ,this a draft, I only want to PR to my own Project for more test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-python] westarest closed pull request #245: Greenlet

Posted by GitBox <gi...@apache.org>.

westarest closed pull request #245: Greenlet
URL: https://github.com/apache/skywalking-python/pull/245


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-python] sonatype-lift[bot] commented on a diff in pull request #245: Greenlet

Posted by GitBox <gi...@apache.org>.

sonatype-lift[bot] commented on code in PR #245:
URL: https://github.com/apache/skywalking-python/pull/245#discussion_r1002907011


##########
gunicorn.conf.py:
##########
@@ -0,0 +1,29 @@
+#################################################
+# Gunicorn config for Flask
+#################################################
+
+from gevent import monkey
+monkey.patch_all()
+
+bind = '0.0.0.0:5000'
+
+# configure number of gunicorn workers
+# import multiprocessing
+workers = 1
+
+worker_class = 'gevent'
+
+# dont daemonize; running inside docker
+daemon = False
+timeout = 60
+keepalive = 70
+pidfile = '/tmp/gunicorn.pid'

Review Comment:
   *hardcoded_tmp_directory:*  Probable insecure usage of temp file/directory.
   
   ---
   
   <details><summary><b>ℹ️ Learn about @sonatype-lift commands</b></summary>
   
   You can reply with the following commands. For example, reply with ***@sonatype-lift ignoreall*** to leave out all findings.
   | **Command** | **Usage** |
   | ------------- | ------------- |
   | `@sonatype-lift ignore` | Leave out the above finding from this PR |
   | `@sonatype-lift ignoreall` | Leave out all the existing findings from this PR |
   | `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
   
   **Note:** When talking to LiftBot, you need to **refresh** the page to see its response.
   <sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) to add LiftBot to another repo.</sub></details>
   
   
   
   ---
   
   Was this a good recommendation?
   [ [🙁 Not relevant](https://www.sonatype.com/lift-comment-rating?comment=347590287&lift_comment_rating=1) ] - [ [😕 Won't fix](https://www.sonatype.com/lift-comment-rating?comment=347590287&lift_comment_rating=2) ] - [ [😑 Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=347590287&lift_comment_rating=3) ] - [ [🙂 Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=347590287&lift_comment_rating=4) ] - [ [😊 Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=347590287&lift_comment_rating=5) ]



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-python] wu-sheng commented on pull request #245: Greenlet

Posted by GitBox <gi...@apache.org>.

wu-sheng commented on PR #245:
URL: https://github.com/apache/skywalking-python/pull/245#issuecomment-1288531411

   **Documentations should be in English.**
   
   Besides this, the documents are in https://github.com/apache/skywalking-python/tree/master/docs and indexed by `menu.yaml`, hosted here, https://skywalking.apache.org/docs/skywalking-python/next/readme/
   
   Test should be done through e2e, rather than a test main file.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org