You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/05/05 13:08:23 UTC

[GitHub] [superset] kgabryje commented on a change in pull request #14485: chore: Move styles from .less stylesheet to emotion in Explore

kgabryje commented on a change in pull request #14485:
URL: https://github.com/apache/superset/pull/14485#discussion_r626548209



##########
File path: superset-frontend/src/explore/components/ExploreContentPopover.tsx
##########
@@ -16,26 +16,26 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import React from 'react';
-import PropTypes from 'prop-types';
-import { ColumnTypeLabel } from '@superset-ui/chart-controls';
+import { styled } from '@superset-ui/core';
 
-import adhocMetricType from './adhocMetricType';
-
-const propTypes = {
-  adhocMetric: adhocMetricType,
-  showType: PropTypes.bool,
-};
-
-export default function AdhocMetricStaticOption({
-  adhocMetric,
-  showType = false,
-}) {
-  return (
-    <div>
-      {showType && <ColumnTypeLabel type="expression" />}
-      <span className="option-label">{adhocMetric.label}</span>
-    </div>
-  );
-}
-AdhocMetricStaticOption.propTypes = propTypes;
+export const ExplorePopoverContent = styled.div`
+  .edit-popover-resize {
+    transform: scaleX(-1);
+    -moz-transform: scaleX(-1);
+    -webkit-transform: scaleX(-1);

Review comment:
       Nope, Emotion does it for us. Thanks!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org