You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/07/13 19:18:28 UTC
[GitHub] [kafka] cmccabe commented on a change in pull request #9012: KAFKA-10270: A broker to controller channel manager for AlterConfig redirection
cmccabe commented on a change in pull request #9012:
URL: https://github.com/apache/kafka/pull/9012#discussion_r453875212
##########
File path: clients/src/main/java/org/apache/kafka/clients/ClientRequest.java
##########
@@ -85,11 +89,12 @@ public ApiKeys apiKey() {
public RequestHeader makeHeader(short version) {
short requestApiKey = requestBuilder.apiKey().id;
return new RequestHeader(
- new RequestHeaderData().
- setRequestApiKey(requestApiKey).
- setRequestApiVersion(version).
- setClientId(clientId).
- setCorrelationId(correlationId),
+ new RequestHeaderData()
Review comment:
it would be good to use the existing style of periods at the end to avoid a big change here
##########
File path: clients/src/main/java/org/apache/kafka/clients/KafkaClient.java
##########
@@ -186,16 +186,18 @@ ClientRequest newClientRequest(String nodeId, AbstractRequest.Builder<?> request
* @param createdTimeMs the time in milliseconds to use as the creation time of the request
* @param expectResponse true iff we expect a response
* @param requestTimeoutMs Upper bound time in milliseconds to await a response before disconnecting the socket and
- * cancelling the request. The request may get cancelled sooner if the socket disconnects
- * for any reason including if another pending request to the same node timed out first.
+* cancelling the request. The request may get cancelled sooner if the socket disconnects
Review comment:
seems like a whitespace error here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org