You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Tejas Patil (JIRA)" <ji...@apache.org> on 2013/09/11 21:52:53 UTC
[jira] [Commented] (KAFKA-1053) Kafka patch review tool
[ https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13764683#comment-13764683 ]
Tejas Patil commented on KAFKA-1053:
------------------------------------
(1) In [0], "Setup" -> hyperlinks on steps 1 and 2 loop to the same webpage.
(2) I don't have much idea about the right place where the ".reviewboardrc" file should be, but it would be a good idea to commit it in the codebase like [1]. Also, add it to .gitignore (like [2]).
(3) How about adding "kafka-rb.py" to kafka codebase ? With that *maybe* there won't be any need for JIRA_CMDLINE_HOME.
(4) In kafka-rb.py:
> popt.add_argument('-s', '--summary', action='store', dest='summary', required=False, help='Summary for the reviewboard')
> popt.add_argument('-d', '--description', action='store', dest='description', required=False
I am wondering if someone doesn't provide a summary and as its an optional param, the script won't complain. Eventually, RB dashboard would end up having a bunch of tickets with no summary or title.
(6) > print 'Creating reviewboard'
Could this message sound good: "Generating a new review board ticket" ?
(7) Is there a way to specify the "Testing Done" text of RB through this script ?
[0] : https://cwiki.apache.org/confluence/display/KAFKA/Kafka+patch+review+tool
[1] : https://issues.apache.org/jira/browse/GIRAPH-331
[2] : https://issues.apache.org/jira/browse/TAJO-69
> Kafka patch review tool
> -----------------------
>
> Key: KAFKA-1053
> URL: https://issues.apache.org/jira/browse/KAFKA-1053
> Project: Kafka
> Issue Type: New Feature
> Components: tools
> Reporter: Neha Narkhede
> Assignee: Neha Narkhede
>
> Created a new patch review tool that will integrate JIRA and reviewboard - https://cwiki.apache.org/confluence/display/KAFKA/Kafka+patch+review+tool
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira