You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2014/11/24 20:19:56 UTC
Review Request 28398: Adding cron check into aurora beta-update start.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28398/
-----------------------------------------------------------
Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner.
Bugs: AURORA-921
https://issues.apache.org/jira/browse/AURORA-921
Repository: aurora
Description
-------
Failing fast "aurora beta-update start" when a cron schedule is specified.
Also, updated cron command help messages and docs.
Diffs
-----
docs/clientv2.md 6e69af3837f63321e273f1df7b0f5a1c07505cc7
docs/cron-jobs.md 7d04bcd3776bfd85f14e4398c4bc57dfbbdbcc72
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a5e869fc52ab6c4c28e6965585b015440f448f59
src/main/python/apache/aurora/client/cli/cron.py cfd957cb99fb1c0bff04f0c91969a66faaf3b6f2
src/main/python/apache/aurora/client/cli/update.py 12774af8bcd1c953fdbc799b0a142c27407d69f5
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java de5f21a084109e5f31a7e5fca1b8ee265e30b893
src/test/python/apache/aurora/client/cli/test_supdate.py 7637352feea6b07408256158814c05bc17ec14f3
Diff: https://reviews.apache.org/r/28398/diff/
Testing
-------
./pants src/test/python:all
Tested in vagrant.
Thanks,
Maxim Khutornenko
Re: Review Request 28398: Adding cron check into aurora beta-update
start.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28398/#review62851
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On Nov. 24, 2014, 7:19 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28398/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2014, 7:19 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner.
>
>
> Bugs: AURORA-921
> https://issues.apache.org/jira/browse/AURORA-921
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Failing fast "aurora beta-update start" when a cron schedule is specified.
>
> Also, updated cron command help messages and docs.
>
>
> Diffs
> -----
>
> docs/clientv2.md 6e69af3837f63321e273f1df7b0f5a1c07505cc7
> docs/cron-jobs.md 7d04bcd3776bfd85f14e4398c4bc57dfbbdbcc72
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a5e869fc52ab6c4c28e6965585b015440f448f59
> src/main/python/apache/aurora/client/cli/cron.py cfd957cb99fb1c0bff04f0c91969a66faaf3b6f2
> src/main/python/apache/aurora/client/cli/update.py 12774af8bcd1c953fdbc799b0a142c27407d69f5
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java de5f21a084109e5f31a7e5fca1b8ee265e30b893
> src/test/python/apache/aurora/client/cli/test_supdate.py 7637352feea6b07408256158814c05bc17ec14f3
>
> Diff: https://reviews.apache.org/r/28398/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python:all
>
> Tested in vagrant.
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 28398: Adding cron check into aurora beta-update
start.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28398/#review62857
-----------------------------------------------------------
Ship it!
Master (9514a63) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Nov. 24, 2014, 7:19 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28398/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2014, 7:19 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner.
>
>
> Bugs: AURORA-921
> https://issues.apache.org/jira/browse/AURORA-921
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Failing fast "aurora beta-update start" when a cron schedule is specified.
>
> Also, updated cron command help messages and docs.
>
>
> Diffs
> -----
>
> docs/clientv2.md 6e69af3837f63321e273f1df7b0f5a1c07505cc7
> docs/cron-jobs.md 7d04bcd3776bfd85f14e4398c4bc57dfbbdbcc72
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a5e869fc52ab6c4c28e6965585b015440f448f59
> src/main/python/apache/aurora/client/cli/cron.py cfd957cb99fb1c0bff04f0c91969a66faaf3b6f2
> src/main/python/apache/aurora/client/cli/update.py 12774af8bcd1c953fdbc799b0a142c27407d69f5
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java de5f21a084109e5f31a7e5fca1b8ee265e30b893
> src/test/python/apache/aurora/client/cli/test_supdate.py 7637352feea6b07408256158814c05bc17ec14f3
>
> Diff: https://reviews.apache.org/r/28398/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python:all
>
> Tested in vagrant.
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 28398: Adding cron check into aurora beta-update
start.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28398/#review62858
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On Nov. 24, 2014, 11:19 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28398/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2014, 11:19 a.m.)
>
>
> Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner.
>
>
> Bugs: AURORA-921
> https://issues.apache.org/jira/browse/AURORA-921
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Failing fast "aurora beta-update start" when a cron schedule is specified.
>
> Also, updated cron command help messages and docs.
>
>
> Diffs
> -----
>
> docs/clientv2.md 6e69af3837f63321e273f1df7b0f5a1c07505cc7
> docs/cron-jobs.md 7d04bcd3776bfd85f14e4398c4bc57dfbbdbcc72
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a5e869fc52ab6c4c28e6965585b015440f448f59
> src/main/python/apache/aurora/client/cli/cron.py cfd957cb99fb1c0bff04f0c91969a66faaf3b6f2
> src/main/python/apache/aurora/client/cli/update.py 12774af8bcd1c953fdbc799b0a142c27407d69f5
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java de5f21a084109e5f31a7e5fca1b8ee265e30b893
> src/test/python/apache/aurora/client/cli/test_supdate.py 7637352feea6b07408256158814c05bc17ec14f3
>
> Diff: https://reviews.apache.org/r/28398/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python:all
>
> Tested in vagrant.
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 28398: Adding cron check into aurora beta-update
start.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28398/
-----------------------------------------------------------
(Updated Nov. 25, 2014, 6 p.m.)
Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner.
Changes
-------
CR comments.
Bugs: AURORA-921
https://issues.apache.org/jira/browse/AURORA-921
Repository: aurora
Description
-------
Failing fast "aurora beta-update start" when a cron schedule is specified.
Also, updated cron command help messages and docs.
Diffs (updated)
-----
docs/clientv2.md 6e69af3837f63321e273f1df7b0f5a1c07505cc7
docs/cron-jobs.md 7d04bcd3776bfd85f14e4398c4bc57dfbbdbcc72
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a5e869fc52ab6c4c28e6965585b015440f448f59
src/main/python/apache/aurora/client/cli/cron.py cfd957cb99fb1c0bff04f0c91969a66faaf3b6f2
src/main/python/apache/aurora/client/cli/update.py 12774af8bcd1c953fdbc799b0a142c27407d69f5
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java de5f21a084109e5f31a7e5fca1b8ee265e30b893
src/test/python/apache/aurora/client/cli/test_supdate.py 7637352feea6b07408256158814c05bc17ec14f3
Diff: https://reviews.apache.org/r/28398/diff/
Testing
-------
./pants src/test/python:all
Tested in vagrant.
Thanks,
Maxim Khutornenko
Re: Review Request 28398: Adding cron check into aurora beta-update
start.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On Nov. 24, 2014, 7:48 p.m., David McLaughlin wrote:
> > src/main/python/apache/aurora/client/cli/cron.py, line 79
> > <https://reviews.apache.org/r/28398/diff/1/?file=774538#file774538line79>
> >
> > s/existing //
Done.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28398/#review62853
-----------------------------------------------------------
On Nov. 24, 2014, 7:19 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28398/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2014, 7:19 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner.
>
>
> Bugs: AURORA-921
> https://issues.apache.org/jira/browse/AURORA-921
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Failing fast "aurora beta-update start" when a cron schedule is specified.
>
> Also, updated cron command help messages and docs.
>
>
> Diffs
> -----
>
> docs/clientv2.md 6e69af3837f63321e273f1df7b0f5a1c07505cc7
> docs/cron-jobs.md 7d04bcd3776bfd85f14e4398c4bc57dfbbdbcc72
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a5e869fc52ab6c4c28e6965585b015440f448f59
> src/main/python/apache/aurora/client/cli/cron.py cfd957cb99fb1c0bff04f0c91969a66faaf3b6f2
> src/main/python/apache/aurora/client/cli/update.py 12774af8bcd1c953fdbc799b0a142c27407d69f5
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java de5f21a084109e5f31a7e5fca1b8ee265e30b893
> src/test/python/apache/aurora/client/cli/test_supdate.py 7637352feea6b07408256158814c05bc17ec14f3
>
> Diff: https://reviews.apache.org/r/28398/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python:all
>
> Tested in vagrant.
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 28398: Adding cron check into aurora beta-update
start.
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28398/#review62853
-----------------------------------------------------------
Ship it!
src/main/python/apache/aurora/client/cli/cron.py
<https://reviews.apache.org/r/28398/#comment104981>
s/existing //
- David McLaughlin
On Nov. 24, 2014, 7:19 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28398/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2014, 7:19 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner.
>
>
> Bugs: AURORA-921
> https://issues.apache.org/jira/browse/AURORA-921
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Failing fast "aurora beta-update start" when a cron schedule is specified.
>
> Also, updated cron command help messages and docs.
>
>
> Diffs
> -----
>
> docs/clientv2.md 6e69af3837f63321e273f1df7b0f5a1c07505cc7
> docs/cron-jobs.md 7d04bcd3776bfd85f14e4398c4bc57dfbbdbcc72
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a5e869fc52ab6c4c28e6965585b015440f448f59
> src/main/python/apache/aurora/client/cli/cron.py cfd957cb99fb1c0bff04f0c91969a66faaf3b6f2
> src/main/python/apache/aurora/client/cli/update.py 12774af8bcd1c953fdbc799b0a142c27407d69f5
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java de5f21a084109e5f31a7e5fca1b8ee265e30b893
> src/test/python/apache/aurora/client/cli/test_supdate.py 7637352feea6b07408256158814c05bc17ec14f3
>
> Diff: https://reviews.apache.org/r/28398/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python:all
>
> Tested in vagrant.
>
>
> Thanks,
>
> Maxim Khutornenko
>
>