You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "lordgamez (via GitHub)" <gi...@apache.org> on 2024/11/18 16:22:26 UTC
[PR] MINIFICPP-2491 Upgrade GRPC and Abseil libs [nifi-minifi-cpp]
lordgamez opened a new pull request, #1897:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1897
Fixes Windows build CI failure
-----------------
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2491 Upgrade GRPC and Abseil libs [nifi-minifi-cpp]
Posted by "szaszm (via GitHub)" <gi...@apache.org>.
szaszm commented on code in PR #1897:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1897#discussion_r1850713829
##########
thirdparty/grpc/fix-constants-on-windows.patch:
##########
@@ -0,0 +1,17 @@
+diff --git a/third_party/upb/upb/message/internal/message.c b/third_party/upb/upb/message/internal/message.c
+index 57ab2d7371..5f321c7bb2 100644
+--- a/third_party/upb/upb/message/internal/message.c
++++ b/third_party/upb/upb/message/internal/message.c
Review Comment:
```
D:\a\nifi-minifi-cpp\nifi-minifi-cpp\build\_deps\grpc-src\third_party\protobuf\upb\message\internal\message.c(22,14): error C2099: initializer is not a constant
const double kUpb_NaN = NAN;
```
The path seems different in the CI failure that happened after this patch was added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2491 Upgrade GRPC and Abseil libs [nifi-minifi-cpp]
Posted by "lordgamez (via GitHub)" <gi...@apache.org>.
lordgamez commented on code in PR #1897:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1897#discussion_r1848108260
##########
thirdparty/grpc/remove-custom-commands-for-unused-dependencies.patch:
##########
Review Comment:
Some libraries like the googleapis and evoy-api are built with the Grpc library as a thirdparty for cloud API support, but we don't use them for our use case, so we don't load those submodules and don't build them. These custom commands are used to generate protocol buffer interface for these APIs, but it would fail as we do not load those thirdparties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2491 Upgrade GRPC and Abseil libs [nifi-minifi-cpp]
Posted by "fgerlits (via GitHub)" <gi...@apache.org>.
fgerlits commented on code in PR #1897:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1897#discussion_r1847926780
##########
thirdparty/grpc/remove-custom-commands-for-unused-dependencies.patch:
##########
@@ -0,0 +1,425 @@
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index fc4b6a40a5..ae494f1464 100644
+--- a/CMakeLists.txt
++++ b/CMakeLists.txt
+@@ -489,7 +489,7 @@ if(WIN32)
+ set(_gRPC_ALLTARGETS_LIBRARIES ${_gRPC_ALLTARGETS_LIBRARIES} ws2_32 crypt32)
+ set(_gRPC_STATIC_WIN32 STATIC)
+ endif()
+-
++
+ if(BUILD_SHARED_LIBS AND WIN32)
+
+ # Currently for shared lib on Windows (i.e. a DLL) certain bits of source code
Review Comment:
This section of the patch looks like it's just a whitespace difference. Is it needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2491 Upgrade GRPC and Abseil libs [nifi-minifi-cpp]
Posted by "lordgamez (via GitHub)" <gi...@apache.org>.
lordgamez commented on code in PR #1897:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1897#discussion_r1847934637
##########
thirdparty/grpc/remove-custom-commands-for-unused-dependencies.patch:
##########
@@ -0,0 +1,425 @@
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index fc4b6a40a5..ae494f1464 100644
+--- a/CMakeLists.txt
++++ b/CMakeLists.txt
+@@ -489,7 +489,7 @@ if(WIN32)
+ set(_gRPC_ALLTARGETS_LIBRARIES ${_gRPC_ALLTARGETS_LIBRARIES} ws2_32 crypt32)
+ set(_gRPC_STATIC_WIN32 STATIC)
+ endif()
+-
++
+ if(BUILD_SHARED_LIBS AND WIN32)
+
+ # Currently for shared lib on Windows (i.e. a DLL) certain bits of source code
Review Comment:
No it's not needed, my editor automatically removes line ending whitespaces so it probably added this when I created the diff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2491 Upgrade GRPC and Abseil libs [nifi-minifi-cpp]
Posted by "lordgamez (via GitHub)" <gi...@apache.org>.
lordgamez commented on code in PR #1897:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1897#discussion_r1851595354
##########
thirdparty/grpc/fix-constants-on-windows.patch:
##########
@@ -0,0 +1,17 @@
+diff --git a/third_party/upb/upb/message/internal/message.c b/third_party/upb/upb/message/internal/message.c
+index 57ab2d7371..5f321c7bb2 100644
+--- a/third_party/upb/upb/message/internal/message.c
++++ b/third_party/upb/upb/message/internal/message.c
Review Comment:
Fixed the issue in https://github.com/apache/nifi-minifi-cpp/pull/1897/commits/489bf510eb683eb42aa89f2935c68095ccb13971 also there was a test build issue with the new MSVC in the CI, fixed that in https://github.com/apache/nifi-minifi-cpp/pull/1897/commits/401f919835072c6404bfe249a00bc8dcc745d435
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2491 Upgrade GRPC and Abseil libs [nifi-minifi-cpp]
Posted by "lordgamez (via GitHub)" <gi...@apache.org>.
lordgamez commented on PR #1897:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1897#issuecomment-2488917132
Added fix mentioned in https://github.com/grpc/grpc/issues/37210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2491 Upgrade GRPC and Abseil libs [nifi-minifi-cpp]
Posted by "lordgamez (via GitHub)" <gi...@apache.org>.
lordgamez commented on code in PR #1897:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1897#discussion_r1849943481
##########
thirdparty/grpc/remove-custom-commands-for-unused-dependencies.patch:
##########
@@ -0,0 +1,425 @@
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index fc4b6a40a5..ae494f1464 100644
+--- a/CMakeLists.txt
++++ b/CMakeLists.txt
+@@ -489,7 +489,7 @@ if(WIN32)
+ set(_gRPC_ALLTARGETS_LIBRARIES ${_gRPC_ALLTARGETS_LIBRARIES} ws2_32 crypt32)
+ set(_gRPC_STATIC_WIN32 STATIC)
+ endif()
+-
++
+ if(BUILD_SHARED_LIBS AND WIN32)
+
+ # Currently for shared lib on Windows (i.e. a DLL) certain bits of source code
Review Comment:
Removed in https://github.com/apache/nifi-minifi-cpp/pull/1897/commits/18fc86102c9cce88d4189e2187a7653d629c5cf7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2491 Upgrade GRPC and Abseil libs [nifi-minifi-cpp]
Posted by "szaszm (via GitHub)" <gi...@apache.org>.
szaszm closed pull request #1897: MINIFICPP-2491 Upgrade GRPC and Abseil libs
URL: https://github.com/apache/nifi-minifi-cpp/pull/1897
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2491 Upgrade GRPC and Abseil libs [nifi-minifi-cpp]
Posted by "lordgamez (via GitHub)" <gi...@apache.org>.
lordgamez commented on code in PR #1897:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1897#discussion_r1850195833
##########
thirdparty/grpc/remove-custom-commands-for-unused-dependencies.patch:
##########
@@ -0,0 +1,425 @@
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index fc4b6a40a5..ae494f1464 100644
+--- a/CMakeLists.txt
++++ b/CMakeLists.txt
+@@ -489,7 +489,7 @@ if(WIN32)
+ set(_gRPC_ALLTARGETS_LIBRARIES ${_gRPC_ALLTARGETS_LIBRARIES} ws2_32 crypt32)
+ set(_gRPC_STATIC_WIN32 STATIC)
+ endif()
+-
++
+ if(BUILD_SHARED_LIBS AND WIN32)
+
+ # Currently for shared lib on Windows (i.e. a DLL) certain bits of source code
Review Comment:
Readded the whitespace change and added a note to be aware of the reverse patch dry run issue in https://github.com/apache/nifi-minifi-cpp/pull/1897/commits/116696f1b51ee689bb2e36aa6187489216d39d39
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2491 Upgrade GRPC and Abseil libs [nifi-minifi-cpp]
Posted by "szaszm (via GitHub)" <gi...@apache.org>.
szaszm commented on code in PR #1897:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1897#discussion_r1848093296
##########
thirdparty/grpc/remove-custom-commands-for-unused-dependencies.patch:
##########
Review Comment:
why are these dependencies unused, but still present?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org