[GitHub] [spark] HyukjinKwon commented on a diff in pull request #38586: [SPARK-41077][CONNECT][PYTHON][REFACTORING] Rename `ColumnRef` to `Column` in Python client implementation

[GitBox <gi...@apache.org>]

HyukjinKwon commented on code in PR #38586:
URL: https://github.com/apache/spark/pull/38586#discussion_r1018671588


##########
python/pyspark/sql/connect/column.py:
##########
@@ -30,8 +30,8 @@
 
 def _bin_op(
     name: str, doc: str = "binary function", reverse: bool = False
-) -> Callable[["ColumnRef", Any], "Expression"]:
-    def _(self: "ColumnRef", other: Any) -> "Expression":
+) -> Callable[["Column", Any], "Expression"]:
+    def _(self: "Column", other: Any) -> "Expression":

Review Comment:
   I think this is a bit unclear. For example,  Spark Connect's `Expression` has binary operators like `pyspark.sql.Column` does. If Spark Connect's `ColumnRef` indicates a column reference only, it should be something like `AttributeReference`. cc @cloud-fan 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org