You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "jojochuang (via GitHub)" <gi...@apache.org> on 2025/05/17 00:15:05 UTC
[PR] HDDS-13061. Add ACL operation permission check tests. [ozone]
jojochuang opened a new pull request, #8472:
URL: https://github.com/apache/ozone/pull/8472
HDDS-13061. Add ACL operation permission check tests.
Please describe your PR in detail:
* Verify that without proper permissions, getAcl, setAcl, addAcl, removeAcl all throws PERMISSION_DENIED.
* In addition, verify that audit log records the corresponding failures.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13061
## How was this patch tested?
Unit test only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13061. Add ACL operation permission check tests. [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #8472:
URL: https://github.com/apache/ozone/pull/8472#discussion_r2094040504
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOmAcls.java:
##########
@@ -204,6 +208,58 @@ public void testSetACLPermissionDenied() throws Exception {
verifyAuditLog(OMAction.SET_ACL, AuditEventStatus.FAILURE);
}
+ @Test
+ public void testSetlACLKeyPermissionDenied() throws Exception {
+ OzoneBucket bucket = TestDataUtil.createVolumeAndBucket(client);
+ String keyName = "testKey";
+ TestDataUtil.createKey(bucket, "testKey", "testcontent".getBytes(StandardCharsets.UTF_8));
Review Comment:
```suggestion
TestDataUtil.createKey(bucket, keyName, "testcontent".getBytes(StandardCharsets.UTF_8));
```
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOmAcls.java:
##########
@@ -204,6 +208,58 @@ public void testSetACLPermissionDenied() throws Exception {
verifyAuditLog(OMAction.SET_ACL, AuditEventStatus.FAILURE);
}
+ @Test
+ public void testSetlACLKeyPermissionDenied() throws Exception {
Review Comment:
There is also a typo in the current name, so let's rename as @ivandika3 suggested.
```suggestion
public void testKeyACLOpsPermissionDenied() throws Exception {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13061. Add ACL operation permission check tests. [ozone]
Posted by "ivandika3 (via GitHub)" <gi...@apache.org>.
ivandika3 commented on code in PR #8472:
URL: https://github.com/apache/ozone/pull/8472#discussion_r2093842511
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOmAcls.java:
##########
@@ -204,6 +208,58 @@ public void testSetACLPermissionDenied() throws Exception {
verifyAuditLog(OMAction.SET_ACL, AuditEventStatus.FAILURE);
}
+ @Test
+ public void testSetlACLKeyPermissionDenied() throws Exception {
Review Comment:
We can rename this test with `testKeyACLOpsPermissionDenied` (or something similar) since it includes other ACL ops (GET, SET, ADD, REMOVE).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13061. Add ACL operation permission check tests. [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #8472:
URL: https://github.com/apache/ozone/pull/8472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13061. Add ACL operation permission check tests. [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #8472:
URL: https://github.com/apache/ozone/pull/8472#issuecomment-2888270584
Thanks @jojochuang for the patch, @ivandika3 for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org