Re: Review Request 19039: CLOUDSTACK-2266: Adding automation tests for IP reservation feature

[Santhosh Edukulla <sa...@citrix.com>]

> On March 21, 2014, 6:50 a.m., Santhosh Edukulla wrote:
> > Ship It!

It seems all review items have been addressed. We can just commit it.


- Santhosh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19039/#review38068
-----------------------------------------------------------


On March 20, 2014, 5:31 p.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19039/
> -----------------------------------------------------------
> 
> (Updated March 20, 2014, 5:31 p.m.)
> 
> 
> Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-2266
>     https://issues.apache.org/jira/browse/CLOUDSTACK-2266
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Adding first set of automation tests for IP reservation feature.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_ip_reservation.py 224212f 
>   tools/marvin/marvin/codes.py e4a0f6a 
>   tools/marvin/marvin/config/config.cfg 356a291 
>   tools/marvin/marvin/integration/lib/common.py 3b292bf 
>   tools/marvin/marvin/integration/lib/utils.py 709fdde 
> 
> Diff: https://reviews.apache.org/r/19039/diff/
> 
> 
> Testing
> -------
> 
> Yes. Log below.
> 
> test_RVR_network (test_ip_reservation.TestIpReservation) ... SKIP: Skip - WIP
> test_ip_reservation_in_multiple_networks_same_account (test_ip_reservation.TestIpReservation) ... ok
> test_nat_rules_nat rule (test_ip_reservation.TestIpReservation) ... ok
> test_nat_rules_static nat rule (test_ip_reservation.TestIpReservation) ... ok
> test_update_cidr_multiple_vms_not_all_inclusive (test_ip_reservation.TestIpReservation) ... ok
> test_update_cidr_single_vm_not_inclusive (test_ip_reservation.TestIpReservation) ... ok
> test_user_defined_cidr (test_ip_reservation.TestIpReservation) ... ok
> test_vm_create_after_reservation_LB-NS (test_ip_reservation.TestIpReservation) ... SKIP: Skipping - this test required netscaler configured in the network
> test_vm_create_after_reservation_LB-VR (test_ip_reservation.TestIpReservation) ... ok
> test_vm_create_outside_cidr_after_reservation_LB-NS (test_ip_reservation.TestIpReservation) ... SKIP: Skipping - this test required netscaler configured in the network
> test_vm_create_outside_cidr_after_reservation_LB-VR (test_ip_reservation.TestIpReservation) ... ok
> ----------------------------------------------------------------------
> Ran 11 tests in 3753.613s
> 
> OK
> 
> Two tests which require Netscaler configured are skipped due to netscaler was not available on setup.
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>