You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Qiang Zhang <zh...@zte.com.cn> on 2017/05/09 12:50:45 UTC
Re: Review Request 58231: RANGER-1498 - Remove unnecessary mockito
stubs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58231/#review174299
-----------------------------------------------------------
git apply --check 0001-RANGER-1498-Remove-unnecessary-mockito-stubs.patch
error: patch failed: security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java:965
error: security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java: patch does not apply
Please rebuild the patch.
- Qiang Zhang
On April 6, 2017, 11:12 a.m., Colm O hEigeartaigh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58231/
> -----------------------------------------------------------
>
> (Updated April 6, 2017, 11:12 a.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-1498
> https://issues.apache.org/jira/browse/RANGER-1498
>
>
> Repository: ranger
>
>
> Description
> -------
>
> This task is to remove the unnecessary mockito stubs in the test code. This will smooth the path to updating to use Mockito 2, which errors by default on unused stubs.
>
>
> Diffs
> -----
>
> security-admin/src/test/java/org/apache/ranger/biz/TestRangerBizUtil.java 2554a14
> security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java 3015f97
> security-admin/src/test/java/org/apache/ranger/biz/TestUserMgr.java 6083778
> security-admin/src/test/java/org/apache/ranger/biz/TestXUserMgr.java 3323f11
> security-admin/src/test/java/org/apache/ranger/rest/TestPublicAPIsv2.java 761ed03
> security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java 4c83c87
> security-admin/src/test/java/org/apache/ranger/rest/TestTagREST.java 531ad9b
> security-admin/src/test/java/org/apache/ranger/rest/TestXAuditREST.java ef59fba
> security-admin/src/test/java/org/apache/ranger/rest/TestXKeyREST.java a82969c
> security-admin/src/test/java/org/apache/ranger/rest/TestXUserREST.java c544832
> security-admin/src/test/java/org/apache/ranger/service/TestRangerServiceDefService.java d65b0d6
> security-admin/src/test/java/org/apache/ranger/service/TestRangerServiceDefServiceBase.java 06ac327
> security-admin/src/test/java/org/apache/ranger/service/TestRangerServiceService.java c8cb716
> security-admin/src/test/java/org/apache/ranger/service/TestRangerServiceServiceBase.java 216c338
>
>
> Diff: https://reviews.apache.org/r/58231/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colm O hEigeartaigh
>
>