[GitHub] [cloudstack] andrijapanicsb commented on a change in pull request #3808: reload dnsmasq instead of restart when adding new rules

[GitBox <gi...@apache.org>]

andrijapanicsb commented on a change in pull request #3808: reload dnsmasq instead of restart when adding new rules
URL: https://github.com/apache/cloudstack/pull/3808#discussion_r367183135
 
 

 ##########
 File path: systemvm/debian/opt/cloud/bin/cs/CsDhcp.py
 ##########
 @@ -69,7 +69,7 @@ def process(self):
 
         if not self.cl.is_redundant() or self.cl.is_master():
             if restart_dnsmasq:
-                CsHelper.service("dnsmasq", "restart")
+                CsHelper.service("dnsmasq", "reload")
 
 Review comment:
   I'll need to test this all @weizhouapache , but afaik dnsmasq is started when VR is created?
   Do you see a problem here? (save me some time from testing all this...)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services