You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Andres de la Peña (Jira)" <ji...@apache.org> on 2022/10/24 18:24:00 UTC
[jira] [Comment Edited] (CASSANDRA-17987) CircleCI: Add jobs for running specialized unit tests with Java 11
[ https://issues.apache.org/jira/browse/CASSANDRA-17987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623331#comment-17623331 ]
Andres de la Peña edited comment on CASSANDRA-17987 at 10/24/22 6:23 PM:
-------------------------------------------------------------------------
I'm also adding the missing CDC unit tests, since doing it here doesn't require too much extra effort:
* [j8 pre-commit|https://app.circleci.com/pipelines/github/adelapena/cassandra/2318/workflows/7840c4a4-c280-45f8-871d-d3aa71a96372]
* [j11 pre-commit|https://app.circleci.com/pipelines/github/adelapena/cassandra/2318/workflows/df241342-aca4-4250-997f-d78aaee8d5cd]
* [j8 separate|https://app.circleci.com/pipelines/github/adelapena/cassandra/2318/workflows/78650a8e-4c7e-4278-93d2-744547b750f0]
* [j11 separate|https://app.circleci.com/pipelines/github/adelapena/cassandra/2318/workflows/125a1087-8e20-4e25-803b-daff5136e98f]
{quote}Shall we make the trie unit tests mandatory at least for jdk8 until they are added also in Jenkins? Same as we did for keyspaces? Or do you want to do it in a separate ticket or run it through the ML?
{quote}
Not sure:
# If we make them mandatory here. If CASSANDRA-17987 gets merged after this, we'll need another ticket to make them not mandatory again. That's not ideal given the time and money required to test this kind of patches.
# We could block this ticket until CASSANDRA-17987 gets merged, but that will leave us without a way of running trie tests with Java 11 in the mean time.
# We could commit this in what is expected to be its final state and hope that CASSANDRA-17987 gets merged soon, which seems likely.
In any case, note that the utests-trie job is mostly a just-in-case config, and tries have their own tests that are run with the regular config.
was (Author: adelapena):
I'm also add the missing CDC unit tests, since doing it here doesn't require too much extra effort:
* [j8 pre-commit|https://app.circleci.com/pipelines/github/adelapena/cassandra/2318/workflows/7840c4a4-c280-45f8-871d-d3aa71a96372]
* [j11 pre-commit|https://app.circleci.com/pipelines/github/adelapena/cassandra/2318/workflows/df241342-aca4-4250-997f-d78aaee8d5cd]
* [j8 separate|https://app.circleci.com/pipelines/github/adelapena/cassandra/2318/workflows/78650a8e-4c7e-4278-93d2-744547b750f0]
* [j11 separate|https://app.circleci.com/pipelines/github/adelapena/cassandra/2318/workflows/125a1087-8e20-4e25-803b-daff5136e98f]
{quote}Shall we make the trie unit tests mandatory at least for jdk8 until they are added also in Jenkins? Same as we did for keyspaces? Or do you want to do it in a separate ticket or run it through the ML?
{quote}
Not sure:
# If we make them mandatory here. If CASSANDRA-17987 gets merged after this, we'll need another ticket to make them not mandatory again. That's not ideal given the time and money required to test this kind of patches.
# We could block this ticket until CASSANDRA-17987 gets merged, but that will leave us without a way of running trie tests with Java 11 in the mean time.
# We could commit this in what is expected to be its final state and hope that CASSANDRA-17987 gets merged soon, which seems likely.
In any case, note that the utests-trie job is mostly a just-in-case config, and tries have their own tests that are run with the regular config.
> CircleCI: Add jobs for running specialized unit tests with Java 11
> ------------------------------------------------------------------
>
> Key: CASSANDRA-17987
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17987
> Project: Cassandra
> Issue Type: Task
> Components: CI
> Reporter: Andres de la Peña
> Assignee: Andres de la Peña
> Priority: Normal
>
> CircleCI has a set of jobs for running specialiazed unit tests that are only run with Java 8:
> * utests_compression
> * utests_system_keyspace_directory
> * utests_trie
> * utests_stress
> * utests_long
> * utests_fqltool
> It should probably be possible to run these tests with Java 11 tool.
> Rather than creating a ticket for every job, it's probably easier to use a single ticket for all of them. This should give us an overall vision for deciding job names, approval steps, etc. Also, the required config changes should be quite minimal and doing all of them at once should save us both effort and test runs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org