You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/05/16 14:32:27 UTC
[GitHub] [maven-surefire] andpab opened a new pull request #351: [SUREFIRE-1914] Draft: Document expected XML report format for @ParameterizedTest with ITs
andpab opened a new pull request #351:
URL: https://github.com/apache/maven-surefire/pull/351
This is just a draft to document what my expectations - as also described in the issue - would be. Obviously that means some tests will fail.
This draft is meant to form a basis for discussion, not to be merged directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #351: [SUREFIRE-1914] Draft: Document expected XML report format for @ParameterizedTest with ITs
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on a change in pull request #351:
URL: https://github.com/apache/maven-surefire/pull/351#discussion_r633134321
##########
File path: surefire-its/src/test/java/org/apache/maven/surefire/its/JUnitPlatformEnginesIT.java
##########
@@ -395,28 +396,46 @@ public void testJupiterEngineWithDisplayNames()
.assertContainsText( "<< ✨ >>" );
validator.getSurefireReportsFile( "junitplatformenginejupiter.DisplayNameTest-output.txt", UTF_8 )
- .assertContainsText( "73$71 ✔" );
-
- validator.getSurefireReportsFile( "junitplatformenginejupiter.DisplayNameTest-output.txt", UTF_8 )
- .assertContainsText( "73$72 ✔" );
+ .assertContainsText( "73$71 ✔" )
+ .assertContainsText( "73$72 ✔" )
+ .assertContainsText( "73$73 ✔" )
+ .assertContainsText( "73$74 ✔" );
validator.getSurefireReportsFile( "TEST-junitplatformenginejupiter.DisplayNameTest.xml", UTF_8 )
.assertContainsText( "testcase name=\"73$71 ✔\" classname=\"<< ✨ >>\"" )
.assertContainsText( "testcase name=\"73$72 ✔\" classname=\"<< ✨ >>\"" )
+ .assertContainsText( "testcase name=\"73$73 ✔ [1] a\" classname=\"<< ✨ >>\"" )
+ .assertContainsText( "testcase name=\"73$73 ✔ [2] b\" classname=\"<< ✨ >>\"" )
+ .assertContainsText( "testcase name=\"73$73 ✔ [3] c\" classname=\"<< ✨ >>\"" )
+ .assertContainsText( "testcase name=\"73$74 ✔ [1] a\" classname=\"<< ✨ >>\"" )
+ .assertContainsText( "testcase name=\"73$74 ✔ [2] b\" classname=\"<< ✨ >>\"" )
+ .assertContainsText( "testcase name=\"73$74 ✔ [3] c\" classname=\"<< ✨ >>\"" )
.assertContainsText( XML_TESTSUITE_FRAGMENT );
validator.getSurefireReportsFile( "TEST-junitplatformenginejupiter.BasicJupiterTest.xml", UTF_8 )
.assertContainsText( "<testcase name=\"test(TestInfo)\" "
+ "classname=\"junitplatformenginejupiter.BasicJupiterTest\"" )
- .assertContainsText( "<testcase name=\"0 + 1 = 1\" "
+ .assertContainsText( "<testcase name=\"add(int, int, int)[1] 0 + 1 = 1\" "
+ + "classname=\"junitplatformenginejupiter.BasicJupiterTest\"" )
+ .assertContainsText( "<testcase name=\"add(int, int, int)[2] 1 + 2 = 3\" "
+ + "classname=\"junitplatformenginejupiter.BasicJupiterTest\"" )
+ .assertContainsText( "<testcase name=\"add(int, int, int)[3] 49 + 51 = 100\" "
+ + "classname=\"junitplatformenginejupiter.BasicJupiterTest\"" )
+ .assertContainsText( "<testcase name=\"add(int, int, int)[4] 1 + 100 = 101\" "
+ + "classname=\"junitplatformenginejupiter.BasicJupiterTest\"" )
+ .assertContainsText( "<testcase name=\"square(int, int)[1] 1, 1\" "
+ + "classname=\"junitplatformenginejupiter.BasicJupiterTest\"" )
+ .assertContainsText( "<testcase name=\"square(int, int)[2] 2, 4\" "
+ + "classname=\"junitplatformenginejupiter.BasicJupiterTest\"" )
+ .assertContainsText( "<testcase name=\"square(int, int)[3] 3, 9\" "
+ "classname=\"junitplatformenginejupiter.BasicJupiterTest\"" )
- .assertContainsText( "<testcase name=\"1 + 2 = 3\" "
Review comment:
Where is the old method? I cannot see it here in this PR.
I would like to keep it and add new ones because then we have more alternatives. Would it be possible?
Pls check our documentation because sometimes we use the reference pointing to our IT tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] andpab commented on a change in pull request #351: [SUREFIRE-1914] Draft: Document expected XML report format for @ParameterizedTest with ITs
Posted by GitBox <gi...@apache.org>.
andpab commented on a change in pull request #351:
URL: https://github.com/apache/maven-surefire/pull/351#discussion_r637583305
##########
File path: surefire-its/src/test/resources/surefire-1914-xml-reporting-parameterizedtest/pom.xml
##########
@@ -0,0 +1,110 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+ -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <groupId>org.apache.maven.plugins.surefire</groupId>
+ <artifactId>surefire-1914-xml-reporting-parameterizedtest</artifactId>
+ <version>1.0</version>
+ <name>Test for: JUnit5Xml30StatelessReporter and Parameterized (SUREFIRE-1914)</name>
+
+ <properties>
+ <maven.compiler.source>1.8</maven.compiler.source>
+ <maven.compiler.target>1.8</maven.compiler.target>
+ <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
+ </properties>
+
+ <!--
+ Declare "junit-jupiter-engine" dependency because the
+ Jupiter Engine is needed at test runtime. Artifacts
+ needed for test compilation, like "junit-jupiter-api",
+ are pulled-in via transitive dependency resolution.
+ -->
+ <dependencies>
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-engine</artifactId>
+ <version>${junit5.version}</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-params</artifactId>
+ <version>${junit5.version}</version>
+ <scope>test</scope>
+ </dependency>
+ </dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <artifactId>maven-compiler-plugin</artifactId>
+ <version>3.8.0</version>
+ <configuration>
+ <encoding>UTF-8</encoding>
+ </configuration>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <version>${surefire.version}</version>
+ <configuration>
+ <forkCount>1.0C</forkCount>
+ <redirectTestOutputToFile>true</redirectTestOutputToFile>
+ <statelessTestsetReporter implementation="org.apache.maven.plugin.surefire.extensions.junit5.JUnit5Xml30StatelessReporter">
+ <disable>false</disable>
+ <version>3.0</version>
+ <usePhrasedFileName>false</usePhrasedFileName>
+ <usePhrasedTestSuiteClassName>true</usePhrasedTestSuiteClassName>
+ <usePhrasedTestCaseClassName>true</usePhrasedTestCaseClassName>
+ <usePhrasedTestCaseMethodName>true</usePhrasedTestCaseMethodName>
+ </statelessTestsetReporter>
+ <consoleOutputReporter implementation="org.apache.maven.plugin.surefire.extensions.junit5.JUnit5ConsoleOutputReporter">
+ <disable>false</disable>
+ <encoding>UTF-8</encoding>
+ <usePhrasedFileName>false</usePhrasedFileName>
+ </consoleOutputReporter>
+ <statelessTestsetInfoReporter implementation="org.apache.maven.plugin.surefire.extensions.junit5.JUnit5StatelessTestsetInfoReporter">
+ <disable>false</disable>
+ <usePhrasedFileName>false</usePhrasedFileName>
+ <usePhrasedClassNameInRunning>true</usePhrasedClassNameInRunning>
+ <usePhrasedClassNameInTestCaseSummary>true</usePhrasedClassNameInTestCaseSummary>
+ </statelessTestsetInfoReporter>
+ </configuration>
+ </plugin>
+ </plugins>
+ </build>
+
+ <repositories>
Review comment:
Removed the repository definition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #351: [SUREFIRE-1914] Draft: Document expected XML report format for @ParameterizedTest with ITs
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #351:
URL: https://github.com/apache/maven-surefire/pull/351#issuecomment-847334812
@andpab
Do you want to continue with the RunListenerAdapter? I may guide you and then the tests will pass successfully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #351: [SUREFIRE-1914] Draft: Document expected XML report format for @ParameterizedTest with ITs
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on a change in pull request #351:
URL: https://github.com/apache/maven-surefire/pull/351#discussion_r637404894
##########
File path: surefire-its/src/test/resources/surefire-1914-xml-reporting-parameterizedtest/pom.xml
##########
@@ -0,0 +1,110 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+ -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <groupId>org.apache.maven.plugins.surefire</groupId>
+ <artifactId>surefire-1914-xml-reporting-parameterizedtest</artifactId>
+ <version>1.0</version>
+ <name>Test for: JUnit5Xml30StatelessReporter and Parameterized (SUREFIRE-1914)</name>
+
+ <properties>
+ <maven.compiler.source>1.8</maven.compiler.source>
+ <maven.compiler.target>1.8</maven.compiler.target>
+ <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
+ </properties>
+
+ <!--
+ Declare "junit-jupiter-engine" dependency because the
+ Jupiter Engine is needed at test runtime. Artifacts
+ needed for test compilation, like "junit-jupiter-api",
+ are pulled-in via transitive dependency resolution.
+ -->
+ <dependencies>
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-engine</artifactId>
+ <version>${junit5.version}</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-params</artifactId>
+ <version>${junit5.version}</version>
+ <scope>test</scope>
+ </dependency>
+ </dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <artifactId>maven-compiler-plugin</artifactId>
+ <version>3.8.0</version>
+ <configuration>
+ <encoding>UTF-8</encoding>
+ </configuration>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <version>${surefire.version}</version>
+ <configuration>
+ <forkCount>1.0C</forkCount>
+ <redirectTestOutputToFile>true</redirectTestOutputToFile>
+ <statelessTestsetReporter implementation="org.apache.maven.plugin.surefire.extensions.junit5.JUnit5Xml30StatelessReporter">
+ <disable>false</disable>
+ <version>3.0</version>
+ <usePhrasedFileName>false</usePhrasedFileName>
+ <usePhrasedTestSuiteClassName>true</usePhrasedTestSuiteClassName>
+ <usePhrasedTestCaseClassName>true</usePhrasedTestCaseClassName>
+ <usePhrasedTestCaseMethodName>true</usePhrasedTestCaseMethodName>
+ </statelessTestsetReporter>
+ <consoleOutputReporter implementation="org.apache.maven.plugin.surefire.extensions.junit5.JUnit5ConsoleOutputReporter">
+ <disable>false</disable>
+ <encoding>UTF-8</encoding>
+ <usePhrasedFileName>false</usePhrasedFileName>
+ </consoleOutputReporter>
+ <statelessTestsetInfoReporter implementation="org.apache.maven.plugin.surefire.extensions.junit5.JUnit5StatelessTestsetInfoReporter">
+ <disable>false</disable>
+ <usePhrasedFileName>false</usePhrasedFileName>
+ <usePhrasedClassNameInRunning>true</usePhrasedClassNameInRunning>
+ <usePhrasedClassNameInTestCaseSummary>true</usePhrasedClassNameInTestCaseSummary>
+ </statelessTestsetInfoReporter>
+ </configuration>
+ </plugin>
+ </plugins>
+ </build>
+
+ <repositories>
Review comment:
Pls remove the `repository`. Our build uses the artifacts from your local repo. It means the integration tests expect `mvn install` which packages and installs the project artifacts in your local repo on your disk. Pls run `mvn install -nsu -P run-its -Dit.test=Surefire1914XmlReportingParameterizedTestIT`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] andpab commented on a change in pull request #351: [SUREFIRE-1914] Draft: Document expected XML report format for @ParameterizedTest with ITs
Posted by GitBox <gi...@apache.org>.
andpab commented on a change in pull request #351:
URL: https://github.com/apache/maven-surefire/pull/351#discussion_r633348741
##########
File path: surefire-its/src/test/java/org/apache/maven/surefire/its/JUnitPlatformEnginesIT.java
##########
@@ -395,28 +396,46 @@ public void testJupiterEngineWithDisplayNames()
.assertContainsText( "<< ✨ >>" );
validator.getSurefireReportsFile( "junitplatformenginejupiter.DisplayNameTest-output.txt", UTF_8 )
- .assertContainsText( "73$71 ✔" );
-
- validator.getSurefireReportsFile( "junitplatformenginejupiter.DisplayNameTest-output.txt", UTF_8 )
- .assertContainsText( "73$72 ✔" );
+ .assertContainsText( "73$71 ✔" )
+ .assertContainsText( "73$72 ✔" )
+ .assertContainsText( "73$73 ✔" )
+ .assertContainsText( "73$74 ✔" );
validator.getSurefireReportsFile( "TEST-junitplatformenginejupiter.DisplayNameTest.xml", UTF_8 )
.assertContainsText( "testcase name=\"73$71 ✔\" classname=\"<< ✨ >>\"" )
.assertContainsText( "testcase name=\"73$72 ✔\" classname=\"<< ✨ >>\"" )
+ .assertContainsText( "testcase name=\"73$73 ✔ [1] a\" classname=\"<< ✨ >>\"" )
+ .assertContainsText( "testcase name=\"73$73 ✔ [2] b\" classname=\"<< ✨ >>\"" )
+ .assertContainsText( "testcase name=\"73$73 ✔ [3] c\" classname=\"<< ✨ >>\"" )
+ .assertContainsText( "testcase name=\"73$74 ✔ [1] a\" classname=\"<< ✨ >>\"" )
+ .assertContainsText( "testcase name=\"73$74 ✔ [2] b\" classname=\"<< ✨ >>\"" )
+ .assertContainsText( "testcase name=\"73$74 ✔ [3] c\" classname=\"<< ✨ >>\"" )
.assertContainsText( XML_TESTSUITE_FRAGMENT );
validator.getSurefireReportsFile( "TEST-junitplatformenginejupiter.BasicJupiterTest.xml", UTF_8 )
.assertContainsText( "<testcase name=\"test(TestInfo)\" "
+ "classname=\"junitplatformenginejupiter.BasicJupiterTest\"" )
- .assertContainsText( "<testcase name=\"0 + 1 = 1\" "
+ .assertContainsText( "<testcase name=\"add(int, int, int)[1] 0 + 1 = 1\" "
+ + "classname=\"junitplatformenginejupiter.BasicJupiterTest\"" )
+ .assertContainsText( "<testcase name=\"add(int, int, int)[2] 1 + 2 = 3\" "
+ + "classname=\"junitplatformenginejupiter.BasicJupiterTest\"" )
+ .assertContainsText( "<testcase name=\"add(int, int, int)[3] 49 + 51 = 100\" "
+ + "classname=\"junitplatformenginejupiter.BasicJupiterTest\"" )
+ .assertContainsText( "<testcase name=\"add(int, int, int)[4] 1 + 100 = 101\" "
+ + "classname=\"junitplatformenginejupiter.BasicJupiterTest\"" )
+ .assertContainsText( "<testcase name=\"square(int, int)[1] 1, 1\" "
+ + "classname=\"junitplatformenginejupiter.BasicJupiterTest\"" )
+ .assertContainsText( "<testcase name=\"square(int, int)[2] 2, 4\" "
+ + "classname=\"junitplatformenginejupiter.BasicJupiterTest\"" )
+ .assertContainsText( "<testcase name=\"square(int, int)[3] 3, 9\" "
+ "classname=\"junitplatformenginejupiter.BasicJupiterTest\"" )
- .assertContainsText( "<testcase name=\"1 + 2 = 3\" "
Review comment:
I will rewrite the PR, so that it does not change existing ITs. Thanks for your feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] andpab commented on a change in pull request #351: [SUREFIRE-1914] Draft: Document expected XML report format for @ParameterizedTest with ITs
Posted by GitBox <gi...@apache.org>.
andpab commented on a change in pull request #351:
URL: https://github.com/apache/maven-surefire/pull/351#discussion_r633899244
##########
File path: surefire-its/src/test/java/org/apache/maven/surefire/its/JUnitPlatformEnginesIT.java
##########
@@ -395,28 +396,46 @@ public void testJupiterEngineWithDisplayNames()
.assertContainsText( "<< ✨ >>" );
validator.getSurefireReportsFile( "junitplatformenginejupiter.DisplayNameTest-output.txt", UTF_8 )
- .assertContainsText( "73$71 ✔" );
-
- validator.getSurefireReportsFile( "junitplatformenginejupiter.DisplayNameTest-output.txt", UTF_8 )
- .assertContainsText( "73$72 ✔" );
+ .assertContainsText( "73$71 ✔" )
+ .assertContainsText( "73$72 ✔" )
+ .assertContainsText( "73$73 ✔" )
+ .assertContainsText( "73$74 ✔" );
validator.getSurefireReportsFile( "TEST-junitplatformenginejupiter.DisplayNameTest.xml", UTF_8 )
.assertContainsText( "testcase name=\"73$71 ✔\" classname=\"<< ✨ >>\"" )
.assertContainsText( "testcase name=\"73$72 ✔\" classname=\"<< ✨ >>\"" )
+ .assertContainsText( "testcase name=\"73$73 ✔ [1] a\" classname=\"<< ✨ >>\"" )
+ .assertContainsText( "testcase name=\"73$73 ✔ [2] b\" classname=\"<< ✨ >>\"" )
+ .assertContainsText( "testcase name=\"73$73 ✔ [3] c\" classname=\"<< ✨ >>\"" )
+ .assertContainsText( "testcase name=\"73$74 ✔ [1] a\" classname=\"<< ✨ >>\"" )
+ .assertContainsText( "testcase name=\"73$74 ✔ [2] b\" classname=\"<< ✨ >>\"" )
+ .assertContainsText( "testcase name=\"73$74 ✔ [3] c\" classname=\"<< ✨ >>\"" )
.assertContainsText( XML_TESTSUITE_FRAGMENT );
validator.getSurefireReportsFile( "TEST-junitplatformenginejupiter.BasicJupiterTest.xml", UTF_8 )
.assertContainsText( "<testcase name=\"test(TestInfo)\" "
+ "classname=\"junitplatformenginejupiter.BasicJupiterTest\"" )
- .assertContainsText( "<testcase name=\"0 + 1 = 1\" "
+ .assertContainsText( "<testcase name=\"add(int, int, int)[1] 0 + 1 = 1\" "
+ + "classname=\"junitplatformenginejupiter.BasicJupiterTest\"" )
+ .assertContainsText( "<testcase name=\"add(int, int, int)[2] 1 + 2 = 3\" "
+ + "classname=\"junitplatformenginejupiter.BasicJupiterTest\"" )
+ .assertContainsText( "<testcase name=\"add(int, int, int)[3] 49 + 51 = 100\" "
+ + "classname=\"junitplatformenginejupiter.BasicJupiterTest\"" )
+ .assertContainsText( "<testcase name=\"add(int, int, int)[4] 1 + 100 = 101\" "
+ + "classname=\"junitplatformenginejupiter.BasicJupiterTest\"" )
+ .assertContainsText( "<testcase name=\"square(int, int)[1] 1, 1\" "
+ + "classname=\"junitplatformenginejupiter.BasicJupiterTest\"" )
+ .assertContainsText( "<testcase name=\"square(int, int)[2] 2, 4\" "
+ + "classname=\"junitplatformenginejupiter.BasicJupiterTest\"" )
+ .assertContainsText( "<testcase name=\"square(int, int)[3] 3, 9\" "
+ "classname=\"junitplatformenginejupiter.BasicJupiterTest\"" )
- .assertContainsText( "<testcase name=\"1 + 2 = 3\" "
Review comment:
Rewrote it, so that only a new dedicated test project and IT for it is added.
Test project: surefire-1914-xml-reporting-parameterizedtest
IT: Surefire1914XmlReportingParameterizedTestIT.java
Please have a look again.
For reference: The relevant pre-existing IT with a divergent expectation is JUnitPlatformEnginesIT#testJupiterEngineWithDisplayNames
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #351: [SUREFIRE-1914] Draft: Document expected XML report format for @ParameterizedTest with ITs
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on a change in pull request #351:
URL: https://github.com/apache/maven-surefire/pull/351#discussion_r638232837
##########
File path: surefire-its/src/test/resources/surefire-1914-xml-reporting-parameterizedtest/pom.xml
##########
@@ -0,0 +1,110 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+ -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <groupId>org.apache.maven.plugins.surefire</groupId>
+ <artifactId>surefire-1914-xml-reporting-parameterizedtest</artifactId>
+ <version>1.0</version>
+ <name>Test for: JUnit5Xml30StatelessReporter and Parameterized (SUREFIRE-1914)</name>
+
+ <properties>
+ <maven.compiler.source>1.8</maven.compiler.source>
+ <maven.compiler.target>1.8</maven.compiler.target>
+ <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
+ </properties>
+
+ <!--
+ Declare "junit-jupiter-engine" dependency because the
+ Jupiter Engine is needed at test runtime. Artifacts
+ needed for test compilation, like "junit-jupiter-api",
+ are pulled-in via transitive dependency resolution.
+ -->
+ <dependencies>
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-engine</artifactId>
+ <version>${junit5.version}</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-params</artifactId>
+ <version>${junit5.version}</version>
+ <scope>test</scope>
+ </dependency>
+ </dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <artifactId>maven-compiler-plugin</artifactId>
+ <version>3.8.0</version>
+ <configuration>
+ <encoding>UTF-8</encoding>
+ </configuration>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <version>${surefire.version}</version>
+ <configuration>
+ <forkCount>1.0C</forkCount>
+ <redirectTestOutputToFile>true</redirectTestOutputToFile>
+ <statelessTestsetReporter implementation="org.apache.maven.plugin.surefire.extensions.junit5.JUnit5Xml30StatelessReporter">
+ <disable>false</disable>
+ <version>3.0</version>
+ <usePhrasedFileName>false</usePhrasedFileName>
+ <usePhrasedTestSuiteClassName>true</usePhrasedTestSuiteClassName>
+ <usePhrasedTestCaseClassName>true</usePhrasedTestCaseClassName>
+ <usePhrasedTestCaseMethodName>true</usePhrasedTestCaseMethodName>
+ </statelessTestsetReporter>
+ <consoleOutputReporter implementation="org.apache.maven.plugin.surefire.extensions.junit5.JUnit5ConsoleOutputReporter">
+ <disable>false</disable>
+ <encoding>UTF-8</encoding>
+ <usePhrasedFileName>false</usePhrasedFileName>
+ </consoleOutputReporter>
+ <statelessTestsetInfoReporter implementation="org.apache.maven.plugin.surefire.extensions.junit5.JUnit5StatelessTestsetInfoReporter">
+ <disable>false</disable>
+ <usePhrasedFileName>false</usePhrasedFileName>
+ <usePhrasedClassNameInRunning>true</usePhrasedClassNameInRunning>
+ <usePhrasedClassNameInTestCaseSummary>true</usePhrasedClassNameInTestCaseSummary>
+ </statelessTestsetInfoReporter>
+ </configuration>
+ </plugin>
+ </plugins>
+ </build>
+
+ <repositories>
Review comment:
ok, I am trying to build your project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 closed pull request #351: [SUREFIRE-1914] Draft: Document expected XML report format for @ParameterizedTest with ITs
Posted by GitBox <gi...@apache.org>.
Tibor17 closed pull request #351:
URL: https://github.com/apache/maven-surefire/pull/351
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] andpab commented on pull request #351: [SUREFIRE-1914] Draft: Document expected XML report format for @ParameterizedTest with ITs
Posted by GitBox <gi...@apache.org>.
andpab commented on pull request #351:
URL: https://github.com/apache/maven-surefire/pull/351#issuecomment-848590418
Ok, I've given it a shot. Opened a second draft PR: https://github.com/apache/maven-surefire/pull/352
Please give me some feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] andpab commented on a change in pull request #351: [SUREFIRE-1914] Draft: Document expected XML report format for @ParameterizedTest with ITs
Posted by GitBox <gi...@apache.org>.
andpab commented on a change in pull request #351:
URL: https://github.com/apache/maven-surefire/pull/351#discussion_r633348741
##########
File path: surefire-its/src/test/java/org/apache/maven/surefire/its/JUnitPlatformEnginesIT.java
##########
@@ -395,28 +396,46 @@ public void testJupiterEngineWithDisplayNames()
.assertContainsText( "<< ✨ >>" );
validator.getSurefireReportsFile( "junitplatformenginejupiter.DisplayNameTest-output.txt", UTF_8 )
- .assertContainsText( "73$71 ✔" );
-
- validator.getSurefireReportsFile( "junitplatformenginejupiter.DisplayNameTest-output.txt", UTF_8 )
- .assertContainsText( "73$72 ✔" );
+ .assertContainsText( "73$71 ✔" )
+ .assertContainsText( "73$72 ✔" )
+ .assertContainsText( "73$73 ✔" )
+ .assertContainsText( "73$74 ✔" );
validator.getSurefireReportsFile( "TEST-junitplatformenginejupiter.DisplayNameTest.xml", UTF_8 )
.assertContainsText( "testcase name=\"73$71 ✔\" classname=\"<< ✨ >>\"" )
.assertContainsText( "testcase name=\"73$72 ✔\" classname=\"<< ✨ >>\"" )
+ .assertContainsText( "testcase name=\"73$73 ✔ [1] a\" classname=\"<< ✨ >>\"" )
+ .assertContainsText( "testcase name=\"73$73 ✔ [2] b\" classname=\"<< ✨ >>\"" )
+ .assertContainsText( "testcase name=\"73$73 ✔ [3] c\" classname=\"<< ✨ >>\"" )
+ .assertContainsText( "testcase name=\"73$74 ✔ [1] a\" classname=\"<< ✨ >>\"" )
+ .assertContainsText( "testcase name=\"73$74 ✔ [2] b\" classname=\"<< ✨ >>\"" )
+ .assertContainsText( "testcase name=\"73$74 ✔ [3] c\" classname=\"<< ✨ >>\"" )
.assertContainsText( XML_TESTSUITE_FRAGMENT );
validator.getSurefireReportsFile( "TEST-junitplatformenginejupiter.BasicJupiterTest.xml", UTF_8 )
.assertContainsText( "<testcase name=\"test(TestInfo)\" "
+ "classname=\"junitplatformenginejupiter.BasicJupiterTest\"" )
- .assertContainsText( "<testcase name=\"0 + 1 = 1\" "
+ .assertContainsText( "<testcase name=\"add(int, int, int)[1] 0 + 1 = 1\" "
+ + "classname=\"junitplatformenginejupiter.BasicJupiterTest\"" )
+ .assertContainsText( "<testcase name=\"add(int, int, int)[2] 1 + 2 = 3\" "
+ + "classname=\"junitplatformenginejupiter.BasicJupiterTest\"" )
+ .assertContainsText( "<testcase name=\"add(int, int, int)[3] 49 + 51 = 100\" "
+ + "classname=\"junitplatformenginejupiter.BasicJupiterTest\"" )
+ .assertContainsText( "<testcase name=\"add(int, int, int)[4] 1 + 100 = 101\" "
+ + "classname=\"junitplatformenginejupiter.BasicJupiterTest\"" )
+ .assertContainsText( "<testcase name=\"square(int, int)[1] 1, 1\" "
+ + "classname=\"junitplatformenginejupiter.BasicJupiterTest\"" )
+ .assertContainsText( "<testcase name=\"square(int, int)[2] 2, 4\" "
+ + "classname=\"junitplatformenginejupiter.BasicJupiterTest\"" )
+ .assertContainsText( "<testcase name=\"square(int, int)[3] 3, 9\" "
+ "classname=\"junitplatformenginejupiter.BasicJupiterTest\"" )
- .assertContainsText( "<testcase name=\"1 + 2 = 3\" "
Review comment:
I will rewrite the PR, so that it does not change existing ITs. Thanks for your feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #351: [SUREFIRE-1914] Draft: Document expected XML report format for @ParameterizedTest with ITs
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on a change in pull request #351:
URL: https://github.com/apache/maven-surefire/pull/351#discussion_r637404894
##########
File path: surefire-its/src/test/resources/surefire-1914-xml-reporting-parameterizedtest/pom.xml
##########
@@ -0,0 +1,110 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+ -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <groupId>org.apache.maven.plugins.surefire</groupId>
+ <artifactId>surefire-1914-xml-reporting-parameterizedtest</artifactId>
+ <version>1.0</version>
+ <name>Test for: JUnit5Xml30StatelessReporter and Parameterized (SUREFIRE-1914)</name>
+
+ <properties>
+ <maven.compiler.source>1.8</maven.compiler.source>
+ <maven.compiler.target>1.8</maven.compiler.target>
+ <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
+ </properties>
+
+ <!--
+ Declare "junit-jupiter-engine" dependency because the
+ Jupiter Engine is needed at test runtime. Artifacts
+ needed for test compilation, like "junit-jupiter-api",
+ are pulled-in via transitive dependency resolution.
+ -->
+ <dependencies>
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-engine</artifactId>
+ <version>${junit5.version}</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-params</artifactId>
+ <version>${junit5.version}</version>
+ <scope>test</scope>
+ </dependency>
+ </dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <artifactId>maven-compiler-plugin</artifactId>
+ <version>3.8.0</version>
+ <configuration>
+ <encoding>UTF-8</encoding>
+ </configuration>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <version>${surefire.version}</version>
+ <configuration>
+ <forkCount>1.0C</forkCount>
+ <redirectTestOutputToFile>true</redirectTestOutputToFile>
+ <statelessTestsetReporter implementation="org.apache.maven.plugin.surefire.extensions.junit5.JUnit5Xml30StatelessReporter">
+ <disable>false</disable>
+ <version>3.0</version>
+ <usePhrasedFileName>false</usePhrasedFileName>
+ <usePhrasedTestSuiteClassName>true</usePhrasedTestSuiteClassName>
+ <usePhrasedTestCaseClassName>true</usePhrasedTestCaseClassName>
+ <usePhrasedTestCaseMethodName>true</usePhrasedTestCaseMethodName>
+ </statelessTestsetReporter>
+ <consoleOutputReporter implementation="org.apache.maven.plugin.surefire.extensions.junit5.JUnit5ConsoleOutputReporter">
+ <disable>false</disable>
+ <encoding>UTF-8</encoding>
+ <usePhrasedFileName>false</usePhrasedFileName>
+ </consoleOutputReporter>
+ <statelessTestsetInfoReporter implementation="org.apache.maven.plugin.surefire.extensions.junit5.JUnit5StatelessTestsetInfoReporter">
+ <disable>false</disable>
+ <usePhrasedFileName>false</usePhrasedFileName>
+ <usePhrasedClassNameInRunning>true</usePhrasedClassNameInRunning>
+ <usePhrasedClassNameInTestCaseSummary>true</usePhrasedClassNameInTestCaseSummary>
+ </statelessTestsetInfoReporter>
+ </configuration>
+ </plugin>
+ </plugins>
+ </build>
+
+ <repositories>
Review comment:
Pls remove the `repository`. Our build uses the artifacts from your local repo. It means the integration tests expect `mvn install` which packages and installs the project artifacts in your local repo on your disk. Pls run
```
mvn install -DskipTests
mvn verify -rf :surefire-its -nsu -P run-its -Dit.test=Surefire1914XmlReportingParameterizedTestIT
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #351: [SUREFIRE-1914] Draft: Document expected XML report format for @ParameterizedTest with ITs
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on a change in pull request #351:
URL: https://github.com/apache/maven-surefire/pull/351#discussion_r633134321
##########
File path: surefire-its/src/test/java/org/apache/maven/surefire/its/JUnitPlatformEnginesIT.java
##########
@@ -395,28 +396,46 @@ public void testJupiterEngineWithDisplayNames()
.assertContainsText( "<< ✨ >>" );
validator.getSurefireReportsFile( "junitplatformenginejupiter.DisplayNameTest-output.txt", UTF_8 )
- .assertContainsText( "73$71 ✔" );
-
- validator.getSurefireReportsFile( "junitplatformenginejupiter.DisplayNameTest-output.txt", UTF_8 )
- .assertContainsText( "73$72 ✔" );
+ .assertContainsText( "73$71 ✔" )
+ .assertContainsText( "73$72 ✔" )
+ .assertContainsText( "73$73 ✔" )
+ .assertContainsText( "73$74 ✔" );
validator.getSurefireReportsFile( "TEST-junitplatformenginejupiter.DisplayNameTest.xml", UTF_8 )
.assertContainsText( "testcase name=\"73$71 ✔\" classname=\"<< ✨ >>\"" )
.assertContainsText( "testcase name=\"73$72 ✔\" classname=\"<< ✨ >>\"" )
+ .assertContainsText( "testcase name=\"73$73 ✔ [1] a\" classname=\"<< ✨ >>\"" )
+ .assertContainsText( "testcase name=\"73$73 ✔ [2] b\" classname=\"<< ✨ >>\"" )
+ .assertContainsText( "testcase name=\"73$73 ✔ [3] c\" classname=\"<< ✨ >>\"" )
+ .assertContainsText( "testcase name=\"73$74 ✔ [1] a\" classname=\"<< ✨ >>\"" )
+ .assertContainsText( "testcase name=\"73$74 ✔ [2] b\" classname=\"<< ✨ >>\"" )
+ .assertContainsText( "testcase name=\"73$74 ✔ [3] c\" classname=\"<< ✨ >>\"" )
.assertContainsText( XML_TESTSUITE_FRAGMENT );
validator.getSurefireReportsFile( "TEST-junitplatformenginejupiter.BasicJupiterTest.xml", UTF_8 )
.assertContainsText( "<testcase name=\"test(TestInfo)\" "
+ "classname=\"junitplatformenginejupiter.BasicJupiterTest\"" )
- .assertContainsText( "<testcase name=\"0 + 1 = 1\" "
+ .assertContainsText( "<testcase name=\"add(int, int, int)[1] 0 + 1 = 1\" "
+ + "classname=\"junitplatformenginejupiter.BasicJupiterTest\"" )
+ .assertContainsText( "<testcase name=\"add(int, int, int)[2] 1 + 2 = 3\" "
+ + "classname=\"junitplatformenginejupiter.BasicJupiterTest\"" )
+ .assertContainsText( "<testcase name=\"add(int, int, int)[3] 49 + 51 = 100\" "
+ + "classname=\"junitplatformenginejupiter.BasicJupiterTest\"" )
+ .assertContainsText( "<testcase name=\"add(int, int, int)[4] 1 + 100 = 101\" "
+ + "classname=\"junitplatformenginejupiter.BasicJupiterTest\"" )
+ .assertContainsText( "<testcase name=\"square(int, int)[1] 1, 1\" "
+ + "classname=\"junitplatformenginejupiter.BasicJupiterTest\"" )
+ .assertContainsText( "<testcase name=\"square(int, int)[2] 2, 4\" "
+ + "classname=\"junitplatformenginejupiter.BasicJupiterTest\"" )
+ .assertContainsText( "<testcase name=\"square(int, int)[3] 3, 9\" "
+ "classname=\"junitplatformenginejupiter.BasicJupiterTest\"" )
- .assertContainsText( "<testcase name=\"1 + 2 = 3\" "
Review comment:
Where is the old method? I cannot see it here in this PR.
I would like to keep it and add new ones because then we have more alternatives. Would it be possible?
Pls check our documentation because sometimes we use the reference pointing to our IT tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] andpab commented on a change in pull request #351: [SUREFIRE-1914] Draft: Document expected XML report format for @ParameterizedTest with ITs
Posted by GitBox <gi...@apache.org>.
andpab commented on a change in pull request #351:
URL: https://github.com/apache/maven-surefire/pull/351#discussion_r639514219
##########
File path: surefire-its/src/test/resources/surefire-1914-xml-reporting-parameterizedtest/pom.xml
##########
@@ -0,0 +1,110 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+ -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <groupId>org.apache.maven.plugins.surefire</groupId>
+ <artifactId>surefire-1914-xml-reporting-parameterizedtest</artifactId>
+ <version>1.0</version>
+ <name>Test for: JUnit5Xml30StatelessReporter and Parameterized (SUREFIRE-1914)</name>
+
+ <properties>
+ <maven.compiler.source>1.8</maven.compiler.source>
+ <maven.compiler.target>1.8</maven.compiler.target>
+ <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
+ </properties>
+
+ <!--
+ Declare "junit-jupiter-engine" dependency because the
+ Jupiter Engine is needed at test runtime. Artifacts
+ needed for test compilation, like "junit-jupiter-api",
+ are pulled-in via transitive dependency resolution.
+ -->
+ <dependencies>
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-engine</artifactId>
+ <version>${junit5.version}</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-params</artifactId>
+ <version>${junit5.version}</version>
+ <scope>test</scope>
+ </dependency>
+ </dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <artifactId>maven-compiler-plugin</artifactId>
+ <version>3.8.0</version>
+ <configuration>
+ <encoding>UTF-8</encoding>
+ </configuration>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <version>${surefire.version}</version>
+ <configuration>
+ <forkCount>1.0C</forkCount>
+ <redirectTestOutputToFile>true</redirectTestOutputToFile>
+ <statelessTestsetReporter implementation="org.apache.maven.plugin.surefire.extensions.junit5.JUnit5Xml30StatelessReporter">
+ <disable>false</disable>
+ <version>3.0</version>
+ <usePhrasedFileName>false</usePhrasedFileName>
+ <usePhrasedTestSuiteClassName>true</usePhrasedTestSuiteClassName>
+ <usePhrasedTestCaseClassName>true</usePhrasedTestCaseClassName>
+ <usePhrasedTestCaseMethodName>true</usePhrasedTestCaseMethodName>
+ </statelessTestsetReporter>
+ <consoleOutputReporter implementation="org.apache.maven.plugin.surefire.extensions.junit5.JUnit5ConsoleOutputReporter">
+ <disable>false</disable>
+ <encoding>UTF-8</encoding>
+ <usePhrasedFileName>false</usePhrasedFileName>
+ </consoleOutputReporter>
+ <statelessTestsetInfoReporter implementation="org.apache.maven.plugin.surefire.extensions.junit5.JUnit5StatelessTestsetInfoReporter">
+ <disable>false</disable>
+ <usePhrasedFileName>false</usePhrasedFileName>
+ <usePhrasedClassNameInRunning>true</usePhrasedClassNameInRunning>
+ <usePhrasedClassNameInTestCaseSummary>true</usePhrasedClassNameInTestCaseSummary>
+ </statelessTestsetInfoReporter>
+ </configuration>
+ </plugin>
+ </plugins>
+ </build>
+
+ <repositories>
Review comment:
@Tibor17 I noticed there were still a couple of inconsistencies in my expectations. I force-pushed some changes. Please checkout anew.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org