You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by minahlee <gi...@git.apache.org> on 2016/07/07 13:51:04 UTC
[GitHub] zeppelin pull request #1148: [ZEPPELIN-1026] set syntax highlight based on d...
GitHub user minahlee opened a pull request:
https://github.com/apache/zeppelin/pull/1148
[ZEPPELIN-1026] set syntax highlight based on default bound interpreter
### What is this PR for?
- Set syntax highlight based on default interpreter if %magic is not set
- Get syntax highlight mode from backend
### What type of PR is it?
Improvement
### Todos
* [ ] Add test
* [ ] Update [writingzeppelininterpreter.md](https://github.com/apache/zeppelin/blob/master/docs/development/writingzeppelininterpreter.md)
* [ ] Rebase after #1145 merged
### What is the Jira issue?
[ZEPPELIN-1026](https://issues.apache.org/jira/browse/ZEPPELIN-1026)
### Screenshots (if appropriate)
**Before**
<img width="665" alt="screen shot 2016-07-07 at 10 46 20 pm" src="https://cloud.githubusercontent.com/assets/8503346/16655312/af67a302-4494-11e6-949e-793ad0515d7a.png">
**After**
<img width="666" alt="screen shot 2016-07-07 at 10 44 39 pm" src="https://cloud.githubusercontent.com/assets/8503346/16655248/769d8ba4-4494-11e6-9b3c-dc5e026e9c53.png">
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? yes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/minahlee/zeppelin ZEPPELIN-1026
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1148.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1148
----
commit ecb0af22df5e31641d87fdbf729c14186c0a56af
Author: Mina Lee <mi...@apache.org>
Date: 2016-07-07T10:12:28Z
Add editor field
commit 32ed3637eedb4ab5ca93f4049bd3c711f0d5634b
Author: Mina Lee <mi...@apache.org>
Date: 2016-07-07T11:42:53Z
Align comments for readability
commit 466e6a860af78e385304d17671edc5ab75d98aeb
Author: Mina Lee <mi...@apache.org>
Date: 2016-07-07T12:17:12Z
Get paragraph editor mode from backend
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1148: [ZEPPELIN-1026] set syntax highlight based on default ...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1148
@minahlee do you think we should close it for now or rename it to WIP?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1148: [ZEPPELIN-1026] set syntax highlight based on default ...
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1148
I think I will create another PR for this so closing it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1148: [ZEPPELIN-1026] set syntax highlight based on d...
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee closed the pull request at:
https://github.com/apache/zeppelin/pull/1148
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1148: [ZEPPELIN-1026] set syntax highlight based on d...
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee closed the pull request at:
https://github.com/apache/zeppelin/pull/1148
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1148: [ZEPPELIN-1026] set syntax highlight based on d...
Posted by minahlee <gi...@git.apache.org>.
GitHub user minahlee reopened a pull request:
https://github.com/apache/zeppelin/pull/1148
[ZEPPELIN-1026] set syntax highlight based on default bound interpreter
### What is this PR for?
- Set syntax highlight based on default interpreter if %magic is not set
- Get syntax highlight mode from backend
### What type of PR is it?
Improvement
### Todos
* [x] Add test
* [x] Update [writingzeppelininterpreter.md](https://github.com/apache/zeppelin/blob/master/docs/development/writingzeppelininterpreter.md)
* [ ] Fix test
* [ ] Test after #1145 merged, modify if necessary
### What is the Jira issue?
[ZEPPELIN-1026](https://issues.apache.org/jira/browse/ZEPPELIN-1026)
### Screenshots (if appropriate)
This is screenshot when the default interpreter set to python interpreter.
**Before**
Has `scala` as syntax highlight language when %python is not set.
<img width="665" alt="screen shot 2016-07-07 at 10 46 20 pm" src="https://cloud.githubusercontent.com/assets/8503346/16655312/af67a302-4494-11e6-949e-793ad0515d7a.png">
**After**
Has `python` as syntax highlight language even when %python is not set.
<img width="666" alt="screen shot 2016-07-07 at 10 44 39 pm" src="https://cloud.githubusercontent.com/assets/8503346/16655248/769d8ba4-4494-11e6-9b3c-dc5e026e9c53.png">
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? yes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/minahlee/zeppelin ZEPPELIN-1026
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1148.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1148
----
commit ecb0af22df5e31641d87fdbf729c14186c0a56af
Author: Mina Lee <mi...@apache.org>
Date: 2016-07-07T10:12:28Z
Add editor field
commit 32ed3637eedb4ab5ca93f4049bd3c711f0d5634b
Author: Mina Lee <mi...@apache.org>
Date: 2016-07-07T11:42:53Z
Align comments for readability
commit 466e6a860af78e385304d17671edc5ab75d98aeb
Author: Mina Lee <mi...@apache.org>
Date: 2016-07-07T12:17:12Z
Get paragraph editor mode from backend
commit 04fe1fafe3985405233d892f446b9ea303ca9f78
Author: Mina Lee <mi...@apache.org>
Date: 2016-07-07T14:15:53Z
[DOC] Setting syntax highlight when writing new interpreter
commit 1fb2e175907fa4b8568692604eac2c45aa405d3d
Author: Mina Lee <mi...@apache.org>
Date: 2016-07-07T17:04:34Z
Add unit test for editor setting
commit 6535dd49811cf50eb2d099f06663ad10760fa91c
Author: Mina Lee <mi...@apache.org>
Date: 2016-07-07T23:11:12Z
Fix test
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---