You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by "Jason Gustafson (Jira)" <ji...@apache.org> on 2020/05/01 22:31:00 UTC

[jira] [Resolved] (KAFKA-9939) Fetch request metrics are updated twice for delayed fetches

     [ https://issues.apache.org/jira/browse/KAFKA-9939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Gustafson resolved KAFKA-9939.
------------------------------------
    Fix Version/s: 2.6.0
       Resolution: Fixed

> Fetch request metrics are updated twice for delayed fetches
> -----------------------------------------------------------
>
>                 Key: KAFKA-9939
>                 URL: https://issues.apache.org/jira/browse/KAFKA-9939
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Jason Gustafson
>            Assignee: Jason Gustafson
>            Priority: Major
>             Fix For: 2.6.0
>
>
> We track fetch request rate metrics in `BrokerTopicStats`. We have both topic level and total metrics. Currently these values are updated in `ReplicaManager.readFromLocalLog`. Inside `fetchMessages`, we invoke `readFromLocalLog` first to see if the fetch can be immediately satisfied. If not, then we put it in purgatory. After completing purgatory, we make a second call to `readFromLocalLog` which will again update the request rate metrics. Hence we are overcounting the fetch request rate.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)