You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/08/23 06:59:32 UTC

[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #5595: Implement performing row-level delta to branches

amogh-jahagirdar commented on code in PR #5595:
URL: https://github.com/apache/iceberg/pull/5595#discussion_r952222322


##########
core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java:
##########
@@ -451,8 +537,10 @@ private void validateNoNewDeletesForDataFiles(
   }
 
   /**
-   * Validates that no delete files matching a filter have been added to the table since a starting
-   * snapshot.
+   * ToDo: Remove after branch writing implementation complete

Review Comment:
   We can remove the existing validate after we implement the different write operations because we will always have an ending snapshot.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org