You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/06 12:02:35 UTC
[GitHub] [skywalking-cli] kezhenxu94 opened a new pull request #30: [Feature] Support multiple linear metrics and enhance Ascii Graph Dis…
kezhenxu94 opened a new pull request #30: [Feature] Support multiple linear metrics and enhance Ascii Graph Dis…
URL: https://github.com/apache/skywalking-cli/pull/30
…play
### Motivation
Adopt the new API of multiple linear metrics, https://github.com/apache/skywalking/pull/4214
### Modification
- Rewrite the pxx metrics with the new API
- Slightly refactor the GraphQL client into individual package, according to the query protocol
- Enhance the Ascii Graph display style
### Result
- CLI is compatible with the latest backend
- Ascii Graph can display multiple charts in one screen
- Closes https://github.com/apache/skywalking/issues/4436
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] wu-sheng merged pull request #30: [Feature] Support multiple linear metrics and enhance Ascii Graph Dis…
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #30: [Feature] Support multiple linear metrics and enhance Ascii Graph Dis…
URL: https://github.com/apache/skywalking-cli/pull/30
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] kezhenxu94 commented on issue #30: [Feature] Support multiple linear metrics and enhance Ascii Graph Dis…
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #30: [Feature] Support multiple linear metrics and enhance Ascii Graph Dis…
URL: https://github.com/apache/skywalking-cli/pull/30#issuecomment-595738929
One screenshot of the multiple linear metrics, other commands remain the same
<img width="1440" alt="image" src="https://user-images.githubusercontent.com/15965696/76082115-9a5a9a80-5fe5-11ea-9e69-3d7148b07c58.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] kezhenxu94 commented on issue #30: [Feature] Support multiple linear metrics and enhance Ascii Graph Dis…
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #30: [Feature] Support multiple linear metrics and enhance Ascii Graph Dis…
URL: https://github.com/apache/skywalking-cli/pull/30#issuecomment-595752241
@wu-sheng added
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-cli] codecov-io commented on issue #30: [Feature] Support multiple linear metrics and enhance Ascii Graph Dis…
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #30: [Feature] Support multiple linear metrics and enhance Ascii Graph Dis…
URL: https://github.com/apache/skywalking-cli/pull/30#issuecomment-595752061
# [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/30?src=pr&el=h1) Report
> Merging [#30](https://codecov.io/gh/apache/skywalking-cli/pull/30?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking-cli/commit/54e683fbadcce4df9932129e8822576afb8e8c09?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `60%`.
[](https://codecov.io/gh/apache/skywalking-cli/pull/30?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #30 +/- ##
=======================================
Coverage 54.45% 54.45%
=======================================
Files 6 6
Lines 101 101
=======================================
Hits 55 55
Misses 39 39
Partials 7 7
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking-cli/pull/30?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [commands/interceptor/duration.go](https://codecov.io/gh/apache/skywalking-cli/pull/30/diff?src=pr&el=tree#diff-Y29tbWFuZHMvaW50ZXJjZXB0b3IvZHVyYXRpb24uZ28=) | `50.98% <60%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/30?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/30?src=pr&el=footer). Last update [54e683f...4c96c3a](https://codecov.io/gh/apache/skywalking-cli/pull/30?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services