You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/11/27 12:06:42 UTC
[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10040: Add OpenSearch 1.3.6 and 2.4.0 to test matrix
wu-sheng commented on code in PR #10040:
URL: https://github.com/apache/skywalking/pull/10040#discussion_r1032919294
##########
oap-server/server-library/library-elasticsearch-client/src/test/java/org/apache/skywalking/library/elasticsearch/ITElasticSearchTest.java:
##########
@@ -104,6 +104,16 @@ public static Collection<Object[]> es() {
"docker.elastic.co/elasticsearch/elasticsearch-oss"))
.withEnv("plugins.security.disabled", "true")
.withStartupTimeout(java.time.Duration.ofMinutes(5))
+ },
+ {
+ "OpenSearch 2.4.0",
Review Comment:
@wankai123 mentioned, we should consider to separating ElasticSearch IT from general ITs, and try to only booting ElasticSearch once per version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org