You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by jo...@gmail.com on 2011/07/14 21:25:29 UTC
Review Request: Don't export deferred symbols when feature doesn't support
this.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1130/
-----------------------------------------------------------
Review request for shindig and Michael Hermanto.
Summary
-------
I missed this important conditional in the first go-around.
Diffs
-----
trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/js/ExportJsProcessorTest.java 1145758
trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/js/ExportJsProcessor.java 1145758
Diff: https://reviews.apache.org/r/1130/diff
Testing
-------
Thanks,
johnfargo
Re: Review Request: Don't export deferred symbols when feature doesn't
support this.
Posted by Ziv Horesh <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1130/#review1064
-----------------------------------------------------------
Ship it!
- Ziv
On 2011-07-14 19:25:29, johnfargo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1130/
> -----------------------------------------------------------
>
> (Updated 2011-07-14 19:25:29)
>
>
> Review request for shindig and Michael Hermanto.
>
>
> Summary
> -------
>
> I missed this important conditional in the first go-around.
>
>
> Diffs
> -----
>
> trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/js/ExportJsProcessorTest.java 1145758
> trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/js/ExportJsProcessor.java 1145758
>
> Diff: https://reviews.apache.org/r/1130/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> johnfargo
>
>