You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/07/09 19:48:49 UTC
[GitHub] [lucene-solr] madrob opened a new pull request #2531: SOLR-15526 Use new cluster for each LeaderTragicEvent test
madrob opened a new pull request #2531:
URL: https://github.com/apache/lucene-solr/pull/2531
https://issues.apache.org/jira/projects/SOLR/issues/SOLR-15526
Not thrilled with this solution, but it seems to work for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dsmiley commented on a change in pull request #2531: SOLR-15526 Use new cluster for each LeaderTragicEvent test
Posted by GitBox <gi...@apache.org>.
dsmiley commented on a change in pull request #2531:
URL: https://github.com/apache/lucene-solr/pull/2531#discussion_r667284070
##########
File path: solr/core/src/test/org/apache/solr/cloud/LeaderTragicEventTest.java
##########
@@ -53,24 +53,21 @@
private String collection;
- @BeforeClass
- public static void setupCluster() throws Exception {
- configureCluster(2)
- .addConfig("config", TEST_PATH().resolve("configsets").resolve("cloud-minimal").resolve("conf"))
- .configure();
- }
-
@Before
public void setUp() throws Exception {
super.setUp();
collection = getSaferTestName();
+ configureCluster(2)
Review comment:
I'd add a comment to say that a shared cluster led to sporadic test-failures. But fine as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] madrob merged pull request #2531: SOLR-15526 Use new cluster for each LeaderTragicEvent test
Posted by GitBox <gi...@apache.org>.
madrob merged pull request #2531:
URL: https://github.com/apache/lucene-solr/pull/2531
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org