[GitHub] [fineract] vorburger commented on issue #685: clean up GLAccountBuilder, following SpotBugs (FINERACT-702)

[GitBox <gi...@apache.org>]

vorburger commented on issue #685:  clean up GLAccountBuilder, following SpotBugs (FINERACT-702) 
URL: https://github.com/apache/fineract/pull/685#issuecomment-573410732
 
 
   > Which one are you merging first. This or #682 ?
   
   #682 just merged, this one was actually just an extension with 1 more additional commit over that one. There's no real good way to do this better in GitHub (that I know of), so what I "imply" (but should say more clearly?) when I raise a PR like this one for review is to manually click on the last commit of such a PR (in the _Commits_ tab) in review that, instead of everything on the _Files changed_ tab (or use that Changes from drop down on _Files changed_ to review only last commit instead of _from all commits_).
   
   > @vorburger thanks very much 
   
   You are the one to thank, this (that we've finally properly adopted SpotBugs here) is amazing!
   
   If this small PR is OK with you, just go ahead and merge it (use _Rebase and merge_ to avoid the merge commit, because #684 is "parallel"). -- PS: I hope this doesn't fail in Integration Test again due to [FINERACT-820](https://issues.apache.org/jira/browse/FINERACT-820) - as it's Sunday...  if it does, we really should figure out how to fix that problem.. or ask on list if anyone would like to take that on.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services