You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by "Veena Basavaraj (JIRA)" <ji...@apache.org> on 2015/03/23 00:46:10 UTC

[jira] [Comment Edited] (SQOOP-2113) Modify REST API for the RU operation on job and link config

    [ https://issues.apache.org/jira/browse/SQOOP-2113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14375224#comment-14375224 ] 

Veena Basavaraj edited comment on SQOOP-2113 at 3/22/15 11:45 PM:
------------------------------------------------------------------

[~jarcec] I would appreciate a quick look at this comment and the sub ticket of SQOOP-2113 patch

One of the reasons it took me a while to figure out what the best way to handle this use case.

Currently we do this when adding inputs, i.e if a value is null we never add it. 

At a later point, editing this config obviously will fail.

Do we really have a strong reason to do this ? In my experience, a record should have been created no matter what the value is.

{code}
          // Skip empty values as we're not interested in storing those in db
          if (input.isEmpty()) {
            continue;
          }

{code}


was (Author: vybs):
One of the reasons it took me a while to figure out what the best way to handle this use case.

Currently we do this when adding inputs, i.e if a value is null we never add it. 

At a later point, editing this config obviously will fail.

Do we really have a strong reason to do this ? In my experience, a record should have been created no matter what the value is.

{code}
          // Skip empty values as we're not interested in storing those in db
          if (input.isEmpty()) {
            continue;
          }

{code}

> Modify REST API for the RU operation on job and link config
> -----------------------------------------------------------
>
>                 Key: SQOOP-2113
>                 URL: https://issues.apache.org/jira/browse/SQOOP-2113
>             Project: Sqoop
>          Issue Type: Bug
>            Reporter: Veena Basavaraj
>            Assignee: Veena Basavaraj
>             Fix For: 1.99.6
>
>         Attachments: SQOOP-2113-1.patch
>
>
> based on the design doc for 1516, support the RU operation on configs for rest



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)