You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Pankraz76 (via GitHub)" <gi...@apache.org> on 2025/05/03 08:37:14 UTC
[PR] #200 [core] Migrate to Java 21 [maven-build-cache-extension]
Pankraz76 opened a new pull request, #211:
URL: https://github.com/apache/maven-build-cache-extension/pull/211
- https://github.com/apache/maven-pmd-plugin/pull/201
- https://github.com/apache/maven-pmd-plugin/pull/201#issuecomment-2848187270
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Your pull request should address just one issue, without pulling in other changes.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
Note that commits might be squashed by a maintainer on merge.
- [ ] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
- [ ] Run `mvn verify` to make sure basic checks pass.
A more thorough check will be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] #211 [core] `Migrate to Java 21` [maven-build-cache-extension]
Posted by "Pankraz76 (via GitHub)" <gi...@apache.org>.
Pankraz76 commented on code in PR #211:
URL: https://github.com/apache/maven-build-cache-extension/pull/211#discussion_r2072464627
##########
.github/workflows/maven-verify.yml:
##########
@@ -29,6 +29,6 @@ jobs:
maven-args: '-D"maven.test.redirectTestOutputToFile=false"'
maven-matrix: '[ "3.9.9", "4.0.0-rc-3" ]'
maven4-enabled: true
- matrix-exclude: '[ {"jdk": "8"} ]'
+ matrix-exclude: '[ {"jdk": "21"} ]'
Review Comment:
sorry im replacing 8 with 21 in hope with bump but this makes no sense yes. sorry will revert
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] #211 [core] `Migrate to Java 21` [maven-build-cache-extension]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #211:
URL: https://github.com/apache/maven-build-cache-extension/pull/211#discussion_r2072461022
##########
.github/workflows/maven-verify.yml:
##########
@@ -29,6 +29,6 @@ jobs:
maven-args: '-D"maven.test.redirectTestOutputToFile=false"'
maven-matrix: '[ "3.9.9", "4.0.0-rc-3" ]'
maven4-enabled: true
- matrix-exclude: '[ {"jdk": "8"} ]'
+ matrix-exclude: '[ {"jdk": "21"} ]'
Review Comment:
Why you want to exclude build on JDK 21 ... when you want migrate to 21?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] #211 [core] `Migrate to Java 21` [maven-build-cache-extension]
Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on PR #211:
URL: https://github.com/apache/maven-build-cache-extension/pull/211#issuecomment-2848529776
I would say I'm a bit sceptical here.
What is the added value, except for preventing people stuck with 17, from using the cache?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] #211 [core] `Migrate to Java 21` [maven-build-cache-extension]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #211:
URL: https://github.com/apache/maven-build-cache-extension/pull/211#issuecomment-2869657014
> @Pankraz76
>
> > If we want to push PMD, we need this here.
>
> Can you explain this? You can build/run PMD also with Java 21 without any changes. PMD itself has also not decided yet when to move on from Java 8... so. Not sure what's your motivation here...
Wasting our time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] #211 [core] `Migrate to Java 21` [maven-build-cache-extension]
Posted by "Pankraz76 (via GitHub)" <gi...@apache.org>.
Pankraz76 commented on PR #211:
URL: https://github.com/apache/maven-build-cache-extension/pull/211#issuecomment-2848785781
> Nobody stops you from using 21 at runtime. What is the point having it at build time?
> new language features like record patterns and string templates.
yes the benefit might be small then. Its then even more a low hanging fruit then and worth to align?
Im sure you have good reasons, not to do so yet.
As its seems not a big deal, aligning now might be simpler then doing it later on with a bigger version increasing in impact and risk.
Until the 21 migration is making changes, I would consider the migration not fully completed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] #211 [core] `Migrate to Java 21` [maven-build-cache-extension]
Posted by "Pankraz76 (via GitHub)" <gi...@apache.org>.
Pankraz76 closed pull request #211: #211 [core] `Migrate to Java 21`
URL: https://github.com/apache/maven-build-cache-extension/pull/211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] #211 [core] `Migrate to Java 21` [maven-build-cache-extension]
Posted by "Pankraz76 (via GitHub)" <gi...@apache.org>.
Pankraz76 commented on PR #211:
URL: https://github.com/apache/maven-build-cache-extension/pull/211#issuecomment-2869897703
> @Pankraz76
>
> > If we want to push PMD, we need this here.
>
> Can you explain this? You can build/run PMD also with Java 21 without any changes. PMD itself has also not decided yet when to move on from Java 8... so. Not sure what's your motivation here...
While POC in
- https://github.com/pmd/pmd/pull/5714
the issue occurred, assuming the migration needed to be done here prior.
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-pmd-plugin:3.26.0:pmd (pmd-main) on project pmd-core: Failed to determine whether report can be generated: Unsupported targetJdk value '1.21'. -> [Help 1]
> Wasting our time.
yes, as this was ment just as an tryout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] #211 [core] `Migrate to Java 21` [maven-build-cache-extension]
Posted by "adangel (via GitHub)" <gi...@apache.org>.
adangel commented on PR #211:
URL: https://github.com/apache/maven-build-cache-extension/pull/211#issuecomment-2869655641
@Pankraz76
> If we want to push PMD, we need this here.
Can you explain this? You can build/run PMD also with Java 21 without any changes. PMD itself has also not decided yet when to move on from Java 8... so. Not sure what's your motivation here...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] #211 [core] `Migrate to Java 21` [maven-build-cache-extension]
Posted by "Pankraz76 (via GitHub)" <gi...@apache.org>.
Pankraz76 commented on PR #211:
URL: https://github.com/apache/maven-build-cache-extension/pull/211#issuecomment-2848547747
- https://github.com/pmd/pmd/pull/5714
- https://github.com/checkstyle/checkstyle/issues/16981#issuecomment-2841063249
> Java 21 brings significant improvements, including enhanced performance, security updates, and new language features like record patterns and string templates.
If we want to push PMD, we need this here.
**Security updates** are always a good thing.
It’s about being up to date and not getting stuck, like you mentioned. It’s not mandatory to do right now, but we have to move on sooner or later.
Assuming it’s only 17 to 21, the distance is not so big. Of course, it’s only my opinion, and you need to verify. But not being outdated is kind of a best practice, so it’s just a "when," not an "if," right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] #211 [core] `Migrate to Java 21` [maven-build-cache-extension]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #211:
URL: https://github.com/apache/maven-build-cache-extension/pull/211#issuecomment-2848782189
Nobody stops you from using 21 at runtime. What is the point having it at build time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org