[GitHub] [iceberg] flyrain commented on a change in pull request #2520: Core: add key_metadata in ManifestFile

[GitBox <gi...@apache.org>]

flyrain commented on a change in pull request #2520:
URL: https://github.com/apache/iceberg/pull/2520#discussion_r622595167



##########
File path: core/src/main/java/org/apache/iceberg/GenericManifestFile.java
##########
@@ -58,6 +60,7 @@
   private Long existingRowsCount = null;
   private Long deletedRowsCount = null;
   private PartitionFieldSummary[] partitions = null;
+  private byte[] keyMetadata = null;

Review comment:
       A nit: We don't have to initialize a variable in Java, but since all others do the same thing. It should be fine to be consistent here. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org