You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/06 11:51:00 UTC

[GitHub] [airflow] michalmisiewicz commented on a change in pull request #11970: Unify user session lifetime configuration

michalmisiewicz commented on a change in pull request #11970:
URL: https://github.com/apache/airflow/pull/11970#discussion_r518702661



##########
File path: airflow/www/app.py
##########
@@ -66,8 +66,20 @@ def create_app(config=None, testing=False, app_name="Airflow"):
     flask_app = Flask(__name__)
     flask_app.secret_key = conf.get('webserver', 'SECRET_KEY')
 
-    session_lifetime_days = conf.getint('webserver', 'SESSION_LIFETIME_DAYS', fallback=30)
-    flask_app.config['PERMANENT_SESSION_LIFETIME'] = timedelta(days=session_lifetime_days)
+    default_session_lifetime_minutes = 43200
+    if conf.has_option('webserver', 'SESSION_LIFETIME_MINUTES'):
+        session_lifetime_minutes = conf.getint('webserver', 'SESSION_LIFETIME_MINUTES',
+                                               fallback=default_session_lifetime_minutes)
+    else:
+        warnings.warn('`SESSION_LIFETIME_DAYS` option from `webserver` section has been '

Review comment:
       @XD-DENG @mik-laj Sorry I was busy. I agree with @XD-DENG.  We should stop app when we detect removed options in configuration.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org