You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Ramesh Mani <rm...@hortonworks.com> on 2020/06/26 15:09:03 UTC
Review Request 72622: RANGER-2874:Tag policies not getting enforced
for ADLS path
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72622/
-----------------------------------------------------------
Review request for ranger, Abhay Kulkarni and Madhan Neethiraj.
Bugs: RANGER-2874
https://issues.apache.org/jira/browse/RANGER-2874
Repository: ranger
Description
-------
RANGER-2874:Tag policies not getting enforced for ADLS path
Diffs
-----
tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasAdlsResourceMapper.java 120b925
Diff: https://reviews.apache.org/r/72622/diff/1/
Testing
-------
Testing done in local vm for Tag based policy enforment on adls paths
Thanks,
Ramesh Mani
Re: Review Request 72622: RANGER-2874:Tag policies not getting
enforced for ADLS path
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72622/#review221079
-----------------------------------------------------------
Ship it!
Ship It!
- Abhay Kulkarni
On June 26, 2020, 3:09 p.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72622/
> -----------------------------------------------------------
>
> (Updated June 26, 2020, 3:09 p.m.)
>
>
> Review request for ranger, Abhay Kulkarni and Madhan Neethiraj.
>
>
> Bugs: RANGER-2874
> https://issues.apache.org/jira/browse/RANGER-2874
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-2874:Tag policies not getting enforced for ADLS path
>
>
> Diffs
> -----
>
> tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasAdlsResourceMapper.java 120b925
>
>
> Diff: https://reviews.apache.org/r/72622/diff/1/
>
>
> Testing
> -------
>
> Testing done in local vm for Tag based policy enforment on adls paths
>
>
> Thanks,
>
> Ramesh Mani
>
>
Re: Review Request 72622: RANGER-2874:Tag policies not getting
enforced for ADLS path
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72622/#review221076
-----------------------------------------------------------
tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasAdlsResourceMapper.java
Lines 104 (patched)
<https://reviews.apache.org/r/72622/#comment309889>
Please consider a case where relativePath is "//". In that case, at line 108, value of relativePath will be empty string. Please review if this condition can occur and update accordingly.
- Abhay Kulkarni
On June 26, 2020, 3:09 p.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72622/
> -----------------------------------------------------------
>
> (Updated June 26, 2020, 3:09 p.m.)
>
>
> Review request for ranger, Abhay Kulkarni and Madhan Neethiraj.
>
>
> Bugs: RANGER-2874
> https://issues.apache.org/jira/browse/RANGER-2874
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-2874:Tag policies not getting enforced for ADLS path
>
>
> Diffs
> -----
>
> tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasAdlsResourceMapper.java 120b925
>
>
> Diff: https://reviews.apache.org/r/72622/diff/1/
>
>
> Testing
> -------
>
> Testing done in local vm for Tag based policy enforment on adls paths
>
>
> Thanks,
>
> Ramesh Mani
>
>
Re: Review Request 72622: RANGER-2874:Tag policies not getting
enforced for ADLS path
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72622/#review221078
-----------------------------------------------------------
tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasAdlsResourceMapper.java
Lines 104 (patched)
<https://reviews.apache.org/r/72622/#comment309890>
When relativePath is "//", line #105 will set relativePath to "/" - which seems correct.
- Madhan Neethiraj
On June 26, 2020, 3:09 p.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72622/
> -----------------------------------------------------------
>
> (Updated June 26, 2020, 3:09 p.m.)
>
>
> Review request for ranger, Abhay Kulkarni and Madhan Neethiraj.
>
>
> Bugs: RANGER-2874
> https://issues.apache.org/jira/browse/RANGER-2874
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-2874:Tag policies not getting enforced for ADLS path
>
>
> Diffs
> -----
>
> tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasAdlsResourceMapper.java 120b925
>
>
> Diff: https://reviews.apache.org/r/72622/diff/1/
>
>
> Testing
> -------
>
> Testing done in local vm for Tag based policy enforment on adls paths
>
>
> Thanks,
>
> Ramesh Mani
>
>