You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2014/11/13 19:23:09 UTC
Review Request 28000: Bootstaraping and starting agents as non-root
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28000/
-----------------------------------------------------------
Review request for Ambari and Nate Cole.
Bugs: AMBARI-8316
https://issues.apache.org/jira/browse/AMBARI-8316
Repository: ambari
Description
-------
Diffs
-----
ambari-agent/conf/unix/ambari-agent 88fa0b9
ambari-agent/conf/unix/ambari-agent.ini fc76d0e
ambari-agent/etc/init.d/ambari-agent 994ca77
ambari-agent/src/main/python/ambari_agent/AmbariConfig.py ca2e80c
ambari-agent/src/main/python/ambari_agent/main.py 622e86f
ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSRunner.java 3bce55a
ambari-server/src/main/java/org/apache/ambari/server/bootstrap/SshHostInfo.java 34813f4
ambari-server/src/main/python/bootstrap.py bf989d0
ambari-server/src/main/python/setupAgent.py aae5935
Diff: https://reviews.apache.org/r/28000/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 28000: Bootstaraping and starting agents as
non-root
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28000/#review61930
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Nov. 18, 2014, 10:20 a.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28000/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2014, 10:20 a.m.)
>
>
> Review request for Ambari, Dmytro Sen and Nate Cole.
>
>
> Bugs: AMBARI-8316
> https://issues.apache.org/jira/browse/AMBARI-8316
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This does not include deploy with non-root agents, which will be implemented in a separate jira(s).
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/ambari-agent 88fa0b9
> ambari-agent/conf/unix/ambari-agent.ini 41e2895
> ambari-agent/etc/init.d/ambari-agent 994ca77
> ambari-agent/src/main/python/ambari_agent/AgentConfig_linux.py a90b8ba
> ambari-agent/src/main/python/ambari_agent/main.py e43d901
> ambari-agent/src/main/python/ambari_agent/shell.py df6f0ca
> ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSRunner.java 3bce55a
> ambari-server/src/main/java/org/apache/ambari/server/bootstrap/SshHostInfo.java 34813f4
> ambari-server/src/main/python/bootstrap.py bf989d0
> ambari-server/src/main/python/setupAgent.py aae5935
> ambari-server/src/test/python/TestBootstrap.py d0295a2
> ambari-server/src/test/python/TestSetupAgent.py 9ca9e01
>
> Diff: https://reviews.apache.org/r/28000/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 28000: Bootstaraping and starting agents as
non-root
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28000/#review61926
-----------------------------------------------------------
Ship it!
Ship It!
- Dmytro Sen
On Ноя. 18, 2014, 3:20 п.п., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28000/
> -----------------------------------------------------------
>
> (Updated Ноя. 18, 2014, 3:20 п.п.)
>
>
> Review request for Ambari, Dmytro Sen and Nate Cole.
>
>
> Bugs: AMBARI-8316
> https://issues.apache.org/jira/browse/AMBARI-8316
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This does not include deploy with non-root agents, which will be implemented in a separate jira(s).
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/ambari-agent 88fa0b9
> ambari-agent/conf/unix/ambari-agent.ini 41e2895
> ambari-agent/etc/init.d/ambari-agent 994ca77
> ambari-agent/src/main/python/ambari_agent/AgentConfig_linux.py a90b8ba
> ambari-agent/src/main/python/ambari_agent/main.py e43d901
> ambari-agent/src/main/python/ambari_agent/shell.py df6f0ca
> ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSRunner.java 3bce55a
> ambari-server/src/main/java/org/apache/ambari/server/bootstrap/SshHostInfo.java 34813f4
> ambari-server/src/main/python/bootstrap.py bf989d0
> ambari-server/src/main/python/setupAgent.py aae5935
> ambari-server/src/test/python/TestBootstrap.py d0295a2
> ambari-server/src/test/python/TestSetupAgent.py 9ca9e01
>
> Diff: https://reviews.apache.org/r/28000/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 28000: Bootstaraping and starting agents as
non-root
Posted by Andrew Onischuk <ao...@hortonworks.com>.
> On Nov. 18, 2014, 3:27 p.m., Nate Cole wrote:
> > ambari-agent/etc/init.d/ambari-agent, lines 25-27
> > <https://reviews.apache.org/r/28000/diff/4/?file=767025#file767025line25>
> >
> > change to command_prefix. And is the prefix needed when running as root (no bash -c)?
Since the script is ran as bash (#!/usr/bin/env bash), you're right the bash -c is pretty useless. But it's there for some code simplification. Not having any command_prefix there, we had to add "if" everywhere checking if we should add the prefix or not.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28000/#review61925
-----------------------------------------------------------
On Nov. 18, 2014, 3:20 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28000/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2014, 3:20 p.m.)
>
>
> Review request for Ambari, Dmytro Sen and Nate Cole.
>
>
> Bugs: AMBARI-8316
> https://issues.apache.org/jira/browse/AMBARI-8316
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This does not include deploy with non-root agents, which will be implemented in a separate jira(s).
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/ambari-agent 88fa0b9
> ambari-agent/conf/unix/ambari-agent.ini 41e2895
> ambari-agent/etc/init.d/ambari-agent 994ca77
> ambari-agent/src/main/python/ambari_agent/AgentConfig_linux.py a90b8ba
> ambari-agent/src/main/python/ambari_agent/main.py e43d901
> ambari-agent/src/main/python/ambari_agent/shell.py df6f0ca
> ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSRunner.java 3bce55a
> ambari-server/src/main/java/org/apache/ambari/server/bootstrap/SshHostInfo.java 34813f4
> ambari-server/src/main/python/bootstrap.py bf989d0
> ambari-server/src/main/python/setupAgent.py aae5935
> ambari-server/src/test/python/TestBootstrap.py d0295a2
> ambari-server/src/test/python/TestSetupAgent.py 9ca9e01
>
> Diff: https://reviews.apache.org/r/28000/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 28000: Bootstaraping and starting agents as
non-root
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28000/#review61925
-----------------------------------------------------------
Ship it!
ambari-agent/etc/init.d/ambari-agent
<https://reviews.apache.org/r/28000/#comment103860>
change to command_prefix. And is the prefix needed when running as root (no bash -c)?
- Nate Cole
On Nov. 18, 2014, 10:20 a.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28000/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2014, 10:20 a.m.)
>
>
> Review request for Ambari, Dmytro Sen and Nate Cole.
>
>
> Bugs: AMBARI-8316
> https://issues.apache.org/jira/browse/AMBARI-8316
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This does not include deploy with non-root agents, which will be implemented in a separate jira(s).
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/ambari-agent 88fa0b9
> ambari-agent/conf/unix/ambari-agent.ini 41e2895
> ambari-agent/etc/init.d/ambari-agent 994ca77
> ambari-agent/src/main/python/ambari_agent/AgentConfig_linux.py a90b8ba
> ambari-agent/src/main/python/ambari_agent/main.py e43d901
> ambari-agent/src/main/python/ambari_agent/shell.py df6f0ca
> ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSRunner.java 3bce55a
> ambari-server/src/main/java/org/apache/ambari/server/bootstrap/SshHostInfo.java 34813f4
> ambari-server/src/main/python/bootstrap.py bf989d0
> ambari-server/src/main/python/setupAgent.py aae5935
> ambari-server/src/test/python/TestBootstrap.py d0295a2
> ambari-server/src/test/python/TestSetupAgent.py 9ca9e01
>
> Diff: https://reviews.apache.org/r/28000/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 28000: Bootstaraping and starting agents as
non-root
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28000/
-----------------------------------------------------------
(Updated Nov. 18, 2014, 3:20 p.m.)
Review request for Ambari, Dmytro Sen and Nate Cole.
Bugs: AMBARI-8316
https://issues.apache.org/jira/browse/AMBARI-8316
Repository: ambari
Description
-------
This does not include deploy with non-root agents, which will be implemented in a separate jira(s).
Diffs
-----
ambari-agent/conf/unix/ambari-agent 88fa0b9
ambari-agent/conf/unix/ambari-agent.ini 41e2895
ambari-agent/etc/init.d/ambari-agent 994ca77
ambari-agent/src/main/python/ambari_agent/AgentConfig_linux.py a90b8ba
ambari-agent/src/main/python/ambari_agent/main.py e43d901
ambari-agent/src/main/python/ambari_agent/shell.py df6f0ca
ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSRunner.java 3bce55a
ambari-server/src/main/java/org/apache/ambari/server/bootstrap/SshHostInfo.java 34813f4
ambari-server/src/main/python/bootstrap.py bf989d0
ambari-server/src/main/python/setupAgent.py aae5935
ambari-server/src/test/python/TestBootstrap.py d0295a2
ambari-server/src/test/python/TestSetupAgent.py 9ca9e01
Diff: https://reviews.apache.org/r/28000/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 28000: Bootstaraping and starting agents as
non-root
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28000/
-----------------------------------------------------------
(Updated Nov. 18, 2014, 3:19 p.m.)
Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
Bugs: AMBARI-8316
https://issues.apache.org/jira/browse/AMBARI-8316
Repository: ambari
Description
-------
This does not include deploy with non-root agents, which will be implemented in a separate jira(s).
Diffs (updated)
-----
ambari-agent/conf/unix/ambari-agent 88fa0b9
ambari-agent/conf/unix/ambari-agent.ini 41e2895
ambari-agent/etc/init.d/ambari-agent 994ca77
ambari-agent/src/main/python/ambari_agent/AgentConfig_linux.py a90b8ba
ambari-agent/src/main/python/ambari_agent/main.py e43d901
ambari-agent/src/main/python/ambari_agent/shell.py df6f0ca
ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSRunner.java 3bce55a
ambari-server/src/main/java/org/apache/ambari/server/bootstrap/SshHostInfo.java 34813f4
ambari-server/src/main/python/bootstrap.py bf989d0
ambari-server/src/main/python/setupAgent.py aae5935
ambari-server/src/test/python/TestBootstrap.py d0295a2
ambari-server/src/test/python/TestSetupAgent.py 9ca9e01
Diff: https://reviews.apache.org/r/28000/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 28000: Bootstaraping and starting agents as
non-root
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28000/
-----------------------------------------------------------
(Updated Nov. 14, 2014, 2:18 p.m.)
Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
Bugs: AMBARI-8316
https://issues.apache.org/jira/browse/AMBARI-8316
Repository: ambari
Description
-------
This does not include deploy with non-root agents, which will be implemented in a separate jira(s).
Diffs (updated)
-----
ambari-agent/conf/unix/ambari-agent 88fa0b9
ambari-agent/conf/unix/ambari-agent.ini 41e2895
ambari-agent/etc/init.d/ambari-agent 994ca77
ambari-agent/src/main/python/ambari_agent/AgentConfig_linux.py a90b8ba
ambari-agent/src/main/python/ambari_agent/main.py 84182c0
ambari-agent/src/main/python/ambari_agent/shell.py df6f0ca
ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSRunner.java 3bce55a
ambari-server/src/main/java/org/apache/ambari/server/bootstrap/SshHostInfo.java 34813f4
ambari-server/src/main/python/bootstrap.py bf989d0
ambari-server/src/main/python/setupAgent.py aae5935
Diff: https://reviews.apache.org/r/28000/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 28000: Bootstaraping and starting agents as
non-root
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28000/
-----------------------------------------------------------
(Updated Nov. 14, 2014, 2:13 p.m.)
Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
Bugs: AMBARI-8316
https://issues.apache.org/jira/browse/AMBARI-8316
Repository: ambari
Description
-------
This does not include deploy with non-root agents, which will be implemented in a separate jira(s).
Diffs (updated)
-----
ambari-agent/conf/unix/ambari-agent 88fa0b9
ambari-agent/conf/unix/ambari-agent.ini 41e2895
ambari-agent/etc/init.d/ambari-agent 994ca77
ambari-agent/src/main/python/ambari_agent/AgentConfig_linux.py a90b8ba
ambari-agent/src/main/python/ambari_agent/main.py 84182c0
ambari-agent/src/main/python/ambari_agent/shell.py df6f0ca
ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSRunner.java 3bce55a
ambari-server/src/main/java/org/apache/ambari/server/bootstrap/SshHostInfo.java 34813f4
ambari-server/src/main/python/bootstrap.py bf989d0
ambari-server/src/main/python/setupAgent.py aae5935
Diff: https://reviews.apache.org/r/28000/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 28000: Bootstaraping and starting agents as
non-root
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28000/#review61433
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Nov. 13, 2014, 6:27 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28000/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2014, 6:27 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
>
>
> Bugs: AMBARI-8316
> https://issues.apache.org/jira/browse/AMBARI-8316
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This does not include deploy with non-root agents, which will be implemented in a separate jira(s).
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/ambari-agent 88fa0b9
> ambari-agent/conf/unix/ambari-agent.ini fc76d0e
> ambari-agent/etc/init.d/ambari-agent 994ca77
> ambari-agent/src/main/python/ambari_agent/AmbariConfig.py ca2e80c
> ambari-agent/src/main/python/ambari_agent/main.py 622e86f
> ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSRunner.java 3bce55a
> ambari-server/src/main/java/org/apache/ambari/server/bootstrap/SshHostInfo.java 34813f4
> ambari-server/src/main/python/bootstrap.py bf989d0
> ambari-server/src/main/python/setupAgent.py aae5935
>
> Diff: https://reviews.apache.org/r/28000/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 28000: Bootstaraping and starting agents as
non-root
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28000/
-----------------------------------------------------------
(Updated Nov. 13, 2014, 6:27 p.m.)
Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
Bugs: AMBARI-8316
https://issues.apache.org/jira/browse/AMBARI-8316
Repository: ambari
Description (updated)
-------
This does not include deploy with non-root agents, which will be implemented in a separate jira(s).
Diffs
-----
ambari-agent/conf/unix/ambari-agent 88fa0b9
ambari-agent/conf/unix/ambari-agent.ini fc76d0e
ambari-agent/etc/init.d/ambari-agent 994ca77
ambari-agent/src/main/python/ambari_agent/AmbariConfig.py ca2e80c
ambari-agent/src/main/python/ambari_agent/main.py 622e86f
ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSRunner.java 3bce55a
ambari-server/src/main/java/org/apache/ambari/server/bootstrap/SshHostInfo.java 34813f4
ambari-server/src/main/python/bootstrap.py bf989d0
ambari-server/src/main/python/setupAgent.py aae5935
Diff: https://reviews.apache.org/r/28000/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk