You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/07/19 15:41:45 UTC
[GitHub] [solr] epugh opened a new pull request, #947: SOLR-16300: migrate assert to non deprecated version
epugh opened a new pull request, #947:
URL: https://github.com/apache/solr/pull/947
https://issues.apache.org/jira/browse/SOLR-16300
# Description
intellij has flagged various deprecations in how we assert in our tests.
# Solution
This PR has two approaches for migrating. One is to use the non deprecated class MatcherAssert, the other is to override the deprecated method from the `org.junit.Assert` class that our tests inherit from, and use the non deprecated class.
# Tests
Ran `gw test` successfully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on a diff in pull request #947: SOLR-16300: migrate assert to non deprecated version
Posted by GitBox <gi...@apache.org>.
epugh commented on code in PR #947:
URL: https://github.com/apache/solr/pull/947#discussion_r925824050
##########
solr/test-framework/src/java/org/apache/solr/cloud/SolrCloudTestCase.java:
##########
@@ -72,6 +74,11 @@
*/
public class SolrCloudTestCase extends SolrTestCaseJ4 {
+
+ public static <T> void assertThat(T actual, Matcher<? super T> matcher) {
Review Comment:
So... Am I taking it that you prefer (at least for the tests) that we override the method in the base class? If we go all the way up the tree in Solr, it would I think be `SolrTestCase` where we would move the method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #947: SOLR-16300: migrate assert to non deprecated version
Posted by GitBox <gi...@apache.org>.
epugh commented on PR #947:
URL: https://github.com/apache/solr/pull/947#issuecomment-1227689974
Thanks for approving the changes @uschindler! I'm waiting on @cpoerschke to finish her review, and the SolrJ-Zookeeper to get merged, and then I'll merge this one!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #947: SOLR-16300: migrate assert to non deprecated version
Posted by GitBox <gi...@apache.org>.
epugh commented on PR #947:
URL: https://github.com/apache/solr/pull/947#issuecomment-1195594149
@cpoerschke I'd love a review, I think this is ready!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #947: SOLR-16300: migrate assert to non deprecated version
Posted by GitBox <gi...@apache.org>.
epugh commented on PR #947:
URL: https://github.com/apache/solr/pull/947#issuecomment-1281294752
I was on the wrong branch, and just was testing out ` java.lang.AssertionError: One of the overrides of setUp does not propagate the call.` these as well...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] uschindler commented on pull request #947: SOLR-16300: migrate assert to non deprecated version
Posted by GitBox <gi...@apache.org>.
uschindler commented on PR #947:
URL: https://github.com/apache/solr/pull/947#issuecomment-1225985926
> > 19 / 26 files viewed
> > I wonder if we could/should also put the assert versions in question on the 'forbidden list' e.g. https://github.com/apache/solr/tree/main/gradle/validation/forbidden-apis or in some other way to avoid re-introduction of what is cleaned up here?
>
> That is a great suggestion. I haven't touched that feature of our build system before.
You have 3 options:
- add the whole class into the forbiddenapis file (works for MatcherAssert if we do not want to use it)
- add a whole series of a single method name with all overloads (`Class#method(**)`)
- list all methods to be forbidden (can be quite many) with all overloads
I'd add a separate txt file with correct name. The Gradle build automatically loads some forbiddenapis files when a specific dependency is in classpath. So it can be names forbiddenapis-hamcrest.txt (just example, the file name semantics are described in forbiddenapis.gradle). This prevents us from applying forbiddenapis in modules where the forbidden JAR file is not on classpath.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] uschindler commented on a diff in pull request #947: SOLR-16300: migrate assert to non deprecated version
Posted by GitBox <gi...@apache.org>.
uschindler commented on code in PR #947:
URL: https://github.com/apache/solr/pull/947#discussion_r925775026
##########
solr/test-framework/src/java/org/apache/solr/cloud/SolrCloudTestCase.java:
##########
@@ -72,6 +74,11 @@
*/
public class SolrCloudTestCase extends SolrTestCaseJ4 {
+
+ public static <T> void assertThat(T actual, Matcher<? super T> matcher) {
Review Comment:
I am tentative/hesitant:
1. I generally also prefer static imports for normal production code
2. I like Class#staticMethod more, that's also what code guidelines say: "always use class name when invoking static methods as there's no inheritance" (when you call a static method theres no inheritance involved, it is just the compiler hardcoding the class name in the call site)
3. But for testing this is quite horrible to use, because auto-completion by IDEs does not work until you have added the imports and found the correct class. By having it in the base class it is more accessible for quickly writing a test, although this is against #2.
Uwe
##########
solr/test-framework/src/java/org/apache/solr/cloud/SolrCloudTestCase.java:
##########
@@ -72,6 +74,11 @@
*/
public class SolrCloudTestCase extends SolrTestCaseJ4 {
+
+ public static <T> void assertThat(T actual, Matcher<? super T> matcher) {
Review Comment:
I am tentative/hesitant:
1. I generally also prefer static imports for normal production code
2. I like Class#staticMethod more, that's also what code guidelines say: "always use class name when invoking static methods as there's no inheritance" (when you call a static method theres no inheritance involved, it is just the compiler hardcoding the class name in the call site)
3. But for testing this is quite horrible to use, because auto-completion by IDEs does not work until you have added the imports and found the correct class. By having it in the base class it is more accessible for quickly writing a test, although this is against # 2.
Uwe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] sonatype-lift[bot] commented on pull request #947: SOLR-16300: migrate assert to non deprecated version
Posted by GitBox <gi...@apache.org>.
sonatype-lift[bot] commented on PR #947:
URL: https://github.com/apache/solr/pull/947#issuecomment-1279478772
:warning: **314 God Classes** were detected by Lift in this project. [Visit the Lift web console](https://lift.sonatype.com/results/github.com/apache/solr/01GFC2S65YK4FJF0H2HX0ESBWD?tab=technical-debt&utm_source=github.com&utm_campaign=lift-comment&utm_content=apache\%20solr) for more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #947: SOLR-16300: migrate assert to non deprecated version
Posted by GitBox <gi...@apache.org>.
epugh commented on PR #947:
URL: https://github.com/apache/solr/pull/947#issuecomment-1190727394
Did a bit more work, and I think we should:
- [ ] Eliminate all the `MatcherAssert.assertThat` and just have `assertThat()`
- [ ] Eliminate all the `@Rule public ExpectedException` in favour of `assertThrows()`
- [ ] Double check all the files for other asserts that can be simplified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #947: SOLR-16300: migrate assert to non deprecated version
Posted by GitBox <gi...@apache.org>.
epugh commented on PR #947:
URL: https://github.com/apache/solr/pull/947#issuecomment-1227220289
I gave it a stab of adding it to forbiddenapis, but didn't quite get it to work... There are *some* places that it's okay, like in the LTR module... May need a pairing session to grok this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #947: SOLR-16300: migrate assert to non deprecated version
Posted by GitBox <gi...@apache.org>.
epugh commented on PR #947:
URL: https://github.com/apache/solr/pull/947#issuecomment-1195548367
So, I am rethinking this PR... I think I was falling into the trap of having too many different changes in one PR... So, I'm going to remove the task "Double check all the files for other asserts that can be simplified.", as that is a LOT of changes. I will go through and clean up any `MatcherAssert.assertThat` that can be replaced with a `assertThat` if they extend the right Solr test base class....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #947: SOLR-16300: migrate assert to non deprecated version
Posted by GitBox <gi...@apache.org>.
epugh commented on PR #947:
URL: https://github.com/apache/solr/pull/947#issuecomment-1281421975
Okay, this time things ran! Thanks for the fixes @risdenk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on a diff in pull request #947: SOLR-16300: migrate assert to non deprecated version
Posted by GitBox <gi...@apache.org>.
risdenk commented on code in PR #947:
URL: https://github.com/apache/solr/pull/947#discussion_r996247746
##########
solr/test-framework/src/java/org/apache/solr/cloud/SolrCloudTestCase.java:
##########
@@ -72,6 +74,11 @@
*/
public class SolrCloudTestCase extends SolrTestCaseJ4 {
+
+ public static <T> void assertThat(T actual, Matcher<? super T> matcher) {
Review Comment:
The static import also doesn't work in each file since the base class already has the static method `assertThat` - so the only solution is to explicitly do `MatcherAssert.assertThat`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] uschindler commented on a diff in pull request #947: SOLR-16300: migrate assert to non deprecated version
Posted by GitBox <gi...@apache.org>.
uschindler commented on code in PR #947:
URL: https://github.com/apache/solr/pull/947#discussion_r925826425
##########
solr/test-framework/src/java/org/apache/solr/cloud/SolrCloudTestCase.java:
##########
@@ -72,6 +74,11 @@
*/
public class SolrCloudTestCase extends SolrTestCaseJ4 {
+
+ public static <T> void assertThat(T actual, Matcher<? super T> matcher) {
Review Comment:
+1
But please remove the empty message below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on a diff in pull request #947: SOLR-16300: migrate assert to non deprecated version
Posted by GitBox <gi...@apache.org>.
epugh commented on code in PR #947:
URL: https://github.com/apache/solr/pull/947#discussion_r925758259
##########
solr/test-framework/src/java/org/apache/solr/cloud/SolrCloudTestCase.java:
##########
@@ -72,6 +74,11 @@
*/
public class SolrCloudTestCase extends SolrTestCaseJ4 {
+
+ public static <T> void assertThat(T actual, Matcher<? super T> matcher) {
Review Comment:
The static import seems better than the explicit `MatcherAssert.assertThat`..... So... How do we get a decision on this? Is there anything in our code style guide that would guide us to one of these choices???
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on a diff in pull request #947: SOLR-16300: migrate assert to non deprecated version
Posted by GitBox <gi...@apache.org>.
epugh commented on code in PR #947:
URL: https://github.com/apache/solr/pull/947#discussion_r924806224
##########
solr/test-framework/src/java/org/apache/solr/cloud/SolrCloudTestCase.java:
##########
@@ -72,6 +74,11 @@
*/
public class SolrCloudTestCase extends SolrTestCaseJ4 {
+
+ public static <T> void assertThat(T actual, Matcher<? super T> matcher) {
Review Comment:
I put it here, only to posit that this might work! I agree that we probably want it as high up the hierachy as possible...
DO you think this is a reasonable approach, or should we instead use explicit `MatcherAssert.assertThat` everywhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on pull request #947: SOLR-16300: migrate assert to non deprecated version
Posted by GitBox <gi...@apache.org>.
madrob commented on PR #947:
URL: https://github.com/apache/solr/pull/947#issuecomment-1195756067
See also https://github.com/apache/lucene/pull/1049 and LUCENE-10662
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] uschindler commented on a diff in pull request #947: SOLR-16300: migrate assert to non deprecated version
Posted by GitBox <gi...@apache.org>.
uschindler commented on code in PR #947:
URL: https://github.com/apache/solr/pull/947#discussion_r925775026
##########
solr/test-framework/src/java/org/apache/solr/cloud/SolrCloudTestCase.java:
##########
@@ -72,6 +74,11 @@
*/
public class SolrCloudTestCase extends SolrTestCaseJ4 {
+
+ public static <T> void assertThat(T actual, Matcher<? super T> matcher) {
Review Comment:
I am tentative/hesitant:
1. I generally also prefer static imports for normal production code, if you call the method many times and don't want to repeat class name.
2. I like Class#staticMethod more, that's also what code guidelines say: "always use class name when invoking static methods as there's no inheritance" (when you call a static method theres no inheritance involved, it is just the compiler hardcoding the class name in the call site)
3. But for testing this is quite horrible to use, because auto-completion by IDEs does not work until you have added the imports and found the correct class. By having it in the base class it is more accessible for quickly writing a test, although this is against # 2.
Uwe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] cpoerschke commented on a diff in pull request #947: SOLR-16300: migrate assert to non deprecated version
Posted by GitBox <gi...@apache.org>.
cpoerschke commented on code in PR #947:
URL: https://github.com/apache/solr/pull/947#discussion_r925573261
##########
solr/test-framework/src/java/org/apache/solr/cloud/SolrCloudTestCase.java:
##########
@@ -72,6 +74,11 @@
*/
public class SolrCloudTestCase extends SolrTestCaseJ4 {
+
+ public static <T> void assertThat(T actual, Matcher<? super T> matcher) {
Review Comment:
Explicit `MatcherAssert.assertThat` seems quite intrusive, but that's of course subjective.
Wondering if `import static org.hamcrest.MatcherAssert.assertThat;` might provide a third alternative e.g. see https://github.com/apache/solr/blob/releases/solr/9.0.0/solr/modules/ltr/src/test/org/apache/solr/ltr/interleaving/algorithms/TeamDraftInterleavingTest.java usage?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #947: SOLR-16300: migrate assert to non deprecated version
Posted by GitBox <gi...@apache.org>.
risdenk commented on PR #947:
URL: https://github.com/apache/solr/pull/947#issuecomment-1281091689
I'm getting a bunch of failures...
```
ERROR: The following test(s) have failed:
- org.apache.solr.util.configuration.SSLConfigurationsTest.testGetKeyStorePasswordFromHadoopCredentialProvider (:solr:modules:hadoop-auth)
Test output: /Users/risdenk/repos/apache/solr/solr/modules/hadoop-auth/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.configuration.SSLConfigurationsTest.txt
Reproduce with: gradlew :solr:modules:hadoop-auth:test --tests "org.apache.solr.util.configuration.SSLConfigurationsTest.testGetKeyStorePasswordFromHadoopCredentialProvider" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8
- org.apache.solr.util.configuration.SSLConfigurationsTest.testGetTruststorePasswordFromHadoopCredentialProvider (:solr:modules:hadoop-auth)
Test output: /Users/risdenk/repos/apache/solr/solr/modules/hadoop-auth/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.configuration.SSLConfigurationsTest.txt
Reproduce with: gradlew :solr:modules:hadoop-auth:test --tests "org.apache.solr.util.configuration.SSLConfigurationsTest.testGetTruststorePasswordFromHadoopCredentialProvider" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8
- org.apache.solr.util.configuration.SSLConfigurationsTest.testGetClientTruststorePasswordFromHadoopCredentialProvider (:solr:modules:hadoop-auth)
Test output: /Users/risdenk/repos/apache/solr/solr/modules/hadoop-auth/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.configuration.SSLConfigurationsTest.txt
Reproduce with: gradlew :solr:modules:hadoop-auth:test --tests "org.apache.solr.util.configuration.SSLConfigurationsTest.testGetClientTruststorePasswordFromHadoopCredentialProvider" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8
- org.apache.solr.util.configuration.SSLConfigurationsTest.testHadoopCredentialProviderPrioritySysPropAndEnvVars (:solr:modules:hadoop-auth)
Test output: /Users/risdenk/repos/apache/solr/solr/modules/hadoop-auth/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.configuration.SSLConfigurationsTest.txt
Reproduce with: gradlew :solr:modules:hadoop-auth:test --tests "org.apache.solr.util.configuration.SSLConfigurationsTest.testHadoopCredentialProviderPrioritySysPropAndEnvVars" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8
- org.apache.solr.util.configuration.SSLConfigurationsTest.testSslConfigKeystorePwFromKeystoreHadoopCredentialProvider (:solr:modules:hadoop-auth)
Test output: /Users/risdenk/repos/apache/solr/solr/modules/hadoop-auth/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.configuration.SSLConfigurationsTest.txt
Reproduce with: gradlew :solr:modules:hadoop-auth:test --tests "org.apache.solr.util.configuration.SSLConfigurationsTest.testSslConfigKeystorePwFromKeystoreHadoopCredentialProvider" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8
- org.apache.solr.util.configuration.SSLConfigurationsTest.testSslConfigKeystorePwFromClientKeystoreHadoopCredentialProvider (:solr:modules:hadoop-auth)
Test output: /Users/risdenk/repos/apache/solr/solr/modules/hadoop-auth/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.configuration.SSLConfigurationsTest.txt
Reproduce with: gradlew :solr:modules:hadoop-auth:test --tests "org.apache.solr.util.configuration.SSLConfigurationsTest.testSslConfigKeystorePwFromClientKeystoreHadoopCredentialProvider" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8
- org.apache.solr.util.configuration.SSLConfigurationsTest.testGetClientKeyStorePasswordFromHadoopCredentialProvider (:solr:modules:hadoop-auth)
Test output: /Users/risdenk/repos/apache/solr/solr/modules/hadoop-auth/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.configuration.SSLConfigurationsTest.txt
Reproduce with: gradlew :solr:modules:hadoop-auth:test --tests "org.apache.solr.util.configuration.SSLConfigurationsTest.testGetClientKeyStorePasswordFromHadoopCredentialProvider" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8
- org.apache.solr.core.TestSolrXml.testIntAsLongBad (:solr:core)
Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.core.TestSolrXml.txt
Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.core.TestSolrXml.testIntAsLongBad" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8
- org.apache.solr.util.ModuleUtilsTest.testIsValidName (:solr:core)
Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.ModuleUtilsTest.txt
Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.util.ModuleUtilsTest.testIsValidName" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8
- org.apache.solr.util.ModuleUtilsTest.testListAvailableModules (:solr:core)
Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.ModuleUtilsTest.txt
Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.util.ModuleUtilsTest.testListAvailableModules" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8
- org.apache.solr.util.ModuleUtilsTest.testResolveFromSyspropOrEnv (:solr:core)
Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.ModuleUtilsTest.txt
Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.util.ModuleUtilsTest.testResolveFromSyspropOrEnv" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8
- org.apache.solr.util.ModuleUtilsTest.testGetModuleLibPath (:solr:core)
Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.ModuleUtilsTest.txt
Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.util.ModuleUtilsTest.testGetModuleLibPath" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8
- org.apache.solr.util.ModuleUtilsTest.testModuleExists (:solr:core)
Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.ModuleUtilsTest.txt
Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.util.ModuleUtilsTest.testModuleExists" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8
- org.apache.solr.util.ModuleUtilsTest.testResolveModules (:solr:core)
Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.ModuleUtilsTest.txt
Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.util.ModuleUtilsTest.testResolveModules" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8
- org.apache.solr.util.configuration.SSLConfigurationsTest.testGetKeyStorePasswordFromEnv (:solr:core)
Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.configuration.SSLConfigurationsTest.txt
Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.util.configuration.SSLConfigurationsTest.testGetKeyStorePasswordFromEnv" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8
- org.apache.solr.util.configuration.SSLConfigurationsTest.testGetTrustStorePasswordFromProperty (:solr:core)
Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.configuration.SSLConfigurationsTest.txt
Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.util.configuration.SSLConfigurationsTest.testGetTrustStorePasswordFromProperty" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8
- org.apache.solr.util.configuration.SSLConfigurationsTest.testSslConfigKeystorePwNotOverwrittenIfExists (:solr:core)
Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.configuration.SSLConfigurationsTest.txt
Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.util.configuration.SSLConfigurationsTest.testSslConfigKeystorePwNotOverwrittenIfExists" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8
- org.apache.solr.util.configuration.SSLConfigurationsTest.testGetTrustStorePasswordFromEnv (:solr:core)
Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.configuration.SSLConfigurationsTest.txt
Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.util.configuration.SSLConfigurationsTest.testGetTrustStorePasswordFromEnv" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8
- org.apache.solr.util.configuration.SSLConfigurationsTest.testSslConfigKeystorePwFromBothEnvVars (:solr:core)
Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.configuration.SSLConfigurationsTest.txt
Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.util.configuration.SSLConfigurationsTest.testSslConfigKeystorePwFromBothEnvVars" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8
- org.apache.solr.util.configuration.SSLConfigurationsTest.testGetClientKeyStorePasswordFromProperty (:solr:core)
Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.configuration.SSLConfigurationsTest.txt
Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.util.configuration.SSLConfigurationsTest.testGetClientKeyStorePasswordFromProperty" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8
- org.apache.solr.util.configuration.SSLConfigurationsTest.testSslConfigTruststorePwNotOverwrittenIfExists (:solr:core)
Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.configuration.SSLConfigurationsTest.txt
Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.util.configuration.SSLConfigurationsTest.testSslConfigTruststorePwNotOverwrittenIfExists" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8
- org.apache.solr.util.configuration.SSLConfigurationsTest.testSslConfigKeystorePwFromClientKeystoreEnvVar (:solr:core)
Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.configuration.SSLConfigurationsTest.txt
Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.util.configuration.SSLConfigurationsTest.testSslConfigKeystorePwFromClientKeystoreEnvVar" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8
- org.apache.solr.util.configuration.SSLConfigurationsTest.testSslConfigTruststorePwFromBothEnvVars (:solr:core)
Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.configuration.SSLConfigurationsTest.txt
Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.util.configuration.SSLConfigurationsTest.testSslConfigTruststorePwFromBothEnvVars" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8
- org.apache.solr.util.configuration.SSLConfigurationsTest.testGetClientTrustStorePasswordFromEnv (:solr:core)
Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.configuration.SSLConfigurationsTest.txt
Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.util.configuration.SSLConfigurationsTest.testGetClientTrustStorePasswordFromEnv" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8
- org.apache.solr.util.configuration.SSLConfigurationsTest.testGetClientTrustStorePasswordFromProperty (:solr:core)
Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.configuration.SSLConfigurationsTest.txt
Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.util.configuration.SSLConfigurationsTest.testGetClientTrustStorePasswordFromProperty" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8
- org.apache.solr.util.configuration.SSLConfigurationsTest.testGetClientKeyStorePasswordFromEnv (:solr:core)
Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.configuration.SSLConfigurationsTest.txt
Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.util.configuration.SSLConfigurationsTest.testGetClientKeyStorePasswordFromEnv" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8
- org.apache.solr.util.configuration.SSLConfigurationsTest.testSslConfigKeystorePwFromKeystoreEnvVar (:solr:core)
Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.configuration.SSLConfigurationsTest.txt
Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.util.configuration.SSLConfigurationsTest.testSslConfigKeystorePwFromKeystoreEnvVar" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8
- org.apache.solr.util.configuration.SSLConfigurationsTest.testSystemPropertyPriorityOverEnvVar (:solr:core)
Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.configuration.SSLConfigurationsTest.txt
Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.util.configuration.SSLConfigurationsTest.testSystemPropertyPriorityOverEnvVar" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8
- org.apache.solr.util.configuration.SSLConfigurationsTest.testGetKeyStorePasswordFromProperty (:solr:core)
Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.configuration.SSLConfigurationsTest.txt
Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.util.configuration.SSLConfigurationsTest.testGetKeyStorePasswordFromProperty" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8
- org.apache.solr.util.configuration.SSLConfigurationsTest.testSslConfigTruststorePwFromKeystoreEnvVar (:solr:core)
Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.configuration.SSLConfigurationsTest.txt
Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.util.configuration.SSLConfigurationsTest.testSslConfigTruststorePwFromKeystoreEnvVar" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8
- org.apache.solr.util.configuration.SSLConfigurationsTest.testSslConfigTruststorePwFromClientKeystoreEnvVar (:solr:core)
Test output: /Users/risdenk/repos/apache/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.util.configuration.SSLConfigurationsTest.txt
Reproduce with: gradlew :solr:core:test --tests "org.apache.solr.util.configuration.SSLConfigurationsTest.testSslConfigTruststorePwFromClientKeystoreEnvVar" -Ptests.jvms=5 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=403B35E05244A844 -Ptests.file.encoding=UTF-8
FAILURE: Build completed with 2 failures.
```
so need to fix these:
```
> java.lang.AssertionError: One of the overrides of setUp does not propagate the call.
> at __randomizedtesting.SeedInfo.seed([403B35E05244A844:4673E8D5BA170D50]:0)
> at org.junit.Assert.fail(Assert.java:89)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #947: SOLR-16300: migrate assert to non deprecated version
Posted by GitBox <gi...@apache.org>.
risdenk commented on PR #947:
URL: https://github.com/apache/solr/pull/947#issuecomment-1279828915
> it this PR maybe just going down the wrong approach?
no I don't think so. As Uwe said, should really be Class#method for static and this now follows that approach. Ideally this would have been the same way as Assert.assertThat originally, but oh well. This at least makes everything consistent. It only looks ugly once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #947: SOLR-16300: migrate assert to non deprecated version
Posted by GitBox <gi...@apache.org>.
epugh commented on PR #947:
URL: https://github.com/apache/solr/pull/947#issuecomment-1279494678
> I merged main to this. @epugh were you going to do the forbiddenapis stuff? This looks like it never got merged. The tests should be kicked off again shortly.
I tried the forbiddenapis, and I think I didn't quite grok how it all worked, and ran out of energy.... If you wanted to add them to forbiddenapis, that would be great.. Otherwise, I'm happy to see this get merged!!!
Thanks for reviewing and updating these older PR's!!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #947: SOLR-16300: migrate assert to non deprecated version
Posted by GitBox <gi...@apache.org>.
risdenk commented on PR #947:
URL: https://github.com/apache/solr/pull/947#issuecomment-1279651282
I added forbiddenapis and went down the rabbit hole w/ this.
So we can't override assertThat in SolrTestCase since its static and comes from Assert which is what LuceneTestCase derives from. ForbiddenApis correctly complains that we can't just override the static method and instead knows that Assert#assertThat is still being called. So the solution in this PR isn't going to work as is.
The MatcherAssert.assertThat static import also doesn't work in each file since the base class already has the static method assertThat - so the only solution is to explicitly do MatcherAssert.assertThat.
I have a change that does that that I'll push shortly including the forbiddenapis check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #947: SOLR-16300: migrate assert to non deprecated version
Posted by GitBox <gi...@apache.org>.
epugh commented on PR #947:
URL: https://github.com/apache/solr/pull/947#issuecomment-1279731992
it this PR maybe just going down the wrong approach? I'm not wedded to this one, it felt a bit werid to me as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh merged pull request #947: SOLR-16300: migrate assert to non deprecated version
Posted by GitBox <gi...@apache.org>.
epugh merged PR #947:
URL: https://github.com/apache/solr/pull/947
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #947: SOLR-16300: migrate assert to non deprecated version
Posted by GitBox <gi...@apache.org>.
epugh commented on PR #947:
URL: https://github.com/apache/solr/pull/947#issuecomment-1232831100
I've fixed the merge conflict, so I'd like to merge this PR this week, so then I can move on to the new plan of fixing the unit test warnings package by package instead of type by type.....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] cpoerschke commented on a diff in pull request #947: SOLR-16300: migrate assert to non deprecated version
Posted by GitBox <gi...@apache.org>.
cpoerschke commented on code in PR #947:
URL: https://github.com/apache/solr/pull/947#discussion_r924794097
##########
solr/test-framework/src/java/org/apache/solr/cloud/SolrCloudTestCase.java:
##########
@@ -72,6 +74,11 @@
*/
public class SolrCloudTestCase extends SolrTestCaseJ4 {
+
+ public static <T> void assertThat(T actual, Matcher<? super T> matcher) {
Review Comment:
If having this, wondering about having it here in `SolrCloudTestCase` vs. in `SolrTestCaseJ4` vs. in `SolrTestCase` classes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #947: SOLR-16300: migrate assert to non deprecated version
Posted by GitBox <gi...@apache.org>.
epugh commented on PR #947:
URL: https://github.com/apache/solr/pull/947#issuecomment-1225833107
> 19 / 26 files viewed
>
> I wonder if we could/should also put the assert versions in question on the 'forbidden list' e.g. https://github.com/apache/solr/tree/main/gradle/validation/forbidden-apis or in some other way to avoid re-introduction of what is cleaned up here?
That is a great suggestion. I haven't touched that feature of our build system before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] uschindler commented on pull request #947: SOLR-16300: migrate assert to non deprecated version
Posted by GitBox <gi...@apache.org>.
uschindler commented on PR #947:
URL: https://github.com/apache/solr/pull/947#issuecomment-1227484119
We can delay this to a separate PR. I also need try and error for this, because @dweiss implemented that Gradle code which picks the signatures files from that folder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on a diff in pull request #947: SOLR-16300: migrate assert to non deprecated version
Posted by GitBox <gi...@apache.org>.
risdenk commented on code in PR #947:
URL: https://github.com/apache/solr/pull/947#discussion_r996243783
##########
solr/test-framework/src/java/org/apache/solr/cloud/SolrCloudTestCase.java:
##########
@@ -72,6 +74,11 @@
*/
public class SolrCloudTestCase extends SolrTestCaseJ4 {
+
+ public static <T> void assertThat(T actual, Matcher<? super T> matcher) {
Review Comment:
So we can't override assertThat in `SolrTestCase` since its static and comes from `Assert` which is what `LuceneTestCase` derives from. ForbiddenApis correctly complains that we can't just override the static method and instead knows that `Assert#assertThat` is still being called. So the solution in this PR isn't going to work as is. I'm working on an updated patch to handle this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #947: SOLR-16300: migrate assert to non deprecated version
Posted by GitBox <gi...@apache.org>.
risdenk commented on PR #947:
URL: https://github.com/apache/solr/pull/947#issuecomment-1279429732
I merged main to this. @epugh were you going to do the forbiddenapis stuff? This looks like it never got merged. The tests should be kicked off again shortly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org