You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Kaxil Naik (JIRA)" <ji...@apache.org> on 2018/05/23 09:57:00 UTC
[jira] [Commented] (AIRFLOW-2513) Change `bql` to `sql` for
BigQuery Hooks & Operators for consistency
[ https://issues.apache.org/jira/browse/AIRFLOW-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16487003#comment-16487003 ]
Kaxil Naik commented on AIRFLOW-2513:
-------------------------------------
I would like to get thoughts on whether we should deprecate the *bql* parameter after a stable release i.e. show a warning in *Airflow 2.0* and then remove it in *Airflow 2.1* or should we just change it in *Airflow 2.0* and provide instruction on changing it in release log or migration docs.
[~Fokko] [~fenglu] [~joygao]
> Change `bql` to `sql` for BigQuery Hooks & Operators for consistency
> --------------------------------------------------------------------
>
> Key: AIRFLOW-2513
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2513
> Project: Apache Airflow
> Issue Type: Task
> Affects Versions: 1.9.0, 1.8.2
> Reporter: Kaxil Naik
> Assignee: Kaxil Naik
> Priority: Major
> Fix For: 2.0.0
>
>
> After discussing this yesterday with Google data engineers I can confirm that there is nothing called *bql* as used as parameter to pass SQL queries by some of the BigQuery operators and hooks while some of the other Bigquery operators and Hooks have *sql* instead. It makes more sense to stick with *sql* instead of *bql*.
> However as most of the previous stable versions used it, we should first show a deprecation warning for a stable release or we can change this in *Airflow 2.0* and mention it in the release doc that regarding the change of parameter name.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)