You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/09/05 17:50:01 UTC

[GitHub] [pulsar] MarvinCai opened a new pull request #7988: Report compacted topic ledger info when calling get internal stats.

MarvinCai opened a new pull request #7988:
URL: https://github.com/apache/pulsar/pull/7988


   Fixes #7895
   
   ### Motivation
   For get-internal-stats of persistent topic admin cli: https://pulsar.apache.org/docs/en/2.6.0/admin-api-persistent-topics/#get-internal-stats, we can also return the compacted topic ledger id if compaction is enabled. So we'll able to read from ledger without creating additional subscription, it can benefit like querying compacted topic from Pulsar SQL.
   
   ### Modifications
   Expose CompactedTopicContext from CompactedTopicImpl, try to get ledger information of compacted topic ledger if exist in PersistentTopic.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change added tests and can be verified as follows:
   - Added unit test to verify correct compacted ledger info is returned after compaction.
   
   ### Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API: yes
     - The schema: no
     - The default values of configurations:  no
     - The wire protocol: no
     - The rest endpoints: no
     - The admin cli options: no
     - Anything that affects deployment: no
   
   ### Documentation
   
     - Does this pull request introduce a new feature? yes
     - If yes, how is the feature documented? JavaDocs
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] MarvinCai commented on pull request #7988: Report compacted topic ledger info when calling get internal stats.

Posted by GitBox <gi...@apache.org>.
MarvinCai commented on pull request #7988:
URL: https://github.com/apache/pulsar/pull/7988#issuecomment-688442347


   /pulsarbot run License check
   /pulsarbot run unit-tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] MarvinCai commented on pull request #7988: Report compacted topic ledger info when calling get internal stats.

Posted by GitBox <gi...@apache.org>.
MarvinCai commented on pull request #7988:
URL: https://github.com/apache/pulsar/pull/7988#issuecomment-688482927


   /pulsarbot run License check


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] MarvinCai commented on pull request #7988: Report compacted topic ledger info when calling get internal stats.

Posted by GitBox <gi...@apache.org>.
MarvinCai commented on pull request #7988:
URL: https://github.com/apache/pulsar/pull/7988#issuecomment-688453844


   /pulsarbot run Misc / License check


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] MarvinCai commented on pull request #7988: Report compacted topic ledger info when calling get internal stats.

Posted by GitBox <gi...@apache.org>.
MarvinCai commented on pull request #7988:
URL: https://github.com/apache/pulsar/pull/7988#issuecomment-688452111


   /pulsarbot run unit-tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] MarvinCai commented on pull request #7988: Report compacted topic ledger info when calling get internal stats.

Posted by GitBox <gi...@apache.org>.
MarvinCai commented on pull request #7988:
URL: https://github.com/apache/pulsar/pull/7988#issuecomment-688453345


   /pulsarbot run License check


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] MarvinCai commented on pull request #7988: Report compacted topic ledger info when calling get internal stats.

Posted by GitBox <gi...@apache.org>.
MarvinCai commented on pull request #7988:
URL: https://github.com/apache/pulsar/pull/7988#issuecomment-688483113


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] MarvinCai commented on pull request #7988: Report compacted topic ledger info when calling get internal stats.

Posted by GitBox <gi...@apache.org>.
MarvinCai commented on pull request #7988:
URL: https://github.com/apache/pulsar/pull/7988#issuecomment-688400875


   /pulsarbot run-failure-checks
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] MarvinCai commented on pull request #7988: Report compacted topic ledger info when calling get internal stats.

Posted by GitBox <gi...@apache.org>.
MarvinCai commented on pull request #7988:
URL: https://github.com/apache/pulsar/pull/7988#issuecomment-687683398


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] jiazhai merged pull request #7988: Report compacted topic ledger info when calling get internal stats.

Posted by GitBox <gi...@apache.org>.
jiazhai merged pull request #7988:
URL: https://github.com/apache/pulsar/pull/7988


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org